From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EDE1130484 for ; Wed, 1 May 2024 16:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714579632; cv=none; b=Itjt0LKBRvBMQpfo+aE65OEjbIetDHcNxDIFiRKnS0EpMgMJ4RB3KMPl2IbLth9yP1K3Huzm0YuHDu/AnLZAg3W74WI0k1fAZ+dQcvlnGFLdIhid1VXO2a662eh17P1sb36clY3O54VpAtKbP9hjrOwtRP/EKaSK4hqA95XCUag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714579632; c=relaxed/simple; bh=OBhqEyKuT9SGbY1gPylDuVYK6xBEaByxvLrKFZiA8D8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f8GKhzRQEIC1YazjQ/Z5rE/XQixfrqhTJhnC0bsqkq8nlB0vZ07NNpVAPEpd6KF3zjb0czYgy82sj1FkL5VJT89vsXlsZfhnAcwXeFAP9TPcir+yv7LqPdA7P1roNbyAApVuMDDIwP23MQoPZlu5H57CczsMhz7jXFGrUE/arXs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=cVLSPO4N; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="cVLSPO4N" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-78f05341128so482788285a.0 for ; Wed, 01 May 2024 09:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1714579629; x=1715184429; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OBhqEyKuT9SGbY1gPylDuVYK6xBEaByxvLrKFZiA8D8=; b=cVLSPO4NpEYu7PFl9RKOxx9L/Y6USU5VD25hFwQrr063VgZokHQhxT+wqvQPNiH59o YUatDw/oC9VpFeFKHP9/pj1xQY0m6yoPdCNneIVQpVffazogsHJDh9XAsd1MnpQPiPpG 1zeyIfBujbW86IJIPwtmYiQia8fIZdiOIogWByqDGCFSUg8tj5ucVXvMwpQmoEG68na7 J9jGf89nCEp+dnBkYsQTcRyP20RysJDfTu+TR43P8J5/mP+k9bFy58VnI3Tsz4QnKqxs TfPyLk0eGiRGJxmndmYmFw+ELMgspN8182021+0MU9hqftGU1sBTLnaDyhx6W1tHSoMz oPEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714579629; x=1715184429; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OBhqEyKuT9SGbY1gPylDuVYK6xBEaByxvLrKFZiA8D8=; b=uIPjLjqurGvsDP9Xv9Jno21gc1jrOnhCx25mOSLQUEwd65axTfjarqVSESEVapJ2g6 dM3YmAdYmNpPjYU1iiySnB0W0DPU3OEFQtmVHfiUarby0SSt8C8yO6da/04wiNCJ6VkY Gr4xig4tUVyHt3gg4qPoZ/xSUovNmenWtvJXtKsmCawu6l1Q2lu0SicGG9cI5HJ6RL+R bxq03C/vN1F187JfP1fv86v2E6JZnp3tfSCvfdPLcZSBDAMG9ziKlXrnUy7tL0KnTWog dt4BN+4Ixb5F3M7ba7ujTAokO5dQ4tUvMFG1fXD6l2kA1WOtnEwMwdy7IdOsYnK50s5V 5dJw== X-Forwarded-Encrypted: i=1; AJvYcCU5FhC2LihlF6z9sx07/RBoj6THGtQk4YTB426uwUemlyZ+wN0YOrMSX0rPdJ7bxjv3wgZac91sHiKSs8M1+Ze4neCcJPC0pgdTcg== X-Gm-Message-State: AOJu0YzRwEWrungw3CvUg3QWeT7gS124qS8iaEtshuJvZcnNbE3mez4J CbMTBB9I9HoXRWM0rTnYRDW/ZyIT3jo18YTDgzd14aAfQQIa4AAOnuW+w8KpiHs= X-Google-Smtp-Source: AGHT+IEIToKXo0oiLD8614cnvRWTKlqp8YbwZyKQg7eanOTB8s3Hn6dt4BqjP2UpzNxDw9ZcGXsFhg== X-Received: by 2002:a05:620a:2059:b0:78e:e7dc:fd3b with SMTP id d25-20020a05620a205900b0078ee7dcfd3bmr2822573qka.73.1714579629470; Wed, 01 May 2024 09:07:09 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-80-239.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.80.239]) by smtp.gmail.com with ESMTPSA id n6-20020a05620a294600b00790eb55fd58sm3512214qkp.129.2024.05.01.09.07.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:07:08 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1s2CU8-00DuqC-5D; Wed, 01 May 2024 13:07:08 -0300 Date: Wed, 1 May 2024 13:07:08 -0300 From: Jason Gunthorpe To: Tomasz Jeznach Cc: Joerg Roedel , Will Deacon , Robin Murphy , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Sunil V L , Nick Kossifidis , Sebastien Boeuf , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, iommu@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux@rivosinc.com Subject: Re: [PATCH v3 0/7] Linux RISC-V IOMMU Support Message-ID: <20240501160708.GF1723318@ziepe.ca> References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 30, 2024 at 01:01:50PM -0700, Tomasz Jeznach wrote: > This patch series introduces support for RISC-V IOMMU architected > hardware into the Linux kernel. It seems in reasonable shape now, at least in terms of implementing the domain logic. It would be nice if you'd run it through clang-format and correct some of the minor misformatting it will point out. We still like to have a 80 col line limit in most cases. There are many overages here that aren't well justified. And you could consider the nitpicky style advice to use 'reverse christmas tree' for the variable declarations like most of the subsystem is trending toward. Jason