* [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage
@ 2024-05-03 15:44 Rob Herring (Arm)
2024-05-03 17:01 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-05-03 15:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland, Maxime Ripard, Ryan Walklin
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel
Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
handheld gaming device variants") mistakenly added '-' on each line
which created empty (i.e. description only) schemas matching anything.
This causes validation to fail on all the root node compatibles as
there are multiple oneOf clauses passing.
Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index c6d0d8d81ed4..c2a158b75e49 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -57,17 +57,17 @@ properties:
- const: allwinner,sun8i-v3s
- description: Anbernic RG35XX (2024)
- - items:
+ items:
- const: anbernic,rg35xx-2024
- const: allwinner,sun50i-h700
- description: Anbernic RG35XX Plus
- - items:
+ items:
- const: anbernic,rg35xx-plus
- const: allwinner,sun50i-h700
- description: Anbernic RG35XX H
- - items:
+ items:
- const: anbernic,rg35xx-h
- const: allwinner,sun50i-h700
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage
2024-05-03 15:44 [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage Rob Herring (Arm)
@ 2024-05-03 17:01 ` Krzysztof Kozlowski
2024-05-11 8:15 ` Ryan Walklin
2024-05-28 20:47 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-05-03 17:01 UTC (permalink / raw)
To: Rob Herring (Arm), Krzysztof Kozlowski, Conor Dooley,
Chen-Yu Tsai, Jernej Skrabec, Samuel Holland, Maxime Ripard,
Ryan Walklin
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel
On 03/05/2024 17:44, Rob Herring (Arm) wrote:
> Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
> handheld gaming device variants") mistakenly added '-' on each line
> which created empty (i.e. description only) schemas matching anything.
> This causes validation to fail on all the root node compatibles as
> there are multiple oneOf clauses passing.
>
> Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage
2024-05-03 15:44 [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage Rob Herring (Arm)
2024-05-03 17:01 ` Krzysztof Kozlowski
@ 2024-05-11 8:15 ` Ryan Walklin
2024-05-28 20:47 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Ryan Walklin @ 2024-05-11 8:15 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Maxime Ripard
Cc: Krzysztof Kozlowski, devicetree, linux-arm-kernel, linux-sunxi,
linux-kernel
On Sat, 4 May 2024, at 3:44 AM, Rob Herring (Arm) wrote:
> Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
> handheld gaming device variants") mistakenly added '-' on each line
> which created empty (i.e. description only) schemas matching anything.
> This causes validation to fail on all the root node compatibles as
> there are multiple oneOf clauses passing.
>
> Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
> handheld gaming device variants")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
Apologies, thanks for the fix.
Reviewed-by: Ryan Walklin <ryan@testtoast.com>
Regards,
Ryan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage
2024-05-03 15:44 [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage Rob Herring (Arm)
2024-05-03 17:01 ` Krzysztof Kozlowski
2024-05-11 8:15 ` Ryan Walklin
@ 2024-05-28 20:47 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2024-05-28 20:47 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: devicetree, Ryan Walklin, Krzysztof Kozlowski, Samuel Holland,
Chen-Yu Tsai, Krzysztof Kozlowski, linux-sunxi, Jernej Skrabec,
Conor Dooley, Maxime Ripard, linux-kernel, linux-arm-kernel
On Fri, 03 May 2024 10:44:02 -0500, Rob Herring (Arm) wrote:
> Commit 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX
> handheld gaming device variants") mistakenly added '-' on each line
> which created empty (i.e. description only) schemas matching anything.
> This causes validation to fail on all the root node compatibles as
> there are multiple oneOf clauses passing.
>
> Fixes: 6bc6bf8a940a ("dt-bindings: arm: sunxi: document Anbernic RG35XX handheld gaming device variants")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/arm/sunxi.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
No one has picked this up yet, so I have. Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-28 20:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-03 15:44 [PATCH] dt-bindings: arm: sunxi: Fix incorrect '-' usage Rob Herring (Arm)
2024-05-03 17:01 ` Krzysztof Kozlowski
2024-05-11 8:15 ` Ryan Walklin
2024-05-28 20:47 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).