From: Jonathan Cameron <jic23@kernel.org>
To: "Barnabás Czémán" <trabarni@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Danila Tikhonov <danila@jiaxyga.com>
Subject: Re: [PATCH 2/2] dt-bindings: iio: imu: bmi160: add bmi120
Date: Sat, 4 May 2024 12:52:42 +0100 [thread overview]
Message-ID: <20240504125228.0efe24bf@jic23-huawei> (raw)
In-Reply-To: <20240504-bmi120-v1-2-478470a85058@gmail.com>
On Sat, 04 May 2024 01:45:25 +0200
Barnabás Czémán <trabarni@gmail.com> wrote:
> From: Danila Tikhonov <danila@jiaxyga.com>
>
> Document bosch,bmi120 compatible.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> Signed-off-by: Barnbás Czémán <trabarni@gmail.com>
> ---
> Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> index 47cfba939ca6..9ca874aea837 100644
> --- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi160.yaml
> @@ -16,7 +16,9 @@ description: |
>
> properties:
> compatible:
> - const: bosch,bmi160
> + enum:
> + - bosch,bmi120
> + - bosch,bmi160
Please use a fallback compatible for the bmi120 similar to handling
done for st,asm330lhhx in st,lsm6dsx.yaml
Whilst the driver would currently reject the chip ID, the binding should
assume the driver does fallback handling correctly.
Jonathan
>
> reg:
> maxItems: 1
>
prev parent reply other threads:[~2024-05-04 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 23:45 [PATCH 0/2] Add support for bosch bmi120 Barnabás Czémán
2024-05-03 23:45 ` [PATCH 1/2] iio: imu: bmi160: add support for bmi120 Barnabás Czémán
2024-05-04 11:49 ` Jonathan Cameron
2024-05-05 4:36 ` kernel test robot
2024-05-03 23:45 ` [PATCH 2/2] dt-bindings: iio: imu: bmi160: add bmi120 Barnabás Czémán
2024-05-04 11:52 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240504125228.0efe24bf@jic23-huawei \
--to=jic23@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=trabarni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox