From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 164686A031 for ; Sat, 4 May 2024 17:21:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714843264; cv=none; b=SJgr+0UzPPJgU/uCeoJ03nC0DVg+Va+Z9jS28XWpqvc1WSXDz3zdaHU8Rzeuu3zsXEBnu6QAmlPzWcz+dJoMElLuNcLzSAsbPcNmYLZoOk5gzKZPIRtKxHu3J3j1zYheC/GqLat/bn1Gn9LZELkMJZrNn+fcP64UCU75lw+pP9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714843264; c=relaxed/simple; bh=WEzD/Jv9LH/qgyBt7ggSJY1ZRBFRdqqvx9MwD/29YuM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WtoaMIesJJbZEyeRZEh31/h/QCOEsG348XRWPbN9GMkKwQoTU0JM+zWIY0IPHZ0g7bbhdNxjnmsfuJGdqZmkXCFUeTUqdAy+3cNwOPDf0qcx7FHDh+F6QFCaDB9OIvQTvOys1AoxHQNDKdY/qcJYTAtTgwqnNezJtnDbgqDUoDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gNfFsUoC; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gNfFsUoC" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so491248a12.1 for ; Sat, 04 May 2024 10:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714843262; x=1715448062; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9laX2V+CVuA7h00Ylv6RDCBuojEdnvBgJODYE51PhlU=; b=gNfFsUoCY6bX9KWXMGjujhC//1zRH/H3u3zzyPunLI2YaslwxmvZIErtDNXa1dxefM wXx0g/KizwQQ5GKYCeY7PQ7Q/cJ/UA1tKJoKWq5UqbNHkMNHBMkKhL22VbfuP1xPq+6r IDVbtFGB9X59iMLNWSHWah1tqLOFi+PHN/7EWbkJq6ChMfo79S7+UfZvSpmNdu4Uudxk rbHeu86Hn1UID7BZ1h6y4xOqV2lHE9s7GeL7Dp7V3XwkSbOvOn/ZCaK1O/8CXFeMqa9R LKSvBNvre/jXJ67ErIyw+SE+XLmh4FoIV7jVrh/fctnp3m2dafRstjxe8Llf6w1oDCZL sp7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714843262; x=1715448062; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9laX2V+CVuA7h00Ylv6RDCBuojEdnvBgJODYE51PhlU=; b=mZCnbfSo+mOV4qRCvd19AbbyfXIj8Wdd1JQIv93bo6UAKgwTWGtEYF0YjqEZ+4LZyH 0HY4ExokTTbBeeuG2VvYlhaC4+uVL1iqL/0dDsGtIiG/6R5Mz0HY6Yin0mtO+9Y0ZyZj ot9L1CAKV+lrn4R7AH+79SsPq7Jj46yBaAdYfX1f8JHWk3B3Esm7y0l8Helf3vsFGpWW PVNFkA/zGvLmXkGWxYR09wSTwOciFcRLjNmWZ2k4YSmmWWsPgDTVSWywTvqzk5ELM2E7 fXGmKx00c79GdYVjdUqXqIFxzcO0Svj4qIQCsyPPEeGYcj6wxeJhJkyAr5inh+dBwknK 6fdg== X-Forwarded-Encrypted: i=1; AJvYcCVcG3OxquMF7uSZlEPX7dq2y3IkGWnUMJOyJWVfGZRxyaeVVshttUP7mgMXueJMNJbqGfM7rsvkDFwuDNHQuQ/DzpQUhqlBE2vc4A== X-Gm-Message-State: AOJu0YyV0onboQqYgq5YhJhVecctHF3PTQSK1h63rkXH7b73gx7cae5x o80rI06B3QGxW4P69jLlMqxaOuvMfNQ+69OwNxBLvT3st8tHcQNWx2cSJJDgYw== X-Google-Smtp-Source: AGHT+IFyjaSOMKjB8qp6aX4zhqJKBtMXCWvr3PoileGxES65eHv6nsequF71TgXi/KdDGzd92JvURA== X-Received: by 2002:a17:902:d2c6:b0:1eb:b50e:3577 with SMTP id n6-20020a170902d2c600b001ebb50e3577mr7317773plc.56.1714843262260; Sat, 04 May 2024 10:21:02 -0700 (PDT) Received: from thinkpad ([220.158.156.237]) by smtp.gmail.com with ESMTPSA id p9-20020a170902780900b001ea90148816sm5356597pll.253.2024.05.04.10.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 May 2024 10:21:01 -0700 (PDT) Date: Sat, 4 May 2024 22:50:54 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kishon Vijay Abraham I , Arnd Bergmann , Damien Le Moal , Jon Lin , Shawn Lin , Simon Xue , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 10/14] PCI: dw-rockchip: Add explicit rockchip,rk3588-pcie compatible Message-ID: <20240504172054.GG4315@thinkpad> References: <20240430-rockchip-pcie-ep-v1-v2-0-a0f5ee2a77b6@kernel.org> <20240430-rockchip-pcie-ep-v1-v2-10-a0f5ee2a77b6@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240430-rockchip-pcie-ep-v1-v2-10-a0f5ee2a77b6@kernel.org> On Tue, Apr 30, 2024 at 02:01:07PM +0200, Niklas Cassel wrote: > The rockchip-dw-pcie.yaml device tree binding already defines > rockchip,rk3588-pcie as a supported compatible string. > > Add an explicit rockchip,rk3588-pcie entry to make it easier to find the > driver that implements this compatible string. > > Signed-off-by: Niklas Cassel > --- > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index f985539fb00a..f38d267e4e64 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -400,6 +400,10 @@ static const struct of_device_id rockchip_pcie_of_match[] = { > .compatible = "rockchip,rk3568-pcie", > .data = &rockchip_pcie_rc_of_data, > }, > + { > + .compatible = "rockchip,rk3588-pcie", > + .data = &rockchip_pcie_rc_of_data, This is not required. In fact, it is encouraged to just use fallback compatible in DT and not add new entries in driver. - Mani -- மணிவண்ணன் சதாசிவம்