From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Richard Zhu <hongxing.zhu@nxp.com>,
vkoul@kernel.org, kishon@kernel.org,
krzysztof.kozlowski+dt@linaro.org, frank.li@nxp.com,
conor+dt@kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
imx@lists.linux.dev
Subject: Re: [PATCH v4 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY binding
Date: Fri, 10 May 2024 16:52:22 +0100 [thread overview]
Message-ID: <20240510-daisy-overkill-99c4bee476c0@spud> (raw)
In-Reply-To: <20240510153849.GA308062-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]
On Fri, May 10, 2024 at 10:38:49AM -0500, Rob Herring wrote:
> On Thu, May 09, 2024 at 01:56:20PM +0800, Richard Zhu wrote:
> > + fsl,refclk-pad-mode:
> > + description:
> > + Specifies the mode of the refclk pad used. INPUT(PHY refclock is
> > + provided externally via the refclk pad) or OUTPUT(PHY refclock is
> > + derived from SoC internal source and provided on the refclk pad).
> > + $ref: /schemas/types.yaml#/definitions/string
> > + enum: [ "input", "output" ]
>
> default?
>
> Really, this could just be a boolean for the non-default mode.
There's actually a third option, or at least there was in v1, unused.
The description in v1 was:
It can be UNUSED(PHY
refclock is derived from SoC internal source), INPUT(PHY refclock
is provided externally via the refclk pad) or OUTPUT(PHY refclock
is derived from SoC internal source and provided on the refclk pad).
I suggested that there should be 3 strings and not having the property
would mean unused. But all mention of unused seems to have vanished :/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-10 15:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 5:56 [PATCH v4 0/3] Add i.MX8Q HSIO PHY support Richard Zhu
2024-05-09 5:56 ` [PATCH v4 1/3] dt-bindings: phy: phy-imx8-pcie: Add header file for i.MX8Q HSIO SerDes PHY Richard Zhu
2024-05-09 5:56 ` [PATCH v4 2/3] dt-bindings: phy: Add i.MX8Q HSIO SerDes PHY binding Richard Zhu
2024-05-09 7:37 ` Rob Herring (Arm)
2024-05-10 15:38 ` Rob Herring
2024-05-10 15:52 ` Conor Dooley [this message]
2024-05-10 16:10 ` Frank Li
2024-05-11 3:21 ` Hongxing Zhu
2024-05-09 5:56 ` [PATCH v4 3/3] phy: freescale: imx8qm-hsio: Add i.MX8QM HSIO PHY driver support Richard Zhu
2024-05-09 14:44 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510-daisy-overkill-99c4bee476c0@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frank.li@nxp.com \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).