From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05C2E12AAD5; Fri, 10 May 2024 15:32:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715355178; cv=none; b=OKZmJBV7lCtKKUZBh3lP70sNCMjq0eCh3z6OIj9zF560/GwfnuzhZ+AmL3nj/OQrAXHjNj0cBi/0rj25ya5BXUDF3SymQgDyQbjJApfJHF/CV/1HFWj/cmTMzWk5TT9qfF9vCkqV9uuXZOekziPPY0WCpX2wNg0EhhBqR3lYsA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715355178; c=relaxed/simple; bh=ugaNMMw3t62NVbWHQEw5Wz57Ea7qNaXrEup61pOajsE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YjjzuHM9T4pALYgWfRx3hlWgkvfBm4BaFSpS4zc6rtjzkbDwb9o7b9FaSQZIbm2SmZqI4G4EyKJo+STO4BgXbRYz3GSBZijn3r9EhskRxzhU/OPY7EFvn+SrtNIDN4FVV16eHq2trPsKgTy7fX7AHtS7PpQ7WFRy8csRTB4dlYk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=FY24Fgx4; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="FY24Fgx4" Received: by mail.gandi.net (Postfix) with ESMTPSA id 3152820009; Fri, 10 May 2024 15:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715355173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NvpIh3MztCy78ewXd3YEalmoL2kGSw4XpNzZDNRi4V0=; b=FY24Fgx49n4qxpJMFZ2zNBe4gD+NlYtYM+K2PWhBQIMz4VY3rBsbjivq51AzhfKaaPzBhL Ny1rTrjzvpHiG/Qjeotb652MOoT2be5dc0tgEilX2ZBMygBFeCLBbNT5qjU4kDyhPpaNp7 UM0UxV2I0xVHNWGbkT32xL7p3F7RIm+T+RC/vfNHqeix/MI11t4mGJbSYFYhWWxcXm8BD2 q1xiL13YX42hg89tlNgFd3UYeZTHkZfOLp98HmkA7SLK9Rxt5wiBnmwklHF36EK+xFY1yg ufym7uB3GJoauepOfcs0ghanlGM5elnTMzy/snz/qeOMAGthHqiM8kSMmmYolA== Date: Fri, 10 May 2024 17:32:48 +0200 From: Luca Ceresoli To: "Arnd Bergmann" , "Greg Kroah-Hartman" Cc: "Rob Herring" , "Krzysztof Kozlowski" , "Conor Dooley" , "Andrzej Hajda" , "Neil Armstrong" , "Robert Foss" , "laurent.pinchart" , "Jonas Karlman" , "Jernej Skrabec" , "Maarten Lankhorst" , "Maxime Ripard" , "Thomas Zimmermann" , "Dave Airlie" , "Daniel Vetter" , "derek.kiernan@amd.com" , "dragan.cvetic@amd.com" , "Saravana Kannan" , "Paul Kocialkowski" , "Herve Codina" , "Thomas Petazzoni" , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Paul Kocialkowski" Subject: Re: [PATCH v2 5/5] misc: add ge-addon-connector driver Message-ID: <20240510173248.70fa3b60@booty> In-Reply-To: References: <20240510-hotplug-drm-bridge-v2-0-ec32f2c66d56@bootlin.com> <20240510-hotplug-drm-bridge-v2-5-ec32f2c66d56@bootlin.com> <2024051039-decree-shrimp-45c6@gregkh> <20240510125423.25d4b3ed@booty> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: luca.ceresoli@bootlin.com Hi Greg, Arnd, On Fri, 10 May 2024 12:57:24 +0200 "Arnd Bergmann" wrote: > On Fri, May 10, 2024, at 12:54, Luca Ceresoli wrote: > > On Fri, 10 May 2024 12:24:06 +0200 "Arnd Bergmann" wrote: > >> On Fri, May 10, 2024, at 09:55, Greg Kroah-Hartman wrote: > >> > On Fri, May 10, 2024 at 09:10:41AM +0200, Luca Ceresoli wrote: > >> >> > >> >> +config GE_SUNH_CONNECTOR > >> >> + tristate "GE SUNH hotplug add-on connector" > >> >> + depends on OF > >> >> + select OF_OVERLAY > >> >> + select FW_LOADER > >> >> + select NVMEM > >> >> + select DRM_HOTPLUG_BRIDGE > >> > > >> > Can these be depends instead of select? 'select' causes dependencies > >> > that are hard, if not almost impossible, to detect at times why > >> > something is being enabled. > >> > >> I think FW_LOADER needs to be 'select' since it is normally > >> a hidden symbol and gets selected by its users, all the other > >> ones should be 'depends on'. > > > > I see, makes sense. > > > > And as you pointed that out, I realize perhaps DRM_HOTPLUG_BRIDGE could > > become a hidden symbol as it's not expected to be used alone. > > It's slightly easier to keep it as a visible symbol > with 'depends on' though, since otherwise you have to > add 'depends on' statments for anything that DRM_HOTPLUG_BRIDGE > in turn depends on, most notably DRM itself. I see, sure. Thanks both, changes applied locally. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com