From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A34FEC2 for ; Sat, 11 May 2024 06:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715409577; cv=none; b=UL0xpGaOvaVMF9JtXwywGsYaZO/cs4tsRKG24JhGU7gWCAScjzhNMEm2M9Vf0uiMFRfb3bshJg50z15bkr89lkYGtYLbhypXjPBYGmd0asnFCdKLQPdL3+80KERQ9tE4XGvHD2qsHF4oo0xZofW8ynstmojaPRWcsczEwjgQjR8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715409577; c=relaxed/simple; bh=ohIU0BNbyMtZNdVZlUNr4IqV8gPhaMqQ1agVuP69fhM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gdlvwwb2CGlaEpYsLZayj0L+BwdfB3Ijw12XfP9aA03jjZO74evmT6JsCXN6+rhPNLp53SS4kIwFxMqpxrOBLj56hK1mpv0l8LT34Jg9KQ1n6zE1u2YGuBa5AoWFBxCsBOlvH6Z2GgYa6cNLVizezTLGFuN8KKZE7j6fFl4VvVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=g6QWFToX; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g6QWFToX" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-5d81b08d6f2so1851897a12.0 for ; Fri, 10 May 2024 23:39:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715409575; x=1716014375; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=8ZGOyYQlPMjCo7NoBFPkuXTj+4higrK3cJrWnMzKiEg=; b=g6QWFToXQok+V3jhWb2TA3WU/cfN+txc45PKhItOMk96vdRAEaANIWx+gFttgrZYl+ FaI0gNYJJUlNVBsU0WD281elonouHMH79bVjcJIcikEn7fIQq+1qOAg7Oyvqny8ZxMB5 UcM/tzNUBRzotnXfpSVPX9quL1B3mOqbutzAuG5Wrt+3AXVoayqJf6ylehJpcRzJu5fd qJVZl66V3RmCFsyB3I0stWXqVJg3DXjGQyIy5APlEfcU179nQ2E5nYyP5RHRbvbKn+dW EbWLXROGUq5dwKFMtKiMiVJu7m3KL6nm00/lA8Yx6c6eyL9A+Xp7pBdaZWNtUd8iCsmH QoWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715409575; x=1716014375; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8ZGOyYQlPMjCo7NoBFPkuXTj+4higrK3cJrWnMzKiEg=; b=jQU9C6YOTuk8vsVHCwNa8HpLKbkDRcZ7nkhAxTjagAKQAK/5t/EGM/1Szzn8psFAWO rBQ58AlMEl0lXI/88NkOQEJuNcsq2xW7s9uBvb20MX3XSnPy2qtJILUi/XHUs6JstJJn HI6Msam87T8I2CKTkWE+RWLO38whe805MYbSGxeyJSRSjeFGxlAQOw+mvX4xBMEYwzqS OoeTWyVFlbgYsgwogj/Ll0kQTvbN3gLHUXfyTYDrhVIXa+F19RMsM8zvH91uftpwQreQ vfMPAddbGtpdCz4IFIgNrWggOaCV9ZvzKLn3N9OoJHsxfvOMZQIst8H//6KImkZosK7U Gn2g== X-Forwarded-Encrypted: i=1; AJvYcCXL8eAR4zqt0JtHQ7U4YkCysgfKVaooi6WxdoLM8tB4ij8lDTL+EKt3cBFOM18Z9LuOBPPXrVqyIyVzvulC9zGyVrpQtMVoVJNB/g== X-Gm-Message-State: AOJu0Yyzs8PhbRcSiXCBXNTMFOpvU4Vdu0Ox5/92Df3+4kr53HSQdy89 TwdvJtD3NOYXlJl3ahjsLe8tTj6NzgxRs4ow5IJmX7VScG6LdHK/liWRXTcbCw== X-Google-Smtp-Source: AGHT+IFcPHdwaLWt2eocdN1RJhFnTd98pYEBepeLkuj7kAaEyXPW4pVze6C7JF/k2OT36e+fxjw+tA== X-Received: by 2002:a05:6a20:dc95:b0:1a7:60d8:a6dd with SMTP id adf61e73a8af0-1afde1df3b4mr5538644637.53.1715409575282; Fri, 10 May 2024 23:39:35 -0700 (PDT) Received: from thinkpad ([220.158.156.38]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2b671056629sm4242175a91.7.2024.05.10.23.39.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 23:39:34 -0700 (PDT) Date: Sat, 11 May 2024 12:09:29 +0530 From: Manivannan Sadhasivam To: Alexandru Gagniuc Cc: Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Kishon Vijay Abraham I , Michael Turquette , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v4 RESEND 5/8] PCI: qcom: Add support for IPQ9574 Message-ID: <20240511063929.GB6672@thinkpad> References: <20240501042847.1545145-1-mr.nuke.me@gmail.com> <20240501042847.1545145-6-mr.nuke.me@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240501042847.1545145-6-mr.nuke.me@gmail.com> On Tue, Apr 30, 2024 at 11:28:44PM -0500, Alexandru Gagniuc wrote: > IPQ9574 has four PCIe controllers: two single-lane Gen3, and two > dual-lane Gen3. The controllers are identical from a software You mean to say, 'identical to IPQ8074 Gen3 platform' since you are reusing the 2_9_0 cfg? > perspective, with the differences appearing in the PHYs. > > Add a compatible for the PCIe on IPQ9574. > > Signed-off-by: Alexandru Gagniuc But the change looks good to me. Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index ea81ff68d433..e61888e6c63d 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1551,6 +1551,7 @@ static const struct of_device_id qcom_pcie_match[] = { > { .compatible = "qcom,pcie-ipq8064-v2", .data = &cfg_2_1_0 }, > { .compatible = "qcom,pcie-ipq8074", .data = &cfg_2_3_3 }, > { .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 }, > + { .compatible = "qcom,pcie-ipq9574", .data = &cfg_2_9_0 }, > { .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 }, > { .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 }, > { .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp }, > -- > 2.40.1 > -- மணிவண்ணன் சதாசிவம்