[PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema

[PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema

[Xiaxi Shen]

Convert adi,ssm2305 binding to DT schema

It passed dt_binding_check and dtbs_check. Let me know
if you think it should include something else

Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com>
---
 .../devicetree/bindings/sound/adi,ssm2305.txt | 14 --------
 .../bindings/sound/adi,ssm2305.yaml           | 35 +++++++++++++++++++
 2 files changed, 35 insertions(+), 14 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
 create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml

diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt b/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
deleted file mode 100644
index a9c9d83c8a30..000000000000
--- a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
+++ /dev/null
@@ -1,14 +0,0 @@
-Analog Devices SSM2305 Speaker Amplifier
-========================================
-
-Required properties:
-  - compatible : "adi,ssm2305"
-  - shutdown-gpios : The gpio connected to the shutdown pin.
-                     The gpio signal is ACTIVE_LOW.
-
-Example:
-
-ssm2305: analog-amplifier {
-	compatible = "adi,ssm2305";
-	shutdown-gpios = <&gpio3 20 GPIO_ACTIVE_LOW>;
-};
diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml b/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
new file mode 100644
index 000000000000..8335d763bcd5
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/adi,ssm2305.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices SSM2305 Speaker Amplifier
+
+maintainers:
+  - Liam Girdwood <lgirdwood@gmail.com>
+  - Mark Brown <broonie@kernel.org>
+  - Rob Herring <robh@kernel.org>
+  - Krzysztof Kozlowski <krzk+dt@kernel.org>
+  - Conor Dooley <conor+dt@kernel.org>
+
+properties:
+  compatible:
+    const: adi,ssm2305
+
+  shutdown-gpios:
+    maxItems: 1
+    description: The gpio connected to the shutdown pin. The gpio signal is ACTIVE_LOW.
+
+required:
+  - compatible
+  - shutdown-gpios
+
+additionalProperties: false
+
+examples:
+  - |
+   analog-amplifier {
+     compatible = "adi,ssm2305";
+     shutdown-gpios = <&gpio3 20 0>;
+   };
-- 
2.34.1

Re: [PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema

[Krzysztof Kozlowski]

On 11/05/2024 23:47, Xiaxi Shen wrote:
> Convert adi,ssm2305 binding to DT schema
> 
> It passed dt_binding_check and dtbs_check. Let me know
> if you think it should include something else

That's not really related to the commit.

> 
> Signed-off-by: Xiaxi Shen <shenxiaxi26@gmail.com>
> ---
>  .../devicetree/bindings/sound/adi,ssm2305.txt | 14 --------
>  .../bindings/sound/adi,ssm2305.yaml           | 35 +++++++++++++++++++


Same comment as usual... there are no DTS users. Are we done with arm64
defconfig and arm multi_v7 undocumented compatibles? I doubt, 2 months
ago there were hundreds of them. Why touching something without users?

I was speaking about this *multiple times*. Can you update your GSoC or
mentorship guidelines to include this information?


>  2 files changed, 35 insertions(+), 14 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml
> 

...


> +maintainers:
> +  - Liam Girdwood <lgirdwood@gmail.com>
> +  - Mark Brown <broonie@kernel.org>
> +  - Rob Herring <robh@kernel.org>
> +  - Krzysztof Kozlowski <krzk+dt@kernel.org>
> +  - Conor Dooley <conor+dt@kernel.org>

Not really, this should be someone responsible for the device. No
maintainers or recent, main contributors?

> +
> +properties:
> +  compatible:
> +    const: adi,ssm2305
> +
> +  shutdown-gpios:
> +    maxItems: 1
> +    description: The gpio connected to the shutdown pin. The gpio signal is ACTIVE_LOW.
> +
> +required:
> +  - compatible
> +  - shutdown-gpios> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +   analog-amplifier {
> +     compatible = "adi,ssm2305";
> +     shutdown-gpios = <&gpio3 20 0>;

Use proper define for the flag.

> +   };

Best regards,
Krzysztof