From: Conor Dooley <conor@kernel.org>
To: Felix Kaechele <felix@kaechele.ca>
Cc: Job Noorman <job@noorman.info>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A
Date: Sun, 12 May 2024 13:04:50 +0100 [thread overview]
Message-ID: <20240512-trailing-wad-0b9553d03d30@spud> (raw)
In-Reply-To: <dab1dddd-57ae-445e-bce7-879e8d73d809@kaechele.ca>
[-- Attachment #1: Type: text/plain, Size: 873 bytes --]
On Sat, May 11, 2024 at 10:10:08AM -0400, Felix Kaechele wrote:
> On 2024-05-11 08:38, Conor Dooley wrote:
> > On Sat, May 11, 2024 at 08:12:22AM -0400, Felix Kaechele wrote:
> > > Add a compatible string for the Himax HX83100A touch controller.
> > >
> > > Signed-off-by: Felix Kaechele <felix@kaechele.ca>
> >
> > Commit message should mention what makes this device incompatible with
> > the existing device.
>
> Thanks!
>
> I have added this note in the commit message which will be part of a v3,
> coming after I hopefully receive a few more comments on the other parts of
> this change:
>
> The HX83100A presents touch events on its internal bus rather than offering
> a dedicated event register like the other chips in this family do.
Ye, that sounds good. W/ that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-12 12:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 12:12 [PATCH v2 0/5] input: himax_hx83112b: add support for HX83100A Felix Kaechele
2024-05-11 12:12 ` [PATCH v2 1/5] dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A Felix Kaechele
2024-05-11 12:38 ` Conor Dooley
2024-05-11 14:10 ` Felix Kaechele
2024-05-12 12:04 ` Conor Dooley [this message]
2024-05-11 12:12 ` [PATCH v2 2/5] input: himax_hx83112b: use more descriptive register defines Felix Kaechele
2024-05-11 12:12 ` [PATCH v2 3/5] input: himax_hx83112b: implement MCU register reading Felix Kaechele
2024-05-13 23:01 ` Dmitry Torokhov
2024-05-14 9:46 ` Mark Brown
2024-05-14 14:01 ` Felix Kaechele
2024-05-29 23:07 ` Felix Kaechele
2024-05-11 12:12 ` [PATCH v2 4/5] input: himax_hx83112b: add himax_chip struct for multi-chip support Felix Kaechele
2024-05-11 12:12 ` [PATCH v2 5/5] input: himax_hx83112b: add support for HX83100A Felix Kaechele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240512-trailing-wad-0b9553d03d30@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=felix@kaechele.ca \
--cc=job@noorman.info \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).