devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.ibm.com>
To: linux-fsi@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	eajames@linux.ibm.com, krzk+dt@kernel.org, conor+dt@kernel.org,
	robh@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au
Subject: [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes
Date: Tue, 14 May 2024 14:54:27 -0500	[thread overview]
Message-ID: <20240514195435.155372-2-eajames@linux.ibm.com> (raw)
In-Reply-To: <20240514195435.155372-1-eajames@linux.ibm.com>

The FSI2SPI bridge has several SPI controllers behind it, which
should be documented. Also, therefore the node needs to specify
address and size cells.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Depends on https://lore.kernel.org/all/20240514192630.152747-1-eajames@linux.ibm.com/

 .../devicetree/bindings/fsi/ibm,fsi2spi.yaml  | 36 ++++++++++++++++---
 1 file changed, 32 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml b/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
index e2ca0b0004714..ad5c83f484255 100644
--- a/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
+++ b/Documentation/devicetree/bindings/fsi/ibm,fsi2spi.yaml
@@ -9,11 +9,10 @@ title: IBM FSI-attached SPI controllers
 maintainers:
   - Eddie James <eajames@linux.ibm.com>
 
-description: |
+description:
   This binding describes an FSI CFAM engine called the FSI2SPI. Therefore this
-  node will always be a child of an FSI CFAM node; see fsi.txt for details on
-  FSI slave and CFAM nodes. This FSI2SPI engine provides access to a number of
-  SPI controllers.
+  node will always be a child of an FSI CFAM node. This FSI2SPI engine provides
+  access to a number of SPI controllers.
 
 properties:
   compatible:
@@ -24,6 +23,17 @@ properties:
     items:
       - description: FSI slave address
 
+  "#address-cells":
+    const: 1
+
+  "#size-cells":
+    const: 0
+
+patternProperties:
+  "^spi@[0-9a-f]+$":
+    type: object
+    $ref: /schemas/spi/ibm,spi-fsi.yaml
+
 required:
   - compatible
   - reg
@@ -35,4 +45,22 @@ examples:
     fsi2spi@1c00 {
         compatible = "ibm,fsi2spi";
         reg = <0x1c00 0x400>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        spi@0 {
+            compatible = "ibm,spi-fsi";
+            reg = <0>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            eeprom@0 {
+                compatible = "atmel,at25";
+                reg = <0>;
+                address-width = <24>;
+                pagesize = <256>;
+                size = <0x80000>;
+                spi-max-frequency = <1000000>;
+            };
+        };
     };
-- 
2.39.3


  reply	other threads:[~2024-05-14 19:54 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 19:54 [PATCH v5 0/9] dt-bindings: fsi: Convert to json-schema and add missing engines Eddie James
2024-05-14 19:54 ` Eddie James [this message]
2024-05-14 22:35   ` [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Rob Herring (Arm)
2024-05-15  8:14   ` Krzysztof Kozlowski
2024-05-15 13:06     ` Eddie James
2024-05-15 14:12       ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 2/9] dt-bindings: fsi: Document the IBM SCOM engine Eddie James
2024-05-14 19:54 ` [PATCH v5 3/9] dt-bindings: fsi: p9-occ: Convert to json-schema Eddie James
2024-05-15  8:14   ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 4/9] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-05-14 19:54 ` [PATCH v5 5/9] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-05-15 14:18   ` Krzysztof Kozlowski
2024-05-15 14:28     ` Eddie James
2024-05-15 14:35       ` Krzysztof Kozlowski
2024-05-15 15:02         ` Eddie James
2024-05-17  9:17           ` Krzysztof Kozlowski
2024-05-22 14:39           ` Rob Herring
2024-05-14 19:54 ` [PATCH v5 6/9] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-05-14 19:54 ` [PATCH v5 7/9] dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema Eddie James
2024-05-15 14:21   ` Krzysztof Kozlowski
2024-05-15 14:24     ` Eddie James
2024-05-15 14:29       ` Krzysztof Kozlowski
2024-05-15 14:29   ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 8/9] dt-bindings: fsi: Document the AST2700 FSI master Eddie James
2024-05-15 14:21   ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 9/9] dt-bindings: fsi: Document the FSI Hub Controller Eddie James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240514195435.155372-2-eajames@linux.ibm.com \
    --to=eajames@linux.ibm.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=linux-fsi@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).