From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 714E043144 for ; Wed, 15 May 2024 07:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715759410; cv=none; b=buXzjeL143uyCQWQnBytT2eg7CY5st4oSxQystZBhAPwOb/MMLC81Oh0lorZY7bhQuServF3lnEOVdj1vFtjhZeqjwWXGqTGrR1c81fDbvUhb4HYw3t3NVSqFETeCS6kdJ/2WV3A1ACm346+c71OWGnrAth+nQH2xWbqN/uOAqY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715759410; c=relaxed/simple; bh=LoG+7gtU1o+7XCSOkjSuVQBBEuxkH1SzsEnGyxuBS14=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TsNVMj/KSdEAk8OjwUVEOp98TPvhedvP8im1cW77kDCzWJCMmXYRH1NE13v2zNwRFrHmCB+zBw+o+3cu+n7e7fPEtxWZlyrI1oO6AdIMe/b3VbLATolN4U06tFFYdf9xJ7xu3+a4GHliBFMie90eAtV9wBGi/o4HV/FLhEJksRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YeHTprxI; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YeHTprxI" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-42016c8db2aso20129845e9.0 for ; Wed, 15 May 2024 00:50:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715759408; x=1716364208; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=2luu+TEKGzGGESWKjsQ/mAq5vIhVWQJ0g42DRjIbMDs=; b=YeHTprxIS/XNGwwPGNwBIs9B/yQ3IhS9vR/Dej9YdzzbaNBrVxK3+BdmVMFF5Dfdqg sOkSunh+8M4cB4X7RyxWwysdo0TP2b8D0Ug1bSLRo4QgMTFOC6BNRWJBFeccGAaT1xCo IjW87YZ02WyIHDXevVAslAzNO1h5epm+kGQLbx3xx413k4e3F+2sMOBO+blrHV32Bvm7 frRRnRcPsT2hWfzW0u2gTEoQ1BNa/X6wGgna/D9VRYHGfUQDmOd/Hd2KufA6bGvHdQ0U C2JpMC5F23p+F347nCJUgNl5k7nQqpbO9rqwlDf/pOoUrYoMP4bkhokO3KyoQwH9+PyP pRRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715759408; x=1716364208; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2luu+TEKGzGGESWKjsQ/mAq5vIhVWQJ0g42DRjIbMDs=; b=HT3iun3q20qoZ64CsGN/c3ZFQe7f/i0/6i4UruFxTT6glU6j11VSISvJyufRtwvmOx fx9fdnt6vtURr2SWxKuHlYivbaff9APS/RX1BW/kWHnG30Q5o7tvdywo2Re1tsxjX4YR nSTRwHOiB/+hbhF55kbDX4lZNYrq4X64hzJ9d5iN0RnYhln6NrhdI4LY9XzVhQkggYKA 4xi8qYmNyu5T1ztLoJxsD8/KET6/MmbQIFPc6wWVTABXYXg0YKAodOj5Jk4pkQ44lPxN zarIMLA/ZPngdQG2ftalaV7ZPdzlZpeGyyabqCNHfExewhYLymJe6ao48e+pM34xD1f/ OYKA== X-Forwarded-Encrypted: i=1; AJvYcCWm/anlPPX6xbbZqxCTAZhxWYeTqlxmG6G7DmDjXN7hZlD+GEUcI+75MO4TswdwioORJ0H8q5xqsTNVfYFrKoJRUuGcFFcJzTOyVQ== X-Gm-Message-State: AOJu0YwK6+4jzfOpYYcgbAQTRICQuseGc9MtZbnrogBevg2L/VQUDmPX K088IUqkVAwwUVbIkiYcrqQPEhuTglsirPIyuAoh4w92KHMrVmcYnki+haAvlw== X-Google-Smtp-Source: AGHT+IEwnw88k+dpNWTBc/h+G+M5vpa6Q0JqTHL3W0/n2a9dKdx0i4MEuejJLaApdV2aAiJ/HxYQGg== X-Received: by 2002:a05:600c:450e:b0:418:dbad:c57d with SMTP id 5b1f17b1804b1-41feac5ba78mr111020505e9.28.1715759407711; Wed, 15 May 2024 00:50:07 -0700 (PDT) Received: from thinkpad ([149.14.240.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42011d91edfsm129656185e9.44.2024.05.15.00.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 May 2024 00:50:07 -0700 (PDT) Date: Wed, 15 May 2024 09:50:05 +0200 From: Manivannan Sadhasivam To: Conor Dooley Cc: Bjorn Andersson , Konrad Dybcio , Alim Akhtar , Avri Altman , Bart Van Assche , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: ufs: qcom: Use 'ufshc' as the node name for UFS controller nodes Message-ID: <20240515075005.GC2445@thinkpad> References: <20240514-ufs-nodename-fix-v1-0-4c55483ac401@linaro.org> <20240514-ufs-nodename-fix-v1-1-4c55483ac401@linaro.org> <20240514-buggy-sighing-1573000e3f52@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240514-buggy-sighing-1573000e3f52@spud> On Tue, May 14, 2024 at 07:50:15PM +0100, Conor Dooley wrote: > On Tue, May 14, 2024 at 03:08:40PM +0200, Manivannan Sadhasivam wrote: > > Devicetree binding has documented the node name for UFS controllers as > > 'ufshc'. So let's use it instead of 'ufs' which is for the UFS devices. > > Can you point out where that's been documented? Typo here. s/Devicetree binding/Devicetree spec https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter2-devicetree-basics.rst#generic-names-recommendation - Mani > Thanks, > Conor. > > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > index 10c146424baa..37112e17e474 100644 > > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > > @@ -273,7 +273,7 @@ examples: > > #address-cells = <2>; > > #size-cells = <2>; > > > > - ufs@1d84000 { > > + ufshc@1d84000 { > > compatible = "qcom,sm8450-ufshc", "qcom,ufshc", > > "jedec,ufs-2.0"; > > reg = <0 0x01d84000 0 0x3000>; > > > > -- > > 2.25.1 > > -- மணிவண்ணன் சதாசிவம்