* Re: [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core
2024-05-15 6:27 [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core Marek Vasut
@ 2024-05-15 6:31 ` Marek Vasut
2024-05-15 13:47 ` Laurent Pinchart
2024-05-16 17:17 ` Conor Dooley
2 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2024-05-15 6:31 UTC (permalink / raw)
To: devicetree
Cc: Andrzej Hajda, Conor Dooley, Daniel Vetter, David Airlie,
Fabio Estevam, Jernej Skrabec, Jonas Karlman, Krzysztof Kozlowski,
Laurent Pinchart, Liu Ying, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Pengutronix Kernel Team, Philipp Zabel,
Rob Herring, Robert Foss, Sascha Hauer, Shawn Guo,
Thomas Zimmermann, dri-devel, imx, kernel, linux-arm-kernel,
markyao0591
On 5/15/24 8:27 AM, Marek Vasut wrote:
> The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property,
> move the property description into the DW HDMI common DT schema too, so this
> property can be used on all devices integrating the DW HDMI core.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
+CC Mark
> ---
> V2: Update rockchip,dw-hdmi.yaml as well
> ---
> .../bindings/display/bridge/synopsys,dw-hdmi.yaml | 8 ++++++++
> .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml | 8 --------
> .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 8 --------
> 3 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> index 4b7e54a8f037f..828709a8ded26 100644
> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> @@ -45,6 +45,14 @@ properties:
> - const: isfr
> additionalItems: true
>
> + ddc-i2c-bus:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + The HDMI DDC bus can be connected to either a system I2C master or the
> + functionally-reduced I2C master contained in the DWC HDMI. When connected
> + to a system I2C master this property contains a phandle to that I2C
> + master controller.
> +
> interrupts:
> maxItems: 1
>
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> index 7979cf07f1199..180c4b510fb12 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> @@ -31,14 +31,6 @@ properties:
> clock-names:
> maxItems: 2
>
> - ddc-i2c-bus:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description:
> - The HDMI DDC bus can be connected to either a system I2C master or the
> - functionally-reduced I2C master contained in the DWC HDMI. When connected
> - to a system I2C master this property contains a phandle to that I2C
> - master controller.
> -
> gpr:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index 2aac62219ff64..9d096856a79a6 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -70,14 +70,6 @@ properties:
> - vpll
> - ref
>
> - ddc-i2c-bus:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description:
> - The HDMI DDC bus can be connected to either a system I2C master or the
> - functionally-reduced I2C master contained in the DWC HDMI. When connected
> - to a system I2C master this property contains a phandle to that I2C
> - master controller.
> -
> phys:
> maxItems: 1
> description: The HDMI PHY
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core
2024-05-15 6:27 [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core Marek Vasut
2024-05-15 6:31 ` Marek Vasut
@ 2024-05-15 13:47 ` Laurent Pinchart
2024-05-17 20:30 ` Rob Herring
2024-05-16 17:17 ` Conor Dooley
2 siblings, 1 reply; 5+ messages in thread
From: Laurent Pinchart @ 2024-05-15 13:47 UTC (permalink / raw)
To: Marek Vasut
Cc: devicetree, Andrzej Hajda, Conor Dooley, Daniel Vetter,
David Airlie, Fabio Estevam, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Liu Ying, Maarten Lankhorst, Maxime Ripard,
Neil Armstrong, Pengutronix Kernel Team, Philipp Zabel,
Rob Herring, Robert Foss, Sascha Hauer, Shawn Guo,
Thomas Zimmermann, dri-devel, imx, kernel, linux-arm-kernel
Hi Marek,
Thank you for the patch.
On Wed, May 15, 2024 at 08:27:44AM +0200, Marek Vasut wrote:
> The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property,
> move the property description into the DW HDMI common DT schema too, so this
> property can be used on all devices integrating the DW HDMI core.
De-duplicating documentation is good :-)
I see no reason why this property should be disallowed on any of the
platforms that integrate a DW HDMI (unless that platform has no other
I2C controller, but I think we can ignore that in the bindings).
There could be platforms where the DW HDMI DDC pins are not exposed,
making the ddc-i2c-bus property mandatory, but that's something for
platform-specific bindings to handle by simply adding a
required:
- ddc-i2c-bus
That's a separate issue. This patch looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: David Airlie <airlied@gmail.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Liu Ying <victor.liu@nxp.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Maxime Ripard <mripard@kernel.org>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> V2: Update rockchip,dw-hdmi.yaml as well
> ---
> .../bindings/display/bridge/synopsys,dw-hdmi.yaml | 8 ++++++++
> .../devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml | 8 --------
> .../bindings/display/rockchip/rockchip,dw-hdmi.yaml | 8 --------
> 3 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> index 4b7e54a8f037f..828709a8ded26 100644
> --- a/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml
> @@ -45,6 +45,14 @@ properties:
> - const: isfr
> additionalItems: true
>
> + ddc-i2c-bus:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description:
> + The HDMI DDC bus can be connected to either a system I2C master or the
> + functionally-reduced I2C master contained in the DWC HDMI. When connected
> + to a system I2C master this property contains a phandle to that I2C
> + master controller.
> +
> interrupts:
> maxItems: 1
>
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> index 7979cf07f1199..180c4b510fb12 100644
> --- a/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml
> @@ -31,14 +31,6 @@ properties:
> clock-names:
> maxItems: 2
>
> - ddc-i2c-bus:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description:
> - The HDMI DDC bus can be connected to either a system I2C master or the
> - functionally-reduced I2C master contained in the DWC HDMI. When connected
> - to a system I2C master this property contains a phandle to that I2C
> - master controller.
> -
> gpr:
> $ref: /schemas/types.yaml#/definitions/phandle
> description:
> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> index 2aac62219ff64..9d096856a79a6 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
> @@ -70,14 +70,6 @@ properties:
> - vpll
> - ref
>
> - ddc-i2c-bus:
> - $ref: /schemas/types.yaml#/definitions/phandle
> - description:
> - The HDMI DDC bus can be connected to either a system I2C master or the
> - functionally-reduced I2C master contained in the DWC HDMI. When connected
> - to a system I2C master this property contains a phandle to that I2C
> - master controller.
> -
> phys:
> maxItems: 1
> description: The HDMI PHY
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core
2024-05-15 13:47 ` Laurent Pinchart
@ 2024-05-17 20:30 ` Rob Herring
0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2024-05-17 20:30 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Marek Vasut, devicetree, Andrzej Hajda, Conor Dooley,
Daniel Vetter, David Airlie, Fabio Estevam, Jernej Skrabec,
Jonas Karlman, Krzysztof Kozlowski, Liu Ying, Maarten Lankhorst,
Maxime Ripard, Neil Armstrong, Pengutronix Kernel Team,
Philipp Zabel, Robert Foss, Sascha Hauer, Shawn Guo,
Thomas Zimmermann, dri-devel, imx, kernel, linux-arm-kernel
On Wed, May 15, 2024 at 04:47:05PM +0300, Laurent Pinchart wrote:
> Hi Marek,
>
> Thank you for the patch.
>
> On Wed, May 15, 2024 at 08:27:44AM +0200, Marek Vasut wrote:
> > The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property,
> > move the property description into the DW HDMI common DT schema too, so this
> > property can be used on all devices integrating the DW HDMI core.
>
> De-duplicating documentation is good :-)
Generally, yes.
> I see no reason why this property should be disallowed on any of the
> platforms that integrate a DW HDMI (unless that platform has no other
> I2C controller, but I think we can ignore that in the bindings).
The main reason is Because this property should be in a connector node
as the I2C bus is connected to the connector not the HDMI block.
I would suggest this gets marked 'deprecated'. Can be a separate patch.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core
2024-05-15 6:27 [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core Marek Vasut
2024-05-15 6:31 ` Marek Vasut
2024-05-15 13:47 ` Laurent Pinchart
@ 2024-05-16 17:17 ` Conor Dooley
2 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-05-16 17:17 UTC (permalink / raw)
To: Marek Vasut
Cc: devicetree, Andrzej Hajda, Conor Dooley, Daniel Vetter,
David Airlie, Fabio Estevam, Jernej Skrabec, Jonas Karlman,
Krzysztof Kozlowski, Laurent Pinchart, Liu Ying,
Maarten Lankhorst, Maxime Ripard, Neil Armstrong,
Pengutronix Kernel Team, Philipp Zabel, Rob Herring, Robert Foss,
Sascha Hauer, Shawn Guo, Thomas Zimmermann, dri-devel, imx,
kernel, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
On Wed, May 15, 2024 at 08:27:44AM +0200, Marek Vasut wrote:
> The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property,
> move the property description into the DW HDMI common DT schema too, so this
> property can be used on all devices integrating the DW HDMI core.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread