From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BFA513DDBA; Fri, 17 May 2024 17:39:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715967561; cv=none; b=oreC4Lh5U28y1CCugDjwRAVx2yQedye3dA3fQalD5NT6CPgXWPCTA5jLybhQBi6ayzMq4snzWLTsL/AFvaCyARSqvHCazyYAsrlwWrCOtEC8zwG5lapIHsXVh+wM80BB/DiiOdvmzVWdD79DauBd1xEaELujDQz9ZIpb9PBTxns= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715967561; c=relaxed/simple; bh=tQOjsUD1QNNPdmrsBIqeqqeA294m5b+0eJ2vo742SP0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U9xqvbC5EBpD8xzDoavmZ9EPTdEkQ3O+t0Tcpeo5oicDBU8ot5kEnPF8tzfg99ikBwqD7U8pQIbqFMZBD6Tk0EyT0MEFocQKew3H/45PRYm3Qs0A5MohX3G1gGnwGW4SjcgD2LwouvZluSoAHo7yMUQwAXsaqmdT/GRBstIN+1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qgKkClbJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qgKkClbJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFD9DC2BD10; Fri, 17 May 2024 17:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715967560; bh=tQOjsUD1QNNPdmrsBIqeqqeA294m5b+0eJ2vo742SP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qgKkClbJGWKrWh9OKsOPKK3kboH6boQ1WyzS99x6s6Ag1ExaUi5cTlR1KsA/SJRX7 RkQgHw7E5mxTui9FG/Q3Air3GRYzVuAl29hahZXYsFfI0mczO++A2577yDqZp+HTv2 qwGaPLfTJKijYjZpbNzZDykfJS0e/ZgwX/3tvDbIBPC/W6tTRd/b1lwdMVb7/FgIGx tL5AMkdOCVgatLR1QIl3EAe4BuV/XypFXfPVKRP5fFt/xd+yRWyU1iggVdLZ2oI8nY EMeOKBkIodjzVvhD4Lmqp+HqpI/Mj8yACd63tppRo5aFiMqhon7uSWu4biZviK1LE1 KItkRwvJXMqeQ== Date: Fri, 17 May 2024 18:39:16 +0100 From: Conor Dooley To: Chris Packham Cc: Guenter Roeck , Krzysztof Kozlowski , "jdelvare@suse.com" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "linux-hwmon@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: Document adt7475 PWM initial duty cycle Message-ID: <20240517-recognize-broaden-43ba03c9f78c@spud> References: <20240508215504.300580-1-chris.packham@alliedtelesis.co.nz> <20240508215504.300580-2-chris.packham@alliedtelesis.co.nz> <94c843e2-4415-4786-bfd4-a77fdbbfab07@roeck-us.net> <35361786-ef5f-4d81-83e8-e347f47c83ed@alliedtelesis.co.nz> <58fb36f5-4d4b-495b-a7cd-6129ab1ed454@alliedtelesis.co.nz> <20240517-pointer-cloning-3889f3d6f744@spud> <20240517-pellet-visa-a2d469dc5f34@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fU8lYHpRVmPB+Kfl" Content-Disposition: inline In-Reply-To: <20240517-pellet-visa-a2d469dc5f34@spud> --fU8lYHpRVmPB+Kfl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 17, 2024 at 06:02:33PM +0100, Conor Dooley wrote: > On Fri, May 17, 2024 at 06:00:06PM +0100, Conor Dooley wrote: > > > On that point. How would I explain in the bindings that cell 2 is the= =20 > > > duty cycle, cell 3 is the frequency and cell 4 is the flags? > >=20 > > In the pwm-cells property in the pwm provider binding . You might want = to > > order it as as usually that's the ordering done > > in most (all?) pwm provider bindings that I have seen. > > The pwm bindings I think are really unhelpful though - they all say "see > > pwm.yaml for info on the cells in #pwm-cells, but then pwm.yaml has no > > information. The information is actually in pwm.text, but the binding > > conversion did s/pwm.text/pwm.yaml/ in pwm controller bindings. > > I'll send a patch that fixes up pwm.yaml. >=20 > Possibly cell 4 should be standardised as the period for all pwm > providers and then all you'd have to do for your provider is set > #pwm-cells: > minItems: 4 `const: 4`, d'oh. --fU8lYHpRVmPB+Kfl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZkeWRAAKCRB4tDGHoIJi 0s0VAQDSqIpwkV+XgvuoKwnRFDEwmwN4obNBWez9Gf8X0VfxpQD/cNJjz8iKe1Cx EBjxNXyPjLRZyHdRPUETZZRnFhkObg4= =GLZn -----END PGP SIGNATURE----- --fU8lYHpRVmPB+Kfl--