From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Marek Vasut <marex@denx.de>,
devicetree@vger.kernel.org,
Andrzej Hajda <andrzej.hajda@intel.com>,
Conor Dooley <conor+dt@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Jonas Karlman <jonas@kwiboo.se>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Liu Ying <victor.liu@nxp.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
Robert Foss <rfoss@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org, imx@lists.linux.dev,
kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core
Date: Fri, 17 May 2024 15:30:05 -0500 [thread overview]
Message-ID: <20240517203005.GA2893366-robh@kernel.org> (raw)
In-Reply-To: <20240515134705.GA12169@pendragon.ideasonboard.com>
On Wed, May 15, 2024 at 04:47:05PM +0300, Laurent Pinchart wrote:
> Hi Marek,
>
> Thank you for the patch.
>
> On Wed, May 15, 2024 at 08:27:44AM +0200, Marek Vasut wrote:
> > The DW HDMI driver core is responsible for parsing the 'ddc-i2c-bus' property,
> > move the property description into the DW HDMI common DT schema too, so this
> > property can be used on all devices integrating the DW HDMI core.
>
> De-duplicating documentation is good :-)
Generally, yes.
> I see no reason why this property should be disallowed on any of the
> platforms that integrate a DW HDMI (unless that platform has no other
> I2C controller, but I think we can ignore that in the bindings).
The main reason is Because this property should be in a connector node
as the I2C bus is connected to the connector not the HDMI block.
I would suggest this gets marked 'deprecated'. Can be a separate patch.
Rob
next prev parent reply other threads:[~2024-05-17 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 6:27 [PATCH v2] dt-bindings: display: synopsys,dw-hdmi: Document ddc-i2c-bus in core Marek Vasut
2024-05-15 6:31 ` Marek Vasut
2024-05-15 13:47 ` Laurent Pinchart
2024-05-17 20:30 ` Rob Herring [this message]
2024-05-16 17:17 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240517203005.GA2893366-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@dh-electronics.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tzimmermann@suse.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).