From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 588491F5FD; Sun, 19 May 2024 17:59:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716141592; cv=none; b=jsabQ4FcsWXKLqhSFHbsb8v4rJNZ8YIVw83E4UikzUzEaZkdkgYcVHoDijt7i5SdQHxrU5BKePfsBojNu+QFxaKSyHFjUvJRaZCj+PTal+efwm2SrHSFuTMU8+9+10WNK+ZdHU1c/Mf289fg1QtOwWzX8FkzapHwGQZkM53k0mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716141592; c=relaxed/simple; bh=b9LzLpwrP+j5rZSYKDft6Ft3JuawFnIkBxUxMxBNnlo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uilmocxqcBumG57LwXtPWHjOTYCX3pH7NyeVRF2hovPds4uDkIopo0D6hFGwQeNJ/8m9Uz2jIoJkNVOpGm/eP3Xb0MZtiyiBq3ARCOBmRwM/gMT5IvpC5qqKl8q7ZMkC+so1aXBIGuJ7jmcvR9UCN5/37QCGp6is0kQ5P4t4kqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S0Eh/As0; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S0Eh/As0" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1f0937479f8so51740795ad.3; Sun, 19 May 2024 10:59:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716141589; x=1716746389; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4hOXQ/41pPcOGvj8BDEvVxZO6mfZsuadhgYq8hgiByM=; b=S0Eh/As0UYr0qV/u7E1n1aS1p8/Leu0s0atAO3s/6kZm9J7s2RCGdA3afzvchgj6kq HOgbvSLERqnjzvtpocsEIKIfx9SNcmPccRAFYSl3044yMeP4bl5jU6sVxT5TKqsaPl0z GZVtM1z448Hbf0gdULng7oY1UTciPyr9YMCsTc4/ji2nqclucd2LVRb2Cmz9BmwJRAvS abJ4xYKVZp/PSu/oH86nzTmw+uDza8oItgU63eB/RPDdtGroCWdmFGUO3nxWVt7TbNF7 EjRJ8pZBGYsVqhkfDri6yQggCNwOlqbGy+l2XHgO7M1I61F1q2IRPF5/3MNt3rKWQxCE ftkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716141589; x=1716746389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4hOXQ/41pPcOGvj8BDEvVxZO6mfZsuadhgYq8hgiByM=; b=lukK2YS3N++9kmJuTEE0Tm3TlA3DCgQH7qkexU0obFrS1ssjxRlIjzF1zXW1D9Z1I9 NuYRVu75woqxxmQvrSbM68RDzMxy6ew4q/j1k8miOvShlqmN1RhuibUBlmHykmNIsHYB plIwOCk/OrBtzO2nEucQ83V3FSrxnnRwzVEsJp2zlAoP2SU8J8fWaXzJVXEOZTE1hR7y rPkYBZ3Qypx44X0ethCnZUOWXy9RhEVrQFk24zXHRbHDr34aAyICH018OKiTPr8hte+A 6j8Dhs2iseEG2fpQcyji9I+GzEkFdhgmlWJZB05Q7355MJkzbKk71kyhDNBYPoPnnI7h Zyow== X-Forwarded-Encrypted: i=1; AJvYcCXgk4r0tgwqzTwBTNE/37Lqdc+d44hD+JZ76aYaXvi0xQpBUSMmoJcsZwt5scRTyN0YwV/eQdLDu378r7nMghvfeLFgj6dmfGVmLsQbo4AxIzHq79KCJESpeHmu7iGJZ6CXhCHFaIYYRg== X-Gm-Message-State: AOJu0YyG1uFIEuKxQ+kAJ/iZaiUomNIYER7gNlEIVAakTADEZpHp2PzP NyCdoDXyAAHLbv1suBVrnhyPn3+rXUsz2hm3NmhESVzLQsPWwOEAXyjoow== X-Google-Smtp-Source: AGHT+IHF/ZW2hqv6w2mxwXVNTkWpYC8i+PSL4BzYbm7Z1Xpa9Hqws7WzsGyjqnVykQLqzSIfyHFhVA== X-Received: by 2002:a17:902:e892:b0:1f2:fb50:7c1e with SMTP id d9443c01a7336-1f2fb509112mr21380645ad.3.1716141589427; Sun, 19 May 2024 10:59:49 -0700 (PDT) Received: from localhost.localdomain ([223.178.84.79]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f2fc5a015esm9424325ad.14.2024.05.19.10.59.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 May 2024 10:59:48 -0700 (PDT) From: Kanak Shilledar X-Google-Original-From: Kanak Shilledar To: Cc: Kanak Shilledar , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Subject: [PATCH 1/2] dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema Date: Sun, 19 May 2024 23:29:05 +0530 Message-Id: <20240519175906.138410-2-kanakshilledar111@protonmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240519175906.138410-1-kanakshilledar111@protonmail.com> References: <20240519175906.138410-1-kanakshilledar111@protonmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert the RISC-V Hart-Level Interrupt Controller (HLIC) to newer DT schema, Created DT schema based on the .txt file which had `compatible`, `#interrupt-cells` and `interrupt-controller` as required properties. Changes made with respect to original file: - Changed the example to just use interrupt-controller instead of using the whole cpu block - Changed the example compatible string. Signed-off-by: Kanak Shilledar --- Changes in v3: - Remove reference to `interrupt-controller` in `riscv/cpus.yaml`. --- Changes in v2: - Update the maintainers list. - Add reference to `interrupt-controller` in `riscv/cpus.yaml`. - Update compatible property with the reference in `cpus.yaml`. - Include description for '#interrupt-cells' property. - Change '#interrupt-cells' property to have `const: 1` as per the text binding. - Fixed the warning thrown by `/renesas/r9a07g043f01-smarc.dtb`. --- .../interrupt-controller/riscv,cpu-intc.txt | 52 ------------- .../interrupt-controller/riscv,cpu-intc.yaml | 73 +++++++++++++++++++ 2 files changed, 73 insertions(+), 52 deletions(-) delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.yaml diff --git a/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt deleted file mode 100644 index 265b223cd978..000000000000 --- a/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt +++ /dev/null @@ -1,52 +0,0 @@ -RISC-V Hart-Level Interrupt Controller (HLIC) ---------------------------------------------- - -RISC-V cores include Control Status Registers (CSRs) which are local to each -CPU core (HART in RISC-V terminology) and can be read or written by software. -Some of these CSRs are used to control local interrupts connected to the core. -Every interrupt is ultimately routed through a hart's HLIC before it -interrupts that hart. - -The RISC-V supervisor ISA manual specifies three interrupt sources that are -attached to every HLIC: software interrupts, the timer interrupt, and external -interrupts. Software interrupts are used to send IPIs between cores. The -timer interrupt comes from an architecturally mandated real-time timer that is -controlled via Supervisor Binary Interface (SBI) calls and CSR reads. External -interrupts connect all other device interrupts to the HLIC, which are routed -via the platform-level interrupt controller (PLIC). - -All RISC-V systems that conform to the supervisor ISA specification are -required to have a HLIC with these three interrupt sources present. Since the -interrupt map is defined by the ISA it's not listed in the HLIC's device tree -entry, though external interrupt controllers (like the PLIC, for example) will -need to define how their interrupts map to the relevant HLICs. This means -a PLIC interrupt property will typically list the HLICs for all present HARTs -in the system. - -Required properties: -- compatible : "riscv,cpu-intc" -- #interrupt-cells : should be <1>. The interrupt sources are defined by the - RISC-V supervisor ISA manual, with only the following three interrupts being - defined for supervisor mode: - - Source 1 is the supervisor software interrupt, which can be sent by an SBI - call and is reserved for use by software. - - Source 5 is the supervisor timer interrupt, which can be configured by - SBI calls and implements a one-shot timer. - - Source 9 is the supervisor external interrupt, which chains to all other - device interrupts. -- interrupt-controller : Identifies the node as an interrupt controller - -Furthermore, this interrupt-controller MUST be embedded inside the cpu -definition of the hart whose CSRs control these local interrupts. - -An example device tree entry for a HLIC is show below. - - cpu1: cpu@1 { - compatible = "riscv"; - ... - cpu1-intc: interrupt-controller { - #interrupt-cells = <1>; - compatible = "sifive,fu540-c000-cpu-intc", "riscv,cpu-intc"; - interrupt-controller; - }; - }; diff --git a/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.yaml new file mode 100644 index 000000000000..c9c79e0870ff --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/riscv,cpu-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: RISC-V Hart-Level Interrupt Controller (HLIC) + +description: + RISC-V cores include Control Status Registers (CSRs) which are local to + each CPU core (HART in RISC-V terminology) and can be read or written by + software. Some of these CSRs are used to control local interrupts connected + to the core. Every interrupt is ultimately routed through a hart's HLIC + before it interrupts that hart. + + The RISC-V supervisor ISA manual specifies three interrupt sources that are + attached to every HLIC namely software interrupts, the timer interrupt, and + external interrupts. Software interrupts are used to send IPIs between + cores. The timer interrupt comes from an architecturally mandated real- + time timer that is controlled via Supervisor Binary Interface (SBI) calls + and CSR reads. External interrupts connect all other device interrupts to + the HLIC, which are routed via the platform-level interrupt controller + (PLIC). + + All RISC-V systems that conform to the supervisor ISA specification are + required to have a HLIC with these three interrupt sources present. Since + the interrupt map is defined by the ISA it's not listed in the HLIC's device + tree entry, though external interrupt controllers (like the PLIC, for + example) will need to define how their interrupts map to the relevant HLICs. + This means a PLIC interrupt property will typically list the HLICs for all + present HARTs in the system. + +maintainers: + - Palmer Dabbelt + - Paul Walmsley + +properties: + compatible: + oneOf: + - items: + - const: andestech,cpu-intc + - const: riscv,cpu-intc + - const: riscv,cpu-intc + + interrupt-controller: true + + '#interrupt-cells': + const: 1 + description: | + The interrupt sources are defined by the RISC-V supervisor ISA manual, + with only the following three interrupts being defined for + supervisor mode: + - Source 1 is the supervisor software interrupt, which can be sent by + an SBI call and is reserved for use by software. + - Source 5 is the supervisor timer interrupt, which can be configured + by SBI calls and implements a one-shot timer. + - Source 9 is the supervisor external interrupt, which chains to all + other device interrupts. + +required: + - compatible + - '#interrupt-cells' + - interrupt-controller + +additionalProperties: false + +examples: + - | + interrupt-controller { + #interrupt-cells = <1>; + compatible = "riscv,cpu-intc"; + interrupt-controller; + }; -- 2.34.1