From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krishna Manikandan <quic_mkrishn@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, devicetree@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: [PATCH 4/7] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source()
Date: Mon, 20 May 2024 15:12:46 +0300 [thread overview]
Message-ID: <20240520-dpu-handle-te-signal-v1-4-f273b42a089c@linaro.org> (raw)
In-Reply-To: <20240520-dpu-handle-te-signal-v1-0-f273b42a089c@linaro.org>
Setting vsync source makes sense only for DSI CMD panels. Pull the
is_cmd_mode condition out of the function into the calling code, so that
it becomes more explicit.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
index 4988a1029431..bd37a56b4d03 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
@@ -736,8 +736,7 @@ static void _dpu_encoder_update_vsync_source(struct dpu_encoder_virt *dpu_enc,
return;
}
- if (hw_mdptop->ops.setup_vsync_source &&
- disp_info->is_cmd_mode) {
+ if (hw_mdptop->ops.setup_vsync_source) {
for (i = 0; i < dpu_enc->num_phys_encs; i++)
vsync_cfg.ppnumber[i] = dpu_enc->hw_pp[i]->idx;
@@ -1226,7 +1225,8 @@ static void _dpu_encoder_virt_enable_helper(struct drm_encoder *drm_enc)
dpu_enc->cur_master->hw_mdptop->ops.intf_audio_select(
dpu_enc->cur_master->hw_mdptop);
- _dpu_encoder_update_vsync_source(dpu_enc, &dpu_enc->disp_info);
+ if (dpu_enc->disp_info.is_cmd_mode)
+ _dpu_encoder_update_vsync_source(dpu_enc, &dpu_enc->disp_info);
if (dpu_enc->disp_info.intf_type == INTF_DSI &&
!WARN_ON(dpu_enc->num_phys_encs == 0)) {
--
2.39.2
next prev parent reply other threads:[~2024-05-20 12:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 12:12 [PATCH 0/7] drm/msm/dpu: handle non-default TE source pins Dmitry Baryshkov
2024-05-20 12:12 ` [PATCH 1/7] dt-bindings: display/msm/dsi: allow specifying TE source Dmitry Baryshkov
2024-05-22 14:45 ` Rob Herring
2024-05-22 18:38 ` Abhinav Kumar
2024-05-22 20:05 ` Dmitry Baryshkov
2024-05-22 23:57 ` Abhinav Kumar
2024-05-23 9:58 ` Dmitry Baryshkov
2024-05-29 22:57 ` Abhinav Kumar
2024-05-30 0:02 ` Dmitry Baryshkov
2024-05-30 1:08 ` Abhinav Kumar
2024-06-04 15:14 ` Dmitry Baryshkov
2024-06-04 15:22 ` Krzysztof Kozlowski
2024-06-04 15:32 ` Dmitry Baryshkov
2024-06-04 15:36 ` Krzysztof Kozlowski
2024-06-04 17:52 ` Abhinav Kumar
2024-06-05 6:58 ` Krzysztof Kozlowski
2024-06-04 15:41 ` Krzysztof Kozlowski
2024-05-20 12:12 ` [PATCH 2/7] drm/msm/dpu: convert vsync source defines to the enum Dmitry Baryshkov
2024-05-22 18:41 ` Abhinav Kumar
2024-05-22 20:01 ` Dmitry Baryshkov
2024-05-22 23:57 ` Abhinav Kumar
2024-05-20 12:12 ` [PATCH 3/7] drm/msm/dsi: drop unused GPIOs handling Dmitry Baryshkov
2024-05-22 18:44 ` Abhinav Kumar
2024-05-20 12:12 ` Dmitry Baryshkov [this message]
2024-05-22 18:46 ` [PATCH 4/7] drm/msm/dpu: pull the is_cmd_mode out of _dpu_encoder_update_vsync_source() Abhinav Kumar
2024-05-20 12:12 ` [PATCH 5/7] drm/msm/dpu: rework vsync_source handling Dmitry Baryshkov
2024-05-22 19:07 ` Abhinav Kumar
2024-05-20 12:12 ` [PATCH 6/7] drm/msm/dsi: parse vsync source from device tree Dmitry Baryshkov
2024-05-29 23:01 ` Abhinav Kumar
2024-05-20 12:12 ` [PATCH 7/7] drm/msm/dpu: support setting the TE source Dmitry Baryshkov
2024-05-22 18:39 ` [PATCH 0/7] drm/msm/dpu: handle non-default TE source pins Abhinav Kumar
2024-05-22 19:59 ` Dmitry Baryshkov
2024-05-29 23:11 ` Abhinav Kumar
2024-05-29 23:55 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240520-dpu-handle-te-signal-v1-4-f273b42a089c@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marijn.suijten@somainline.org \
--cc=mripard@kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_mkrishn@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).