Re: [PATCH 3/3] dt-bindings: display: vop2: Add VP clock resets

Detlev Casanova
2024-05-22T15:32:00Z

[-- Attachment #1: Type: text/plain, Size: 1754 bytes --]

On Tuesday, May 21, 2024 2:31:51 P.M. EDT Conor Dooley wrote:
> On Tue, May 21, 2024 at 01:15:46PM -0400, Detlev Casanova wrote:
> > On Wednesday, May 15, 2024 12:33:22 P.M. EDT Heiko Stübner wrote:
> > > Am Mittwoch, 15. Mai 2024, 18:19:29 CEST schrieb Conor Dooley:
> > > > On Tue, May 14, 2024 at 11:19:47AM -0400, Detlev Casanova wrote:
> > > > > Add the documentation for VOP2 video ports reset clocks.
> > > > > One reset can be set per video port.
> > > > >
> > > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> > > >
> > > > Are these resets valid for all VOPs or just the one on 3588?
> > >
> > > Not in that form.
> > > I.e. rk3588 has 4 video-ports (0-3), while rk3568 has 3 (0-2).
> > >
> > > So the binding should take into account that rk3568 also has the
> > > SRST_VOP0 ... SRST_VOP2.
> >
> > That is what is set in the example and the reason why I set minItems to 3
> > in the main bindings.
> > Then, the rk3588 specific part sets it to 4.
> >
> > Isn't that enough ?
>
> Not quite - you need to restrict maxItems to 3 for the other devices if
> the clocks are not valid. What you've got says that 4 clocks are
> possible but not needed on !rk3588.
>
> Cheers,
> Conor.

I don't understand what "properties: resets: minItems: 3" means then. I
thought it means that all devices should have at least 3 resets. Then the
allOf below specifies the special case of rk3588 which has a minimum of 4
resets.

Do I need to add
resets:
minItems: 3
reset-names:
minItems: 3
in the "else:" ?

So in that case, I can remove "properties: resets: minItems: 3" above ?

Also, what do you mean "If the clocks are not valid" ?

Detlev.

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 488 bytes --]