Re: [PATCH 3/3] dt-bindings: display: vop2: Add VP clock resets

Conor Dooley
2024-05-21T18:31:57Z

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

On Tue, May 21, 2024 at 01:15:46PM -0400, Detlev Casanova wrote:
> On Wednesday, May 15, 2024 12:33:22 P.M. EDT Heiko Stübner wrote:
> > Am Mittwoch, 15. Mai 2024, 18:19:29 CEST schrieb Conor Dooley:
> > > On Tue, May 14, 2024 at 11:19:47AM -0400, Detlev Casanova wrote:
> > > > Add the documentation for VOP2 video ports reset clocks.
> > > > One reset can be set per video port.
> > > >
> > > > Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> > >
> > > Are these resets valid for all VOPs or just the one on 3588?
> >
> > Not in that form.
> > I.e. rk3588 has 4 video-ports (0-3), while rk3568 has 3 (0-2).
> >
> > So the binding should take into account that rk3568 also has the
> > SRST_VOP0 ... SRST_VOP2.
>
> That is what is set in the example and the reason why I set minItems to 3 in
> the main bindings.
> Then, the rk3588 specific part sets it to 4.
>
> Isn't that enough ?

Not quite - you need to restrict maxItems to 3 for the other devices if
the clocks are not valid. What you've got says that 4 clocks are
possible but not needed on !rk3588.

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]