From: Alina Yu <alina_yu@richtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<cy_huang@richtek.com>
Subject: Re: [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property
Date: Wed, 22 May 2024 17:45:24 +0800 [thread overview]
Message-ID: <20240522094524.GA21859@linuxcarl2.richtek.com> (raw)
In-Reply-To: <b094ce68-9ce2-411d-99f2-1f143e4c3347@linaro.org>
On Wed, May 22, 2024 at 11:27:06AM +0200, Krzysztof Kozlowski wrote:
> On 22/05/2024 11:03, Alina Yu wrote:
> > On Thu, May 16, 2024 at 02:34:02PM +0200, Krzysztof Kozlowski wrote:
> >> On 16/05/2024 11:20, Alina Yu wrote:
> >>> As the fixed voltage for the LDO is outside the range of the adjustable voltage mode,
> >>> the constraints for this scenario are not suitable to represent both modes.
> >>> Therefore, A property is added to specify the fixed LDO VOUT.
> >>>
> >>> Examples of fixed LDO VOUT and adjustable LDO VOUT is also added to this version.
> >>>
> >>> Signed-off-by: Alina Yu <alina_yu@richtek.com>
> >>> ---
> >>
> >> This is a v1 but I am pretty sure I saw it somewhere and there was
> >> already some sort of discussion. Confused... :(
> >>
> >> Best regards,
> >> Krzysztof
> >>
> >
> > The discussion regarding this matter took place during v2 and v3.
>
> So in the future?
Based on the previous discussion, it is scheduled to be included in the linux-next tree.
Will we start a further discussions on this topic?
>
> > Due to the fixed LDO VOUT being outside the range of the adjustable one,
> > a special-use property has been added to avoid overusing the constraints.
>
> Hm, why exactly this is not a bool property? What are the benefits?
>
> Best regards,
> Krzysztof
>
As only the user will know the exact fixed voltage,
the property is defined as a u32 to allow user customization and decision-making.
Thanks,
Alina
next prev parent reply other threads:[~2024-05-22 9:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 9:20 [PATCH 0/2] Add specified fixed LDO VOUT propery Alina Yu
2024-05-16 9:20 ` [PATCH 1/2] regulator: rtq2208: Add fixed LDO VOUT property and check that matches the constraints Alina Yu
2024-05-27 13:00 ` Mark Brown
2024-05-28 6:07 ` Alina Yu
2024-05-29 6:41 ` Alina Yu
2024-05-16 9:20 ` [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property Alina Yu
2024-05-16 12:34 ` Krzysztof Kozlowski
2024-05-22 9:03 ` Alina Yu
2024-05-22 9:27 ` Krzysztof Kozlowski
2024-05-22 9:45 ` Alina Yu [this message]
2024-05-22 11:35 ` Mark Brown
2024-05-22 13:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240522094524.GA21859@linuxcarl2.richtek.com \
--to=alina_yu@richtek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).