Re: [PATCH 1/2] dt-bindings: arm: fsl: rename gw7905 to gw75xx

Conor Dooley
2024-05-23T14:47:49Z

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

On Thu, May 23, 2024 at 09:02:46AM +0200, Krzysztof Kozlowski wrote:
> On 22/05/2024 23:50, Tim Harvey wrote:
> > The GW7905 was renamed to GW7500 before production release.
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> > Documentation/devicetree/bindings/arm/fsl.yaml | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index 0027201e19f8..d8bc295079e3 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -920,8 +920,8 @@ properties:
> > - fsl,imx8mm-ddr4-evk # i.MX8MM DDR4 EVK Board
> > - fsl,imx8mm-evk # i.MX8MM EVK Board
> > - fsl,imx8mm-evkb # i.MX8MM EVKB Board
> > + - gateworks,imx8mm-gw75xx-0x # i.MX8MM Gateworks Board
>
> That's not even equivalent. You 7500 != 75xx.
>

> > - gateworks,imx8mm-gw7904
> > - - gateworks,imx8mm-gw7905-0x # i.MX8MM Gateworks Board
>
> Compatibles do not change. It's just a string. Fixed string.

I think there's justification here for removing it, per the commit
message, the rename happened before the device was available to
customers.
Additionally, I think we can give people that upstream things before they're
publicly available a bit of slack, otherwise we're just discouraging
people from upstreaming early.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]