From: Wesley Cheng <quic_wcheng@quicinc.com>
To: <srinivas.kandagatla@linaro.org>, <mathias.nyman@intel.com>,
<perex@perex.cz>, <conor+dt@kernel.org>, <corbet@lwn.net>,
<lgirdwood@gmail.com>, <tiwai@suse.com>, <krzk+dt@kernel.org>,
<Thinh.Nguyen@synopsys.com>, <broonie@kernel.org>,
<bgoswami@quicinc.com>, <robh@kernel.org>,
<gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-sound@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<alsa-devel@alsa-project.org>,
Wesley Cheng <quic_wcheng@quicinc.com>
Subject: [PATCH v22 06/38] usb: host: xhci-mem: Allow for interrupter clients to choose specific index
Date: Thu, 23 May 2024 17:10:11 -0700 [thread overview]
Message-ID: <20240524001043.10141-7-quic_wcheng@quicinc.com> (raw)
In-Reply-To: <20240524001043.10141-1-quic_wcheng@quicinc.com>
Some clients may operate only on a specific XHCI interrupter instance.
Allow for the associated class driver to request for the interrupter that
it requires.
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
---
drivers/usb/host/xhci-mem.c | 29 ++++++++++++++++-------------
drivers/usb/host/xhci-sideband.c | 4 ++--
drivers/usb/host/xhci.h | 2 +-
include/linux/usb/xhci-sideband.h | 2 +-
4 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 60dfc59260d8..997e8f27acb8 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -2340,7 +2340,7 @@ xhci_add_interrupter(struct xhci_hcd *xhci, struct xhci_interrupter *ir,
struct xhci_interrupter *
xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
- u32 imod_interval)
+ u32 imod_interval, int intr_num)
{
struct xhci_hcd *xhci = hcd_to_xhci(hcd);
struct xhci_interrupter *ir;
@@ -2355,29 +2355,32 @@ xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
return NULL;
spin_lock_irq(&xhci->lock);
-
/* Find available secondary interrupter, interrupter 0 is reserved for primary */
for (i = 1; i < xhci->max_interrupters; i++) {
- if (xhci->interrupters[i] == NULL) {
- err = xhci_add_interrupter(xhci, ir, i);
- break;
+ if ((intr_num > 0 && i == intr_num) || intr_num <= 0) {
+ if (xhci->interrupters[i] == NULL) {
+ err = xhci_add_interrupter(xhci, ir, i);
+ if (err) {
+ spin_unlock_irq(&xhci->lock);
+ goto free_ir;
+ }
+ break;
+ }
}
}
-
spin_unlock_irq(&xhci->lock);
- if (err) {
- xhci_warn(xhci, "Failed to add secondary interrupter, max interrupters %d\n",
- xhci->max_interrupters);
- xhci_free_interrupter(xhci, ir);
- return NULL;
- }
-
xhci_set_interrupter_moderation(ir, imod_interval);
+
xhci_dbg(xhci, "Add secondary interrupter %d, max interrupters %d\n",
i, xhci->max_interrupters);
return ir;
+
+free_ir:
+ xhci_free_interrupter(xhci, ir);
+
+ return NULL;
}
EXPORT_SYMBOL_GPL(xhci_create_secondary_interrupter);
diff --git a/drivers/usb/host/xhci-sideband.c b/drivers/usb/host/xhci-sideband.c
index 7e7b15ec0cc7..690a08c8ed7f 100644
--- a/drivers/usb/host/xhci-sideband.c
+++ b/drivers/usb/host/xhci-sideband.c
@@ -254,7 +254,7 @@ EXPORT_SYMBOL_GPL(xhci_sideband_get_event_buffer);
*/
int
xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
- bool ip_autoclear, u32 imod_interval)
+ bool ip_autoclear, u32 imod_interval, int intr_num)
{
int ret = 0;
@@ -268,7 +268,7 @@ xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
}
sb->ir = xhci_create_secondary_interrupter(xhci_to_hcd(sb->xhci),
- num_seg, imod_interval);
+ num_seg, imod_interval, intr_num);
if (!sb->ir) {
ret = -ENOMEM;
goto out;
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 35e5079ce621..bf50b56fef14 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1833,7 +1833,7 @@ void xhci_free_container_ctx(struct xhci_hcd *xhci,
struct xhci_container_ctx *ctx);
struct xhci_interrupter *
xhci_create_secondary_interrupter(struct usb_hcd *hcd, unsigned int segs,
- u32 imod_interval);
+ u32 imod_interval, int intr_num);
void xhci_remove_secondary_interrupter(struct usb_hcd
*hcd, struct xhci_interrupter *ir);
void xhci_skip_sec_intr_events(struct xhci_hcd *xhci,
diff --git a/include/linux/usb/xhci-sideband.h b/include/linux/usb/xhci-sideband.h
index 5fc95dd499aa..1231821b2947 100644
--- a/include/linux/usb/xhci-sideband.h
+++ b/include/linux/usb/xhci-sideband.h
@@ -56,7 +56,7 @@ xhci_sideband_get_event_buffer(struct xhci_sideband *sb);
int
xhci_sideband_create_interrupter(struct xhci_sideband *sb, int num_seg,
- bool ip_autoclear, u32 imod_interval);
+ bool ip_autoclear, u32 imod_interval, int intr_num);
void
xhci_sideband_remove_interrupter(struct xhci_sideband *sb);
next prev parent reply other threads:[~2024-05-24 0:11 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 0:10 [PATCH v22 00/38] Introduce QC USB SND audio offloading support Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 01/38] xhci: add helper to stop endpoint and wait for completion Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 02/38] usb: host: xhci: Repurpose event handler for skipping interrupter events Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 03/38] xhci: sideband: add initial api to register a sideband entity Wesley Cheng
2024-06-04 23:13 ` Jeff Johnson
2024-06-10 23:36 ` Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 04/38] usb: xhci: Allow for secondary interrupter to set IMOD Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 05/38] usb: host: xhci-mem: Cleanup pending secondary event ring events Wesley Cheng
2024-05-24 0:10 ` Wesley Cheng [this message]
2024-05-24 0:10 ` [PATCH v22 07/38] ASoC: Add SOC USB APIs for adding an USB backend Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 08/38] ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 09/38] ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 10/38] ASoC: qdsp6: q6afe: Increase APR timeout Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 11/38] ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6 Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 12/38] ALSA: usb-audio: Introduce USB SND platform op callbacks Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 13/38] ALSA: usb-audio: Export USB SND APIs for modules Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 14/38] ALSA: usb-audio: Save UAC sample size information Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 15/38] usb: dwc3: Specify maximum number of XHCI interrupters Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 16/38] usb: host: xhci-plat: Set XHCI max interrupters if property is present Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 17/38] ALSA: usb-audio: qcom: Add USB QMI definitions Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 18/38] ALSA: usb-audio: qcom: Introduce QC USB SND offloading support Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 19/38] ALSA: usb-audio: Check for support for requested audio format Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 20/38] ASoC: usb: Add PCM format check API for USB backend Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 21/38] ASoC: qcom: qdsp6: Ensure PCM format is supported by USB audio device Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 22/38] ALSA: usb-audio: Prevent starting of audio stream if in use Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 23/38] ALSA: usb-audio: Do not allow USB offload path if PCM device is " Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 24/38] ASoC: dt-bindings: Update example for enabling USB offload on SM8250 Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 25/38] ALSA: usb-audio: qcom: Populate PCM and USB chip information Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 26/38] ASoC: qcom: qdsp6: Add support to track available USB PCM devices Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 27/38] ASoC: Introduce SND kcontrols to select sound card and PCM device Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 28/38] ASoC: qcom: qdsp6: Add SOC USB offload select get/put callbacks Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 29/38] ASoC: Introduce SND kcontrols to track USB offloading state Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 30/38] ASoC: qcom: qdsp6: Add PCM ops to track current state Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 31/38] ASoC: usb: Create SOC USB SND jack kcontrol Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 32/38] ASoC: qcom: qdsp6: Add headphone jack for offload connection status Wesley Cheng
2024-06-04 23:07 ` Jeff Johnson
2024-05-24 0:10 ` [PATCH v22 33/38] ASoC: usb: Fetch ASoC sound card information Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 34/38] ALSA: usb-audio: Add USB offloading capable kcontrol Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 35/38] ALSA: usb-audio: Allow for rediscovery of connected USB SND devices Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 36/38] ALSA: usb-audio: qcom: Use card and PCM index from QMI request Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 37/38] ASoC: usb: Rediscover USB SND devices on USB port add Wesley Cheng
2024-05-24 0:10 ` [PATCH v22 38/38] ASoC: doc: Add documentation for SOC USB Wesley Cheng
2024-06-03 23:15 ` [PATCH v22 00/38] Introduce QC USB SND audio offloading support Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240524001043.10141-7-quic_wcheng@quicinc.com \
--to=quic_wcheng@quicinc.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).