From: Conor Dooley <conor@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Henry Bell <dmoo_dv@protonmail.com>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
Albert Ou <aou@eecs.berkeley.edu>,
Conor Dooley <conor+dt@kernel.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Rob Herring <robh@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: RISC-V: add Star64 board devicetree
Date: Sat, 25 May 2024 13:25:45 +0100 [thread overview]
Message-ID: <20240525-shirt-scratch-6708b2a4f63b@spud> (raw)
In-Reply-To: <b52685a3-127a-4367-b11a-54ab88467dcf@web.de>
[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]
On Sat, May 25, 2024 at 02:11:05PM +0200, Markus Elfring wrote:
> >>> Would you like to add an imperative wording for an improved change description?
> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n94
> …
> >> I'm happy to change it, but was going off the format used in Conor's Milkv Mars commit
> >> https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/commit/?id=04a228aadb84d894721b13197649ca741f3018bc
> >
> > Don't worry about Markus, most maintainers (myself included) ignore his
> > comments on patches. The commit message here is fine.
>
> Would such a response mean also that you are occasionally ignoring requirements
> from a referenced Linux development guideline?
I do ignore it from time to time, yes. Being a stickler to the
guidelines wastes everybody's time (just like this discussion).
That said, the tense used in this patch is perfectly in-line with the
guideline you reference. "Add Star64 board devicetree" is in the
imperative and the commit message body contains additional information
about the board's configuration.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-25 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 19:06 [PATCH] RISC-V: add Star64 board devicetree H Bell
2024-05-23 20:27 ` Krzysztof Kozlowski
2024-05-25 9:37 ` Markus Elfring
2024-05-25 10:12 ` Henry Bell
2024-05-25 10:19 ` Conor Dooley
2024-05-25 12:11 ` Markus Elfring
2024-05-25 12:25 ` Conor Dooley [this message]
2024-05-25 12:41 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240525-shirt-scratch-6708b2a4f63b@spud \
--to=conor@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmoo_dv@protonmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox