From: Sebastian Kropatsch <seb-dev@web.de>
To: Heiko Stuebner <heiko@sntech.de>, linux-rockchip@lists.infradead.org
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sebastian Kropatsch <seb-dev@web.de>
Subject: [PATCH 0/2] RK3588: FriendlyElec CM3588 NAS board support
Date: Sun, 26 May 2024 23:42:15 +0200 [thread overview]
Message-ID: <20240526214340.8459-1-seb-dev@web.de> (raw)
Hello!
This adds support for the FriendlyElec CM3588 NAS board.
The board's device tree makes use of the latest upstream advances on the
RK3588 like USB3 DRD and GPU support as well as the latest Rockchip PCIe
driver bifurcation fixes, but some features such as thermal management
and HDMI will have to be added later when SoC support for these features
is merged.
Since the hardware has similarities with FriendlyElec's NanoPC T6, the
device tree for the CM3588 NAS also partially shares some sections with
the NanoPC T6 tree.
Minor issue:
The device enumeration of NVMe SSDs plugged into the four PCIe M.2 slots
does not follow the order of the slots on the board: The slots are
physically named from 1 to 4, top to bottom. However, they do not show
up in this same order in Linux when all slots are polulated:
- SSD in physical slot 1 shows up as nvme0
- SSD in physical slot 2 shows up as nvme2
- SSD in physical slot 3 shows up as nvme1
- SSD in physical slot 4 shows up as nvme3
This is the same order in which the data lanes are mapped for PCIe
bifurcation (dts property: data-lanes = <1 3 2 4>).
I could not solve this by using aliases for the PCIe nodes in the device
tree. Perhaps this is something that can only be solved at driver level?
I am not sure if this behaviour is even considered a bug or if this is
intended behaviour by design.
Devicetree validation:
`make CHECK_DTBS=y rockchip/rk3588-cm3588-nas.dtb` does not give any
warnings or errors, tested on Linux next-20240523.
Best regards,
Sebastian Kropatsch
---
Sebastian Kropatsch (2):
dt-bindings: arm: rockchip: Add CM3588 NAS
arm64: dts: rockchip: Add CM3588 NAS board
.../devicetree/bindings/arm/rockchip.yaml | 5 +
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../boot/dts/rockchip/rk3588-cm3588-nas.dts | 1269 +++++++++++++++++
3 files changed, 1275 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-cm3588-nas.dts
--
2.43.0
next reply other threads:[~2024-05-26 23:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-26 21:42 Sebastian Kropatsch [this message]
2024-05-26 21:46 ` [PATCH 1/2] dt-bindings: arm: rockchip: Add CM3588 NAS Sebastian Kropatsch
2024-05-27 6:10 ` Krzysztof Kozlowski
2024-05-26 21:48 ` [PATCH 2/2] arm64: dts: rockchip: Add CM3588 NAS board Sebastian Kropatsch
2024-05-27 19:02 ` Jonas Karlman
2024-05-27 20:54 ` Heiko Stübner
2024-05-28 15:55 ` Sebastian Kropatsch
2024-05-29 7:57 ` Heiko Stübner
2024-05-29 15:53 ` Sebastian Kropatsch
2024-05-28 17:22 ` Sebastian Kropatsch
2024-05-29 0:10 ` Dragan Simic
2024-05-29 17:20 ` Sebastian Kropatsch
-- strict thread matches above, loose matches on Subject: below --
2024-06-16 21:48 [PATCH 0/2] RK3588: FriendlyElec CM3588 NAS board support Sebastian Kropatsch
2024-06-16 22:15 ` Sebastian Kropatsch
2024-06-20 20:39 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240526214340.8459-1-seb-dev@web.de \
--to=seb-dev@web.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).