Re: [PATCH] dt-bindings: media: renesas,isp: Add binding for V4M

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

On Mon, May 27, 2024 at 07:54:02PM +0200, Niklas Söderlund wrote:
> Hi Conor,
> 
> Thanks for your feedback.
> 
> On 2024-05-27 17:36:23 +0100, Conor Dooley wrote:
> > On Mon, May 27, 2024 at 03:19:45PM +0200, Niklas Söderlund wrote:
> > > Document support for the ISP module in the Renesas V4M (r8a779h0) SoC.
> > > 
> > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > 
> > Should be with:
> > https://lore.kernel.org/all/20240527132513.1684232-1-niklas.soderlund+renesas@ragnatech.se/
> 
> I posted the bindings separate from the driver with the intention that 
> once they are accepted I can upstream the driver and the DT for the 
> device using it in parallel. The V4L2 subsystem is at times overloaded 
> and in the past waiting for both driver and binding to be accepted as a 
> whole unit have delayed entablement of SoC features unneeded for one or 
> more releases.

I don't really understand this argument at all. If you land the binding
but not the driver changes, you're still waiting for the driver to get
the feature functional. My understanding is that Geert takes dts patches
when bindings are applied by the subsystems, rather than wait until they
circle back to his tree a release later - so that isn't the issue either.

All it seems like you're doing to me is making my "job" reviewing
bindings harder, because I have to search on lore for your driver
patches.

> > No mention of why this can't just fall back to an existing device here
> > or in the driver. Why not?
> 
> For better or worse that is how all Renesas devices are handled, one new 
> device compatible for each device. This have worked well as each device 
> usually have a quirk or extra future that is enabled later.

If you're worried about the media subsystem being too busy to pick up
patches with driver support, you know what's a way you can have the
driver functional without a code change?

/spoiler You guessed it, fallback compatibles!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]