Re: [PATCH] dt-bindings: hwmon: Add max6639

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1314 bytes --]

On Tue, May 28, 2024 at 07:41:58AM -0700, Guenter Roeck wrote:
> On 5/28/24 07:26, Conor Dooley wrote:
> > On Tue, May 28, 2024 at 06:21:21PM +0530, Naresh Solanki wrote:
> > > Add Devicetree binding documentation for Maxim MAX6639 temperature
> > > monitor with PWM fan-speed controller.
> > 
> > Other than unneeded |s where your descriptions don't have any
> > formatting, this patch looks fine. That said - where's your dts or your
> > driver? A binding on its own is unusual.
> > 
> 
> The driver is drivers/hwmon/max6639.c which needs other unrelated changes/
> cleanups. Holding those up until the bindings are accepted would not make
> sense, so my guess is that Naresh decided to pursue the other changes for now
> and add devicetree support to the driver after the devicetree properties
> have been approved. On the other side, adding devicetree support does depend
> on the other changes, so trying to do that before the other changes are
> complete would be difficult.
> 
> That is just my guess, though, and I am ok with it.

Well, I think the binding is fine, so it is up to you whether you want
to merge the binding without having the driver implementation nailed
down.

Ideally with the |s removed,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]