devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,  Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	 Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	 Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
	 Rocky Liao <quic_rjliao@quicinc.com>,
	Kalle Valo <kvalo@kernel.org>,
	 Jeff Johnson <jjohnson@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>,
	 Bartosz Golaszewski <brgl@bgdev.pl>,
	Bjorn Helgaas <bhelgaas@google.com>,
	 Srini Kandagatla <srinivas.kandagatla@linaro.org>,
	 Elliot Berman <quic_eberman@quicinc.com>,
	 Caleb Connolly <caleb.connolly@linaro.org>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	 Alex Elder <elder@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	 netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	 ath11k@lists.infradead.org,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	 ath12k@lists.infradead.org, linux-pm@vger.kernel.org,
	 linux-pci@vger.kernel.org,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	kernel@quicinc.com,  Amit Pundir <amit.pundir@linaro.org>
Subject: [PATCH v8 13/17] PCI/pwrctl: reuse the OF node for power controlled devices
Date: Tue, 28 May 2024 21:03:21 +0200	[thread overview]
Message-ID: <20240528-pwrseq-v8-13-d354d52b763c@linaro.org> (raw)
In-Reply-To: <20240528-pwrseq-v8-0-d354d52b763c@linaro.org>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

With PCI power control we deal with two struct device objects bound to
two different drivers but consuming the same OF node. We must not bind
the pinctrl twice. To that end: before setting the OF node of the newly
instantiated PCI device, check if a platform device consuming the same
OF node doesn't already exist on the platform bus and - if so - mark the
PCI device as reusing the OF node.

Tested-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/pci/of.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 51e3dd0ea5ab..b908fe1ae951 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -6,6 +6,7 @@
  */
 #define pr_fmt(fmt)	"PCI: OF: " fmt
 
+#include <linux/cleanup.h>
 #include <linux/irqdomain.h>
 #include <linux/kernel.h>
 #include <linux/pci.h>
@@ -13,6 +14,7 @@
 #include <linux/of_irq.h>
 #include <linux/of_address.h>
 #include <linux/of_pci.h>
+#include <linux/platform_device.h>
 #include "pci.h"
 
 #ifdef CONFIG_PCI
@@ -25,16 +27,20 @@
  */
 int pci_set_of_node(struct pci_dev *dev)
 {
-	struct device_node *node;
-
 	if (!dev->bus->dev.of_node)
 		return 0;
 
-	node = of_pci_find_child_device(dev->bus->dev.of_node, dev->devfn);
+	struct device_node *node __free(device_node) =
+		of_pci_find_child_device(dev->bus->dev.of_node, dev->devfn);
 	if (!node)
 		return 0;
 
-	device_set_node(&dev->dev, of_fwnode_handle(node));
+	struct device *pdev __free(put_device) =
+		bus_find_device_by_of_node(&platform_bus_type, node);
+	if (pdev)
+		dev->bus->dev.of_node_reused = true;
+
+	device_set_node(&dev->dev, of_fwnode_handle(no_free_ptr(node)));
 	return 0;
 }
 

-- 
2.43.0


  parent reply	other threads:[~2024-05-28 19:04 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 19:03 [PATCH v8 00/17] power: sequencing: implement the subsystem and add first users Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 01/17] regulator: dt-bindings: describe the PMU module of the QCA6390 package Bartosz Golaszewski
2024-06-04 17:30   ` Bjorn Helgaas
2024-06-05  9:13     ` Bartosz Golaszewski
2024-06-05 11:12       ` Mark Brown
2024-05-28 19:03 ` [PATCH v8 02/17] regulator: dt-bindings: describe the PMU module of the WCN7850 package Bartosz Golaszewski
2024-06-04 17:31   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 03/17] dt-bindings: net: bluetooth: qualcomm: describe regulators for QCA6390 Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 04/17] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390 Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 05/17] dt-bindings: net: wireless: describe the ath12k PCI module Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 06/17] arm64: dts: qcom: sm8550-qrd: add the Wifi node Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 07/17] arm64: dts: qcom: sm8650-qrd: " Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 08/17] arm64: dts: qcom: sm8650-hdk: " Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 09/17] arm64: dts: qcom: qrb5165-rb5: " Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 10/17] power: sequencing: implement the pwrseq core Bartosz Golaszewski
2024-06-04 17:43   ` Bjorn Helgaas
2024-06-04 18:27     ` Bartosz Golaszewski
2024-06-05  6:52   ` Ratheesh Kannoth
2024-06-05  7:43     ` Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 11/17] power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets Bartosz Golaszewski
2024-06-04 17:52   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 12/17] PCI: hold the rescan mutex when scanning for the first time Bartosz Golaszewski
2024-06-11 22:55   ` Bjorn Helgaas
2024-05-28 19:03 ` Bartosz Golaszewski [this message]
2024-06-11 22:56   ` [PATCH v8 13/17] PCI/pwrctl: reuse the OF node for power controlled devices Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 14/17] PCI/pwrctl: create platform devices for child OF nodes of the port node Bartosz Golaszewski
2024-06-11 22:56   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 15/17] PCI/pwrctl: add PCI power control core code Bartosz Golaszewski
2024-06-05 17:57   ` Bjorn Helgaas
2024-06-05 18:05     ` Bartosz Golaszewski
2024-06-11 22:56       ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 16/17] PCI/pwrctl: add a PCI power control driver for power sequenced devices Bartosz Golaszewski
2024-06-04 23:23   ` Bjorn Helgaas
2024-06-04 23:34     ` Dmitry Baryshkov
2024-06-05  2:13       ` Bjorn Helgaas
2024-06-05  8:47         ` Bartosz Golaszewski
2024-06-05 17:47           ` Bjorn Helgaas
2024-06-05 18:04             ` Bartosz Golaszewski
2024-06-11 22:56   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 17/17] Bluetooth: qca: use the power sequencer for QCA6390 Bartosz Golaszewski
2024-05-30 11:02 ` [PATCH v8 00/17] power: sequencing: implement the subsystem and add first users Neil Armstrong
2024-05-30 15:22 ` Caleb Connolly
2024-06-04 17:19 ` Bjorn Helgaas
2024-06-04 18:24   ` Bartosz Golaszewski
2024-06-05 17:56     ` Bjorn Helgaas
2024-06-11 22:54 ` Bjorn Helgaas
2024-06-12  7:10   ` Bartosz Golaszewski
2024-06-20 14:30 ` patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528-pwrseq-v8-13-d354d52b763c@linaro.org \
    --to=brgl@bgdev.pl \
    --cc=amit.pundir@linaro.org \
    --cc=andersson@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=caleb.connolly@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=edumazet@google.com \
    --cc=elder@kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=kernel@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_bgodavar@quicinc.com \
    --cc=quic_eberman@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=quic_rjliao@quicinc.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).