devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,  Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Marcel Holtmann <marcel@holtmann.org>,
	 Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	 Balakrishna Godavarthi <quic_bgodavar@quicinc.com>,
	 Rocky Liao <quic_rjliao@quicinc.com>,
	Kalle Valo <kvalo@kernel.org>,
	 Jeff Johnson <jjohnson@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konrad.dybcio@linaro.org>,
	 Bartosz Golaszewski <brgl@bgdev.pl>,
	Bjorn Helgaas <bhelgaas@google.com>,
	 Srini Kandagatla <srinivas.kandagatla@linaro.org>,
	 Elliot Berman <quic_eberman@quicinc.com>,
	 Caleb Connolly <caleb.connolly@linaro.org>,
	 Neil Armstrong <neil.armstrong@linaro.org>,
	 Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	 Alex Elder <elder@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	 netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	 ath11k@lists.infradead.org,
	Jeff Johnson <quic_jjohnson@quicinc.com>,
	 ath12k@lists.infradead.org, linux-pm@vger.kernel.org,
	 linux-pci@vger.kernel.org,
	 Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	kernel@quicinc.com,  Amit Pundir <amit.pundir@linaro.org>
Subject: [PATCH v8 17/17] Bluetooth: qca: use the power sequencer for QCA6390
Date: Tue, 28 May 2024 21:03:25 +0200	[thread overview]
Message-ID: <20240528-pwrseq-v8-17-d354d52b763c@linaro.org> (raw)
In-Reply-To: <20240528-pwrseq-v8-0-d354d52b763c@linaro.org>

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Use the pwrseq subsystem's consumer API to run the power-up sequence for
the Bluetooth module of the QCA6390 package.

Tested-by: Amit Pundir <amit.pundir@linaro.org>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/bluetooth/hci_qca.c | 74 ++++++++++++++++++++++++++++++++++++---------
 1 file changed, 59 insertions(+), 15 deletions(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 384a2bbbf303..de4f88d835cb 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -28,6 +28,7 @@
 #include <linux/of.h>
 #include <linux/acpi.h>
 #include <linux/platform_device.h>
+#include <linux/pwrseq/consumer.h>
 #include <linux/regulator/consumer.h>
 #include <linux/serdev.h>
 #include <linux/mutex.h>
@@ -214,6 +215,7 @@ struct qca_power {
 	struct regulator_bulk_data *vreg_bulk;
 	int num_vregs;
 	bool vregs_on;
+	struct pwrseq_desc *pwrseq;
 };
 
 struct qca_serdev {
@@ -1684,6 +1686,27 @@ static bool qca_wakeup(struct hci_dev *hdev)
 	return wakeup;
 }
 
+static int qca_port_reopen(struct hci_uart *hu)
+{
+	int ret;
+
+	/* Now the device is in ready state to communicate with host.
+	 * To sync host with device we need to reopen port.
+	 * Without this, we will have RTS and CTS synchronization
+	 * issues.
+	 */
+	serdev_device_close(hu->serdev);
+	ret = serdev_device_open(hu->serdev);
+	if (ret) {
+		bt_dev_err(hu->hdev, "failed to open port");
+		return ret;
+	}
+
+	hci_uart_set_flow_control(hu, false);
+
+	return 0;
+}
+
 static int qca_regulator_init(struct hci_uart *hu)
 {
 	enum qca_btsoc_type soc_type = qca_soc_type(hu);
@@ -1752,21 +1775,7 @@ static int qca_regulator_init(struct hci_uart *hu)
 		break;
 	}
 
-	/* Now the device is in ready state to communicate with host.
-	 * To sync host with device we need to reopen port.
-	 * Without this, we will have RTS and CTS synchronization
-	 * issues.
-	 */
-	serdev_device_close(hu->serdev);
-	ret = serdev_device_open(hu->serdev);
-	if (ret) {
-		bt_dev_err(hu->hdev, "failed to open port");
-		return ret;
-	}
-
-	hci_uart_set_flow_control(hu, false);
-
-	return 0;
+	return qca_port_reopen(hu);
 }
 
 static int qca_power_on(struct hci_dev *hdev)
@@ -1794,6 +1803,17 @@ static int qca_power_on(struct hci_dev *hdev)
 		ret = qca_regulator_init(hu);
 		break;
 
+	case QCA_QCA6390:
+		qcadev = serdev_device_get_drvdata(hu->serdev);
+		ret = pwrseq_power_on(qcadev->bt_power->pwrseq);
+		if (ret)
+			return ret;
+
+		ret = qca_port_reopen(hu);
+		if (ret)
+			return ret;
+		break;
+
 	default:
 		qcadev = serdev_device_get_drvdata(hu->serdev);
 		if (qcadev->bt_en) {
@@ -2168,6 +2188,10 @@ static void qca_power_shutdown(struct hci_uart *hu)
 		}
 		break;
 
+	case QCA_QCA6390:
+		pwrseq_power_off(qcadev->bt_power->pwrseq);
+		break;
+
 	default:
 		gpiod_set_value_cansleep(qcadev->bt_en, 0);
 	}
@@ -2309,12 +2333,25 @@ static int qca_serdev_probe(struct serdev_device *serdev)
 	case QCA_WCN6750:
 	case QCA_WCN6855:
 	case QCA_WCN7850:
+	case QCA_QCA6390:
 		qcadev->bt_power = devm_kzalloc(&serdev->dev,
 						sizeof(struct qca_power),
 						GFP_KERNEL);
 		if (!qcadev->bt_power)
 			return -ENOMEM;
+		break;
+	default:
+		break;
+	}
 
+	switch (qcadev->btsoc_type) {
+	case QCA_WCN3988:
+	case QCA_WCN3990:
+	case QCA_WCN3991:
+	case QCA_WCN3998:
+	case QCA_WCN6750:
+	case QCA_WCN6855:
+	case QCA_WCN7850:
 		qcadev->bt_power->dev = &serdev->dev;
 		err = qca_init_regulators(qcadev->bt_power, data->vregs,
 					  data->num_vregs);
@@ -2360,6 +2397,13 @@ static int qca_serdev_probe(struct serdev_device *serdev)
 		}
 		break;
 
+	case QCA_QCA6390:
+		qcadev->bt_power->pwrseq = devm_pwrseq_get(&serdev->dev,
+							   "bluetooth");
+		if (IS_ERR(qcadev->bt_power->pwrseq))
+			return PTR_ERR(qcadev->bt_power->pwrseq);
+		fallthrough;
+
 	default:
 		qcadev->bt_en = devm_gpiod_get_optional(&serdev->dev, "enable",
 					       GPIOD_OUT_LOW);

-- 
2.43.0


  parent reply	other threads:[~2024-05-28 19:04 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-28 19:03 [PATCH v8 00/17] power: sequencing: implement the subsystem and add first users Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 01/17] regulator: dt-bindings: describe the PMU module of the QCA6390 package Bartosz Golaszewski
2024-06-04 17:30   ` Bjorn Helgaas
2024-06-05  9:13     ` Bartosz Golaszewski
2024-06-05 11:12       ` Mark Brown
2024-05-28 19:03 ` [PATCH v8 02/17] regulator: dt-bindings: describe the PMU module of the WCN7850 package Bartosz Golaszewski
2024-06-04 17:31   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 03/17] dt-bindings: net: bluetooth: qualcomm: describe regulators for QCA6390 Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 04/17] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390 Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 05/17] dt-bindings: net: wireless: describe the ath12k PCI module Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 06/17] arm64: dts: qcom: sm8550-qrd: add the Wifi node Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 07/17] arm64: dts: qcom: sm8650-qrd: " Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 08/17] arm64: dts: qcom: sm8650-hdk: " Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 09/17] arm64: dts: qcom: qrb5165-rb5: " Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 10/17] power: sequencing: implement the pwrseq core Bartosz Golaszewski
2024-06-04 17:43   ` Bjorn Helgaas
2024-06-04 18:27     ` Bartosz Golaszewski
2024-06-05  6:52   ` Ratheesh Kannoth
2024-06-05  7:43     ` Bartosz Golaszewski
2024-05-28 19:03 ` [PATCH v8 11/17] power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets Bartosz Golaszewski
2024-06-04 17:52   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 12/17] PCI: hold the rescan mutex when scanning for the first time Bartosz Golaszewski
2024-06-11 22:55   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 13/17] PCI/pwrctl: reuse the OF node for power controlled devices Bartosz Golaszewski
2024-06-11 22:56   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 14/17] PCI/pwrctl: create platform devices for child OF nodes of the port node Bartosz Golaszewski
2024-06-11 22:56   ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 15/17] PCI/pwrctl: add PCI power control core code Bartosz Golaszewski
2024-06-05 17:57   ` Bjorn Helgaas
2024-06-05 18:05     ` Bartosz Golaszewski
2024-06-11 22:56       ` Bjorn Helgaas
2024-05-28 19:03 ` [PATCH v8 16/17] PCI/pwrctl: add a PCI power control driver for power sequenced devices Bartosz Golaszewski
2024-06-04 23:23   ` Bjorn Helgaas
2024-06-04 23:34     ` Dmitry Baryshkov
2024-06-05  2:13       ` Bjorn Helgaas
2024-06-05  8:47         ` Bartosz Golaszewski
2024-06-05 17:47           ` Bjorn Helgaas
2024-06-05 18:04             ` Bartosz Golaszewski
2024-06-11 22:56   ` Bjorn Helgaas
2024-05-28 19:03 ` Bartosz Golaszewski [this message]
2024-05-30 11:02 ` [PATCH v8 00/17] power: sequencing: implement the subsystem and add first users Neil Armstrong
2024-05-30 15:22 ` Caleb Connolly
2024-06-04 17:19 ` Bjorn Helgaas
2024-06-04 18:24   ` Bartosz Golaszewski
2024-06-05 17:56     ` Bjorn Helgaas
2024-06-11 22:54 ` Bjorn Helgaas
2024-06-12  7:10   ` Bartosz Golaszewski
2024-06-20 14:30 ` patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240528-pwrseq-v8-17-d354d52b763c@linaro.org \
    --to=brgl@bgdev.pl \
    --cc=amit.pundir@linaro.org \
    --cc=andersson@kernel.org \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=caleb.connolly@linaro.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=edumazet@google.com \
    --cc=elder@kernel.org \
    --cc=jjohnson@kernel.org \
    --cc=kernel@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=neil.armstrong@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_bgodavar@quicinc.com \
    --cc=quic_eberman@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=quic_rjliao@quicinc.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).