[PATCH 00/10] dt-bindings: clock: qcom,gcc: handle the controllers without power domains

[PATCH 00/10] dt-bindings: clock: qcom,gcc: handle the controllers without power domains

[Dmitry Baryshkov]

On some of the Qualcomm platforms the Global Clock Controller doesn't
provide power domains to the platform. However the existing
qcom,gcc.yaml common schema requires the '#power-domain-cells' property.
This results either in a platforms having incorrect property or in DT
validation errors. Fix this by splitting the qcom,gcc-nopd.yaml schema,
which doesn't define the offensive property and use it for such
platforms.

Also, while we are at it, fix GCC node name for two platforms and
enforce node name in the DT schema.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
Dmitry Baryshkov (10):
      dt-bindings: clock: qcom: split the non-PD schema for GCC
      dt-bindings: clock: qcom,gcc-apq8064: use non-power-domain version of GCC schema
      dt-bindings: clock: qcom,gcc-msm8660: use non-power-domain version of GCC schema
      dt-bindings: clock: qcom,gcc-ipq6018: use non-power-domain version of GCC schema
      dt-bindings: clock: qcom,gcc-nopd.yaml: force node name
      ARM: dts: qcom: apq8064: drop #power-domain-cells property of GCC
      ARM: dts: qcom: msm8660: drop #power-domain-cells property of GCC
      ARM: dts: qcom: msm8960: drop #power-domain-cells property of GCC
      arm64: dts: qcom: ipq6018: fix GCC node name
      arm64: dts: qcom: ipq8074: fix GCC node name

 .../bindings/clock/qcom,gcc-apq8064.yaml           |  2 +-
 .../bindings/clock/qcom,gcc-ipq6018.yaml           |  2 +-
 .../bindings/clock/qcom,gcc-msm8660.yaml           |  2 +-
 .../devicetree/bindings/clock/qcom,gcc-nopd.yaml   | 43 ++++++++++++++++++++++
 .../devicetree/bindings/clock/qcom,gcc.yaml        | 19 ++--------
 arch/arm/boot/dts/qcom/qcom-apq8064.dtsi           |  1 -
 arch/arm/boot/dts/qcom/qcom-msm8660.dtsi           |  1 -
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi           |  1 -
 arch/arm64/boot/dts/qcom/ipq6018.dtsi              |  2 +-
 arch/arm64/boot/dts/qcom/ipq8074.dtsi              |  2 +-
 10 files changed, 51 insertions(+), 24 deletions(-)
---
base-commit: ee3122766a21b81f4014bf7888dee5b9c5af15fa
change-id: 20240528-qcom-gdscs-b5e6cafdab9d

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

[PATCH 01/10] dt-bindings: clock: qcom: split the non-PD schema for GCC

[Dmitry Baryshkov]

On some of Qualcomm platforms the Global Clock Controller (GCC) doesn't
provide power domains. Split no-PD version from the common qcom,gcc schema.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 .../devicetree/bindings/clock/qcom,gcc-nopd.yaml   | 38 ++++++++++++++++++++++
 .../devicetree/bindings/clock/qcom,gcc.yaml        | 19 ++---------
 2 files changed, 41 insertions(+), 16 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml
new file mode 100644
index 000000000000..a941e75a930a
--- /dev/null
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/clock/qcom,gcc-nopd.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Global Clock & Reset Controller Common Properties
+
+maintainers:
+  - Stephen Boyd <sboyd@kernel.org>
+  - Taniya Das <quic_tdas@quicinc.com>
+
+description: |
+  Common bindings for Qualcomm global clock control module providing the
+  clocks and resets.
+
+properties:
+  '#clock-cells':
+    const: 1
+
+  '#reset-cells':
+    const: 1
+
+  reg:
+    maxItems: 1
+
+  protected-clocks:
+    description:
+      Protected clock specifier list as per common clock binding.
+
+required:
+  - reg
+  - '#clock-cells'
+  - '#reset-cells'
+
+additionalProperties: true
+
+...
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
index 788825105f24..e7ec15b1780d 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
@@ -14,27 +14,14 @@ description: |
   Common bindings for Qualcomm global clock control module providing the
   clocks, resets and power domains.
 
-properties:
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
+allOf:
+  - $ref: qcom,gcc-nopd.yaml
 
+properties:
   '#power-domain-cells':
     const: 1
 
-  reg:
-    maxItems: 1
-
-  protected-clocks:
-    description:
-      Protected clock specifier list as per common clock binding.
-
 required:
-  - reg
-  - '#clock-cells'
-  - '#reset-cells'
   - '#power-domain-cells'
 
 additionalProperties: true

-- 
2.39.2

[PATCH 02/10] dt-bindings: clock: qcom,gcc-apq8064: use non-power-domain version of GCC schema

[Dmitry Baryshkov]

On APQ8064 and MSM8960 the GCC doesn't provide power domains. Switch it
to use new qcom,gcc-nopd.yaml schema.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
index 19211176ee0b..f06720fcb531 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml
@@ -19,7 +19,7 @@ description: |
     include/dt-bindings/reset/qcom,gcc-msm8960.h
 
 allOf:
-  - $ref: qcom,gcc.yaml#
+  - $ref: qcom,gcc-nopd.yaml#
 
 properties:
   compatible:

-- 
2.39.2

[PATCH 03/10] dt-bindings: clock: qcom,gcc-msm8660: use non-power-domain version of GCC schema

[Dmitry Baryshkov]

On MSM8660 the GCC doesn't provide power domains. Switch it to use new
qcom,gcc-nopd.yaml schema.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/clock/qcom,gcc-msm8660.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8660.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8660.yaml
index c9e985548621..d2dcfaf2e4cf 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-msm8660.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-msm8660.yaml
@@ -19,7 +19,7 @@ description: |
     include/dt-bindings/reset/qcom,gcc-msm8660.h
 
 allOf:
-  - $ref: qcom,gcc.yaml#
+  - $ref: qcom,gcc-nopd.yaml#
 
 properties:
   compatible:

-- 
2.39.2

[PATCH 04/10] dt-bindings: clock: qcom,gcc-ipq6018: use non-power-domain version of GCC schema

[Dmitry Baryshkov]

On IPQ6018 the GCC doesn't provide power domains. Switch it to use new
qcom,gcc-nopd.yaml schema.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml
index af5d883cfdc8..4e811698d30b 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml
@@ -20,7 +20,7 @@ description: |
     include/dt-bindings/reset/qcom,gcc-ipq6018.h
 
 allOf:
-  - $ref: qcom,gcc.yaml#
+  - $ref: qcom,gcc-nopd.yaml#
 
 properties:
   compatible:

-- 
2.39.2

[PATCH 05/10] dt-bindings: clock: qcom,gcc-nopd.yaml: force node name

[Dmitry Baryshkov]

Force GCC device nodes to have the name 'clock-controller'. Several
platforms used 'gcc' here.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml
index a941e75a930a..fa9a3d3a3c67 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-nopd.yaml
@@ -14,7 +14,12 @@ description: |
   Common bindings for Qualcomm global clock control module providing the
   clocks and resets.
 
+select: false
+
 properties:
+  $nodename:
+    pattern: "^clock-controller@[0-9a-f]+$"
+
   '#clock-cells':
     const: 1
 

-- 
2.39.2

[PATCH 06/10] ARM: dts: qcom: apq8064: drop #power-domain-cells property of GCC

[Dmitry Baryshkov]

On APQ8064 the Global Clock Controller (GCC) doesn't provide power
domains. Drop the #power-domain-cells property from the controller
device node.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
index 11e60b74c3c9..178a3b424670 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
@@ -684,7 +684,6 @@ gcc: clock-controller@900000 {
 			compatible = "qcom,gcc-apq8064", "syscon";
 			reg = <0x00900000 0x4000>;
 			#clock-cells = <1>;
-			#power-domain-cells = <1>;
 			#reset-cells = <1>;
 			clocks = <&cxo_board>,
 				 <&pxo_board>,

-- 
2.39.2

[PATCH 07/10] ARM: dts: qcom: msm8660: drop #power-domain-cells property of GCC

[Dmitry Baryshkov]

On MSM8660 the Global Clock Controller (GCC) doesn't provide power
domains. Drop the #power-domain-cells property from the controller
device node.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-msm8660.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8660.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8660.dtsi
index 455ba4bf1bf4..a66c474cd1aa 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8660.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8660.dtsi
@@ -113,7 +113,6 @@ tlmm: pinctrl@800000 {
 		gcc: clock-controller@900000 {
 			compatible = "qcom,gcc-msm8660";
 			#clock-cells = <1>;
-			#power-domain-cells = <1>;
 			#reset-cells = <1>;
 			reg = <0x900000 0x4000>;
 			clocks = <&pxo_board>, <&cxo_board>;

-- 
2.39.2

[PATCH 08/10] ARM: dts: qcom: msm8960: drop #power-domain-cells property of GCC

[Dmitry Baryshkov]

On MSM8960 the Global Clock Controller (GCC) doesn't provide power
domains. Drop the #power-domain-cells property from the controller
device node.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
index 922f9e49468a..a9c6d2dbb460 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
@@ -129,7 +129,6 @@ msmgpio: pinctrl@800000 {
 		gcc: clock-controller@900000 {
 			compatible = "qcom,gcc-msm8960";
 			#clock-cells = <1>;
-			#power-domain-cells = <1>;
 			#reset-cells = <1>;
 			reg = <0x900000 0x4000>;
 			clocks = <&cxo_board>,

-- 
2.39.2

[PATCH 09/10] arm64: dts: qcom: ipq6018: fix GCC node name

[Dmitry Baryshkov]

Device nodes should have generic names. Use 'clock-controller@' as a GCC
node name instead of a non-generic 'gcc@'.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 17ab6c475958..a84cf62d843c 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -396,7 +396,7 @@ qpic_pins: qpic-state {
 			};
 		};
 
-		gcc: gcc@1800000 {
+		gcc: clock-controller@1800000 {
 			compatible = "qcom,gcc-ipq6018";
 			reg = <0x0 0x01800000 0x0 0x80000>;
 			clocks = <&xo>, <&sleep_clk>;

-- 
2.39.2

[PATCH 10/10] arm64: dts: qcom: ipq8074: fix GCC node name

[Dmitry Baryshkov]

Device nodes should have generic names. Use 'clock-controller@' as a GCC
node name instead of a non-generic 'gcc@'.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 arch/arm64/boot/dts/qcom/ipq8074.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
index 5d42de829e75..27cf8d50f254 100644
--- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
@@ -363,7 +363,7 @@ qpic_pins: qpic-state {
 			};
 		};
 
-		gcc: gcc@1800000 {
+		gcc: clock-controller@1800000 {
 			compatible = "qcom,gcc-ipq8074";
 			reg = <0x01800000 0x80000>;
 			clocks = <&xo>,

-- 
2.39.2

Re: [PATCH 02/10] dt-bindings: clock: qcom,gcc-apq8064: use non-power-domain version of GCC schema

[Rob Herring (Arm)]

On Tue, 28 May 2024 23:43:20 +0300, Dmitry Baryshkov wrote:
> On APQ8064 and MSM8960 the GCC doesn't provide power domains. Switch it
> to use new qcom,gcc-nopd.yaml schema.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.example.dtb: clock-controller@900000: Unevaluated properties are not allowed ('#power-domain-cells' was unexpected)
	from schema $id: http://devicetree.org/schemas/clock/qcom,gcc-apq8064.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240528-qcom-gdscs-v1-2-03cf1b102a4f@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 03/10] dt-bindings: clock: qcom,gcc-msm8660: use non-power-domain version of GCC schema

[Rob Herring (Arm)]

On Tue, 28 May 2024 23:43:21 +0300, Dmitry Baryshkov wrote:
> On MSM8660 the GCC doesn't provide power domains. Switch it to use new
> qcom,gcc-nopd.yaml schema.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc-msm8660.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,gcc-msm8660.example.dtb: clock-controller@900000: Unevaluated properties are not allowed ('#power-domain-cells' was unexpected)
	from schema $id: http://devicetree.org/schemas/clock/qcom,gcc-msm8660.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240528-qcom-gdscs-v1-3-03cf1b102a4f@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 04/10] dt-bindings: clock: qcom,gcc-ipq6018: use non-power-domain version of GCC schema

[Rob Herring (Arm)]

On Tue, 28 May 2024 23:43:22 +0300, Dmitry Baryshkov wrote:
> On IPQ6018 the GCC doesn't provide power domains. Switch it to use new
> qcom,gcc-nopd.yaml schema.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/clock/qcom,gcc-ipq6018.example.dtb: clock-controller@1800000: Unevaluated properties are not allowed ('#power-domain-cells' was unexpected)
	from schema $id: http://devicetree.org/schemas/clock/qcom,gcc-ipq6018.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240528-qcom-gdscs-v1-4-03cf1b102a4f@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH 01/10] dt-bindings: clock: qcom: split the non-PD schema for GCC

[Krzysztof Kozlowski]

On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> On some of Qualcomm platforms the Global Clock Controller (GCC) doesn't
> provide power domains. Split no-PD version from the common qcom,gcc schema.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---


> diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> index 788825105f24..e7ec15b1780d 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> @@ -14,27 +14,14 @@ description: |
>    Common bindings for Qualcomm global clock control module providing the
>    clocks, resets and power domains.
>  
> -properties:
> -  '#clock-cells':
> -    const: 1
> -
> -  '#reset-cells':
> -    const: 1
> +allOf:
> +  - $ref: qcom,gcc-nopd.yaml
>  
> +properties:
>    '#power-domain-cells':
>      const: 1

So what's left here? One property? Not much benefit. Triple-schema
(include something to include something) does not make it readable. Just
do not require power-domain-cells in qcom,gcc.yaml.


Best regards,
Krzysztof

Re: [PATCH 05/10] dt-bindings: clock: qcom,gcc-nopd.yaml: force node name

[Krzysztof Kozlowski]

On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> Force GCC device nodes to have the name 'clock-controller'. Several
> platforms used 'gcc' here.

Well, only ones coming from Qualcomm being downstream-based:

Author: Varadarajan Narayanan <quic_varada@quicinc.com>
Date:   Thu Jun 29 11:48:33 2017 +0530

Author: Sricharan Ramabadhran <quic_srichara@quicinc.com>
Date:   Sun Jan 19 18:43:20 2020 +0530

(and there was also older with node name qcom,gcc, so clearly copy-paste
from downstream sources)

yet still we do not enforce names in individual schemas. You add it now
and next month turns out there is a power-reset-clock-controller which
could use gcc.yaml, but cannot because of node name enforcement.


Best regards,
Krzysztof

Re: [PATCH 09/10] arm64: dts: qcom: ipq6018: fix GCC node name

[Krzysztof Kozlowski]

On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> Device nodes should have generic names. Use 'clock-controller@' as a GCC
> node name instead of a non-generic 'gcc@'.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 10/10] arm64: dts: qcom: ipq8074: fix GCC node name

[Krzysztof Kozlowski]

On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> Device nodes should have generic names. Use 'clock-controller@' as a GCC
> node name instead of a non-generic 'gcc@'.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH 05/10] dt-bindings: clock: qcom,gcc-nopd.yaml: force node name

[Dmitry Baryshkov]

On Wed, 29 May 2024 at 10:39, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> > Force GCC device nodes to have the name 'clock-controller'. Several
> > platforms used 'gcc' here.
>
> Well, only ones coming from Qualcomm being downstream-based:
>
> Author: Varadarajan Narayanan <quic_varada@quicinc.com>
> Date:   Thu Jun 29 11:48:33 2017 +0530
>
> Author: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> Date:   Sun Jan 19 18:43:20 2020 +0530
>
> (and there was also older with node name qcom,gcc, so clearly copy-paste
> from downstream sources)
>
> yet still we do not enforce names in individual schemas. You add it now
> and next month turns out there is a power-reset-clock-controller which
> could use gcc.yaml, but cannot because of node name enforcement.

Ok, please ignore this patch, I'll drop it from the next iteration

-- 
With best wishes
Dmitry

Re: [PATCH 01/10] dt-bindings: clock: qcom: split the non-PD schema for GCC

[Dmitry Baryshkov]

On Wed, 29 May 2024 at 10:34, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 28/05/2024 22:43, Dmitry Baryshkov wrote:
> > On some of Qualcomm platforms the Global Clock Controller (GCC) doesn't
> > provide power domains. Split no-PD version from the common qcom,gcc schema.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
>
>
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> > index 788825105f24..e7ec15b1780d 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
> > @@ -14,27 +14,14 @@ description: |
> >    Common bindings for Qualcomm global clock control module providing the
> >    clocks, resets and power domains.
> >
> > -properties:
> > -  '#clock-cells':
> > -    const: 1
> > -
> > -  '#reset-cells':
> > -    const: 1
> > +allOf:
> > +  - $ref: qcom,gcc-nopd.yaml
> >
> > +properties:
> >    '#power-domain-cells':
> >      const: 1
>
> So what's left here? One property? Not much benefit. Triple-schema
> (include something to include something) does not make it readable. Just
> do not require power-domain-cells in qcom,gcc.yaml.

And add it to the required list on all relevant platforms? Ack, sounds
fine to me.


-- 
With best wishes
Dmitry

Re: [PATCH 01/10] dt-bindings: clock: qcom: split the non-PD schema for GCC

[Krzysztof Kozlowski]

On 29/05/2024 09:58, Dmitry Baryshkov wrote:
>>> -    const: 1
>>> -
>>> -  '#reset-cells':
>>> -    const: 1
>>> +allOf:
>>> +  - $ref: qcom,gcc-nopd.yaml
>>>
>>> +properties:
>>>    '#power-domain-cells':
>>>      const: 1
>>
>> So what's left here? One property? Not much benefit. Triple-schema
>> (include something to include something) does not make it readable. Just
>> do not require power-domain-cells in qcom,gcc.yaml.
> 
> And add it to the required list on all relevant platforms? Ack, sounds
> fine to me.

Yes.

Best regards,
Krzysztof