From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] dt-bindings: gpio: aspeed,sgpio: Order properties by DTS style
Date: Wed, 29 May 2024 14:43:20 +0930 [thread overview]
Message-ID: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-1-91c42976833b@codeconstruct.com.au> (raw)
In-Reply-To: <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au>
Tidy up the list of required properties and the example node by ordering
the properties in terms of the DTS coding style.
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
---
Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
index 46bb121360dc..6b15a3a3fb66 100644
--- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
@@ -51,12 +51,12 @@ properties:
required:
- compatible
- reg
- - gpio-controller
- - '#gpio-cells'
+ - clocks
- interrupts
- interrupt-controller
+ - gpio-controller
+ - '#gpio-cells'
- ngpios
- - clocks
- bus-frequency
additionalProperties: false
@@ -65,13 +65,13 @@ examples:
- |
#include <dt-bindings/clock/aspeed-clock.h>
sgpio: sgpio@1e780200 {
- #gpio-cells = <2>;
compatible = "aspeed,ast2500-sgpio";
- gpio-controller;
- interrupts = <40>;
reg = <0x1e780200 0x0100>;
clocks = <&syscon ASPEED_CLK_APB>;
+ interrupts = <40>;
interrupt-controller;
+ gpio-controller;
+ #gpio-cells = <2>;
ngpios = <80>;
bus-frequency = <12000000>;
};
--
2.39.2
next prev parent reply other threads:[~2024-05-29 5:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 5:13 [PATCH 0/4] dt-bindings: gpio: aspeed,sgpio: Miscellaneous cleanups Andrew Jeffery
2024-05-29 5:13 ` Andrew Jeffery [this message]
2024-05-29 7:26 ` [PATCH 1/4] dt-bindings: gpio: aspeed,sgpio: Order properties by DTS style Krzysztof Kozlowski
2024-05-30 0:48 ` Andrew Jeffery
2024-05-29 5:13 ` [PATCH 2/4] dt-bindings: gpio: aspeed,sgpio: Specify gpio-line-names Andrew Jeffery
2024-05-29 7:27 ` Krzysztof Kozlowski
2024-05-30 0:51 ` Andrew Jeffery
2024-05-29 5:13 ` [PATCH 3/4] dt-bindings: gpio: aspeed,sgpio: Specify #interrupt-cells Andrew Jeffery
2024-05-29 7:28 ` Krzysztof Kozlowski
2024-05-30 0:52 ` Andrew Jeffery
2024-05-29 5:13 ` [PATCH 4/4] dt-bindings: gpio: aspeed,sgpio: Require #interrupt-cells Andrew Jeffery
2024-05-29 7:28 ` Krzysztof Kozlowski
2024-05-30 0:54 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-1-91c42976833b@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).