From: Conor Dooley <conor@kernel.org>
To: Gustavo Silva <gustavograzs@gmail.com>
Cc: jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, lars@metafoo.de,
christophe.jaillet@wanadoo.fr, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: iio: chemical: add ENS160 sensor
Date: Wed, 29 May 2024 17:37:17 +0100 [thread overview]
Message-ID: <20240529-rule-asparagus-2e7015bdb50d@spud> (raw)
In-Reply-To: <20240529-upper-brisket-f326418bcfc2@spud>
[-- Attachment #1: Type: text/plain, Size: 500 bytes --]
On Wed, May 29, 2024 at 05:36:38PM +0100, Conor Dooley wrote:
> > + gas-sensor@0 {
> > + compatible = "sciosense,ens160";
> > + reg = <0>;
> > + spi-max-frequency = <10000000>;
>
> If you want to include this, you need to add an
> allOf:
> - $ref: /schemas/spi/spi-peripheral-props.yaml#
> above. Otherwise this looks pretty good, so with that added
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
(Please make sure to actually test it next time!)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-05-29 16:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 0:14 [PATCH v2 1/6] dt-bindings: vendor-prefixes: add ScioSense Gustavo Silva
2024-05-29 0:14 ` [PATCH v2 2/6] dt-bindings: iio: chemical: add ENS160 sensor Gustavo Silva
2024-05-29 1:42 ` Rob Herring (Arm)
2024-05-29 16:36 ` Conor Dooley
2024-05-29 16:37 ` Conor Dooley [this message]
2024-05-31 22:33 ` Gustavo Silva
2024-05-29 0:14 ` [PATCH v2 3/6] iio: chemical: add driver for " Gustavo Silva
2024-06-02 11:24 ` Jonathan Cameron
2024-05-29 0:14 ` [PATCH v2 4/6] iio: chemical: ens160: add triggered buffer support Gustavo Silva
2024-06-02 11:27 ` Jonathan Cameron
2024-05-29 0:14 ` [PATCH v2 5/6] iio: chemical: ens160: add power management support Gustavo Silva
2024-05-29 0:14 ` [PATCH v2 6/6] MAINTAINERS: Add ScioSense ENS160 Gustavo Silva
2024-05-29 7:29 ` [PATCH v2 1/6] dt-bindings: vendor-prefixes: add ScioSense Krzysztof Kozlowski
2024-05-29 16:34 ` Conor Dooley
2024-05-31 22:22 ` Gustavo Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529-rule-asparagus-2e7015bdb50d@spud \
--to=conor@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavograzs@gmail.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).