From: Johan Hovold <johan+linaro@kernel.org>
To: Lee Jones <lee@kernel.org>, Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Das Srinagesh <quic_gurus@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
Stephen Boyd <swboyd@chromium.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v2 03/14] mfd: pm8008: deassert reset on probe
Date: Wed, 29 May 2024 18:29:47 +0200 [thread overview]
Message-ID: <20240529162958.18081-4-johan+linaro@kernel.org> (raw)
In-Reply-To: <20240529162958.18081-1-johan+linaro@kernel.org>
Request and deassert any (optional) reset gpio during probe in case it
has been left asserted by the boot firmware.
Note the reset line is not asserted to avoid reverting to the default
I2C address in case the firmware has configured an alternate address.
Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
drivers/mfd/qcom-pm8008.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
index f71c490f25c8..5a77155a63d7 100644
--- a/drivers/mfd/qcom-pm8008.c
+++ b/drivers/mfd/qcom-pm8008.c
@@ -4,6 +4,7 @@
*/
#include <linux/bitops.h>
+#include <linux/gpio/consumer.h>
#include <linux/i2c.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
@@ -156,6 +157,7 @@ static struct regmap_config qcom_mfd_regmap_cfg = {
static int pm8008_probe(struct i2c_client *client)
{
struct regmap_irq_chip_data *irq_data;
+ struct gpio_desc *reset;
int rc;
struct device *dev;
struct regmap *regmap;
@@ -167,6 +169,16 @@ static int pm8008_probe(struct i2c_client *client)
i2c_set_clientdata(client, regmap);
+ reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR(reset))
+ return PTR_ERR(reset);
+
+ /*
+ * The PMIC does not appear to require a post-reset delay, but wait
+ * for a millisecond for now anyway.
+ */
+ usleep_range(1000, 2000);
+
if (of_property_read_bool(dev->of_node, "interrupt-controller")) {
rc = devm_regmap_add_irq_chip(dev, regmap, client->irq,
IRQF_SHARED, 0, &pm8008_irq_chip, &irq_data);
--
2.44.1
next prev parent reply other threads:[~2024-05-29 16:30 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 16:29 [PATCH v2 00/14] arm64: dts: qcom: sc8280xp-x13s: enable pm8008 camera pmic Johan Hovold
2024-05-29 16:29 ` [PATCH v2 01/14] dt-bindings: mfd: pm8008: add reset gpio Johan Hovold
2024-05-29 16:29 ` [PATCH v2 02/14] mfd: pm8008: fix regmap irq chip initialisation Johan Hovold
2024-05-31 16:22 ` Bryan O'Donoghue
2024-05-31 17:03 ` Lee Jones
2024-06-08 15:48 ` Johan Hovold
2024-05-29 16:29 ` Johan Hovold [this message]
2024-05-29 19:45 ` [PATCH v2 03/14] mfd: pm8008: deassert reset on probe Andy Shevchenko
2024-05-30 8:07 ` Johan Hovold
2024-05-30 8:34 ` Andy Shevchenko
2024-05-30 8:51 ` Johan Hovold
2024-05-29 16:29 ` [PATCH v2 04/14] mfd: pm8008: mark regmap structures as const Johan Hovold
2024-05-29 16:29 ` [PATCH v2 05/14] mfd: pm8008: use lower case hex notation Johan Hovold
2024-05-29 16:29 ` [PATCH v2 06/14] mfd: pm8008: rename irq chip Johan Hovold
2024-05-29 16:29 ` [PATCH v2 07/14] mfd: pm8008: drop unused driver data Johan Hovold
2024-05-29 16:29 ` [PATCH v2 08/14] pinctrl: qcom: spmi-gpio: drop broken pm8008 support Johan Hovold
2024-06-07 20:52 ` Linus Walleij
2024-05-29 16:29 ` [PATCH v2 09/14] dt-bindings: pinctrl: qcom,pmic-gpio: drop pm8008 Johan Hovold
2024-06-04 14:38 ` Rob Herring (Arm)
2024-06-07 20:53 ` Linus Walleij
2024-05-29 16:29 ` [PATCH v2 10/14] dt-bindings: mfd: pm8008: drop redundant descriptions Johan Hovold
2024-06-04 14:38 ` Rob Herring (Arm)
2024-05-29 16:29 ` [PATCH v2 11/14] dt-bindings: mfd: pm8008: rework binding Johan Hovold
2024-06-04 14:43 ` Rob Herring
2024-06-05 8:43 ` Dmitry Baryshkov
2024-06-08 15:36 ` Johan Hovold
2024-06-10 18:12 ` Dmitry Baryshkov
2024-05-29 16:29 ` [PATCH v2 12/14] mfd: pm8008: rework driver Johan Hovold
2024-05-29 19:53 ` Andy Shevchenko
2024-05-30 8:09 ` Johan Hovold
2024-05-31 17:08 ` Lee Jones
2024-05-31 18:44 ` Andy Shevchenko
2024-05-29 16:29 ` [PATCH v2 13/14] regulator: add pm8008 pmic regulator driver Johan Hovold
2024-05-29 20:02 ` Andy Shevchenko
2024-05-30 8:14 ` Johan Hovold
2024-05-30 8:46 ` Andy Shevchenko
2024-05-30 8:56 ` Johan Hovold
2024-05-30 11:59 ` Mark Brown
2024-05-29 16:29 ` [PATCH v2 14/14] arm64: dts: qcom: sc8280xp-x13s: enable pm8008 camera pmic Johan Hovold
2024-05-31 17:11 ` [PATCH v2 00/14] " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240529162958.18081-4-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=andersson@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gurus@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=robh@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).