devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Jones <ajones@ventanamicro.com>
To: Tomasz Jeznach <tjeznach@rivosinc.com>
Cc: Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
	 Robin Murphy <robin.murphy@arm.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Anup Patel <apatel@ventanamicro.com>,
	Sunil V L <sunilvl@ventanamicro.com>,
	 Nick Kossifidis <mick@ics.forth.gr>,
	Sebastien Boeuf <seb@rivosinc.com>,
	 Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, iommu@lists.linux.dev,
	 linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux@rivosinc.com,  Lu Baolu <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v6 2/7] iommu/riscv: Add RISC-V IOMMU platform device driver
Date: Mon, 3 Jun 2024 14:59:18 +0200	[thread overview]
Message-ID: <20240603-d622cdac0016f1f854bf2b4c@orel> (raw)
In-Reply-To: <7dcd9a154625704cbf9adc4b4ac07ca0b9753b31.1716578450.git.tjeznach@rivosinc.com>

On Fri, May 24, 2024 at 12:34:42PM GMT, Tomasz Jeznach wrote:
...
> +static struct platform_driver riscv_iommu_platform_driver = {
> +	.probe = riscv_iommu_platform_probe,
> +	.remove_new = riscv_iommu_platform_remove,

Hi Tomasz,

I think we should also support .shutdown (just turn the IOMMU off?),
otherwise the IOMMU driver reports EBUSY and fails to initialize when
rebooting.

Same comment for the PCI driver.

Thanks,
drew

  parent reply	other threads:[~2024-06-03 12:59 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 19:34 [PATCH v6 0/7] Linux RISC-V IOMMU Support Tomasz Jeznach
2024-05-24 19:34 ` [PATCH v6 1/7] dt-bindings: iommu: riscv: Add bindings for RISC-V IOMMU Tomasz Jeznach
2024-05-24 19:34 ` [PATCH v6 2/7] iommu/riscv: Add RISC-V IOMMU platform device driver Tomasz Jeznach
2024-05-29 15:15   ` Andrew Jones
2024-05-29 17:59     ` Tomasz Jeznach
2024-05-30  8:20       ` Andrew Jones
2024-06-03 12:53     ` Andrew Jones
2024-06-05 18:58     ` Tomasz Jeznach
2024-06-06  6:54       ` Andrew Jones
2024-06-03 12:59   ` Andrew Jones [this message]
2024-06-05 19:41     ` Tomasz Jeznach
2024-05-24 19:34 ` [PATCH v6 3/7] iommu/riscv: Add RISC-V IOMMU PCIe " Tomasz Jeznach
2024-05-24 19:34 ` [PATCH v6 4/7] iommu/riscv: Enable IOMMU registration and device probe Tomasz Jeznach
2024-05-24 19:34 ` [PATCH v6 5/7] iommu/riscv: Device directory management Tomasz Jeznach
2024-05-31  6:25   ` Zong Li
2024-06-10 17:49     ` Jason Gunthorpe
2024-06-10 18:48       ` Tomasz Jeznach
2024-06-10 22:20         ` Jason Gunthorpe
2024-06-11  2:00           ` Tomasz Jeznach
2024-06-11 12:12             ` Jason Gunthorpe
2024-05-24 19:34 ` [PATCH v6 6/7] iommu/riscv: Command and fault queue support Tomasz Jeznach
2024-05-24 19:34 ` [PATCH v6 7/7] iommu/riscv: Paging domain support Tomasz Jeznach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240603-d622cdac0016f1f854bf2b4c@orel \
    --to=ajones@ventanamicro.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=apatel@ventanamicro.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux@rivosinc.com \
    --cc=mick@ics.forth.gr \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=seb@rivosinc.com \
    --cc=sunilvl@ventanamicro.com \
    --cc=tjeznach@rivosinc.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).