From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C68813699A; Mon, 3 Jun 2024 16:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717431728; cv=none; b=i+jupjcX8WYNw30scZ1at4ukDYUDJ3pylgwGzcAg4Igm4KLQKl9Gpitevtk0XfcnXjineCypgTQ5FTwlCL6IwDJntucBvfYM59zp66A9Rg92r+Ta5leEzQGMSkGLTafmEs5SLAiZdM4NoTYzTIkiIv27Ov94yX07UELZPzDyfE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717431728; c=relaxed/simple; bh=J9BtwLiH5m/8yi2TzzknIpSb4dbESwBD7BOkieFUAmo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UFmlHtPXoBXui8jkYb60ug24jv6vI1DPAK7opPM9j/o1Xvtey6TxgXyzMbHzCtSuDkU54e6oPhBZqKU9EDfxGFyfeJKhSrkDhVmmdxcK9f3QiaPwNUS0YSAzo7m02bNCq81W4dxIA5gUiR4V+jeeMYWl2iLVFp1tpiFpxCgn3gQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Bu+lz/1X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Bu+lz/1X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75055C32786; Mon, 3 Jun 2024 16:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717431728; bh=J9BtwLiH5m/8yi2TzzknIpSb4dbESwBD7BOkieFUAmo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Bu+lz/1XWvQlr8sMasYuBapx64iWXKhYYuE32EKqwkwTOey+HseXz0BB7MFLlI85O kPe8OuoeQLtatj+0dQnBSE11+aHY/uHissu22mA7QPGEup2Hllay2U8y+LkCtZp4DG 3aefv6kQfoqF4xAaZe7pVlIWmWF9Y+GsLK2MFHFI5c7JgUKtJ0WrFs/K8XnjqwOkkr QQUfznd4Do66OiqXK5PtilHsFIryvPsWf1JLlvAjJh9pUXy6R4D1bjcz5BAa/bb2oq 5pJ2MF5f1AcMYkEi5sQdEjOy3hr3+xaolC+z5Rg7kItsSw7297BoxsKLfJ0vkFmy3K V+pk2YU6AvVRw== Date: Mon, 3 Jun 2024 18:22:05 +0200 From: Maxime Ripard To: Heiko Stuebner Cc: neil.armstrong@linaro.org, Cristian Ciocaltea , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Sandy Huang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mark Yao , Andy Yan , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@collabora.com, Alexandre ARNOUD , Luis de Arquer , Algea Cao Subject: Re: [PATCH 00/14] Add initial support for the Rockchip RK3588 HDMI TX Controller Message-ID: <20240603-noisy-convivial-boa-d3d862@houat> References: <20240601-b4-rk3588-bridge-upstream-v1-0-f6203753232b@collabora.com> <11359776.NyiUUSuA9g@phil> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="hjyaj4zwc26gvppm" Content-Disposition: inline In-Reply-To: <11359776.NyiUUSuA9g@phil> --hjyaj4zwc26gvppm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 03, 2024 at 03:03:12PM GMT, Heiko Stuebner wrote: > Am Montag, 3. Juni 2024, 14:14:17 CEST schrieb Andy Yan: > > Hi Neil: > >=20 > > On 6/3/24 16:55, Neil Armstrong wrote: > > > Hi Christian, > > >=20 > > > On 01/06/2024 15:12, Cristian Ciocaltea wrote: > > >> The RK3588 SoC family integrates a Quad-Pixel (QP) variant of the > > >> Synopsys DesignWare HDMI TX controller used in the previous SoCs. > > >> > > >> It is HDMI 2.1 compliant and supports the following features, among > > >> others: > > >> > > > . > > >=20 > > > .. > > >=20 > > >> * SCDC I2C DDC access > > >> * TMDS Scrambler enabling 2160p@60Hz with RGB/YCbCr4:4:4 > > >> * YCbCr4:2:0 enabling 2160p@60Hz at lower HDMI link speeds > > >> * Multi-stream audio > > >> * Enhanced Audio Return Channel (EARC) > > > -> Those features were already supported by the HDMI 2.0a compliant H= W, just > > > list the _new_ features for HDMI 2.1 > > >=20 > > > I did a quick review of your patchset and I don't understand why you = need > > > to add a separate dw-hdmi-qp.c since you only need simple variants of= the I2C > > > bus, infoframe and bridge setup. > > >=20 > > > Can you elaborate further ? isn't this Quad-Pixel (QP) TX controller = version > > > detectable at runtime ? > > >=20 > > > I would prefer to keep a single dw-hdmi driver if possible. > > > > The QP HDMI controller is a completely different variant with totally d= ifferent > > registers layout, see PATCH 13/14. > > I think make it a separate driver will be easier for development and ma= intenance. >=20 > I'm with Andy here. Trying to navigate a driver for two IP blocks really > sounds taxing especially when both are so different. If it's a completely new controller, I agree that it needs a new driver, but then why do we need to share code between the two? Maxime --hjyaj4zwc26gvppm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZl3tqAAKCRAnX84Zoj2+ dtR8AYCrl/MU0AvHJWAGUIyy2KX4WDHpvmSlO0r/dHofLBLuPbECLxs/Y4Xrv9aj dKaN4FEBgKcHcNQQuLzVnSmBEdP8BYecOgEiTEgRvexLG3nvcO9BpScGHjOp+i9W SoX1pl9lAQ== =Yfg6 -----END PGP SIGNATURE----- --hjyaj4zwc26gvppm--