From: joswang <joswang1221@gmail.com>
To: Thinh.Nguyen@synopsys.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, balbi@kernel.org,
devicetree@vger.kernel.org, joswang <joswang@lenovo.com>
Subject: [PATCH v2, 3/3] usb: dwc3: core: Workaround for CSR read timeout
Date: Mon, 3 Jun 2024 21:02:19 +0800 [thread overview]
Message-ID: <20240603130219.25825-1-joswang1221@gmail.com> (raw)
In-Reply-To: <20240601092646.52139-1-joswang1221@gmail.com>
From: joswang <joswang@lenovo.com>
DWC31 version 2.00a have an issue that would cause
a CSR read timeout When CSR read coincides with RAM
Clock Gating Entry.
This workaround solution disable Clock Gating, sacrificing
power consumption for normal operation.
Signed-off-by: joswang <joswang@lenovo.com>
---
drivers/usb/dwc3/core.c | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 3a8fbc2d6b99..1df85c505c9e 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -978,11 +978,22 @@ static void dwc3_core_setup_global_control(struct dwc3 *dwc)
*
* STAR#9000588375: Clock Gating, SOF Issues when ref_clk-Based
* SOF/ITP Mode Used
+ *
+ * WORKAROUND: DWC31 version 2.00a have an issue that would
+ * cause a CSR read timeout When CSR read coincides with RAM
+ * Clock Gating Entry.
+ *
+ * This workaround solution disable Clock Gating, sacrificing
+ * power consumption for normal operation.
*/
if ((dwc->dr_mode == USB_DR_MODE_HOST ||
dwc->dr_mode == USB_DR_MODE_OTG) &&
DWC3_VER_IS_WITHIN(DWC3, 210A, 250A))
reg |= DWC3_GCTL_DSBLCLKGTNG | DWC3_GCTL_SOFITPSYNC;
+ else if ((dwc->dr_mode == USB_DR_MODE_HOST ||
+ dwc->dr_mode == USB_DR_MODE_OTG) &&
+ DWC3_VER_IS(DWC31, 200A))
+ reg |= DWC3_GCTL_DSBLCLKGTNG;
else
reg &= ~DWC3_GCTL_DSBLCLKGTNG;
break;
@@ -992,6 +1003,18 @@ static void dwc3_core_setup_global_control(struct dwc3 *dwc)
* will work. Device-mode hibernation is not yet implemented.
*/
reg |= DWC3_GCTL_GBLHIBERNATIONEN;
+
+ /*
+ * WORKAROUND: DWC31 version 2.00a have an issue that would
+ * cause a CSR read timeout When CSR read coincides with RAM
+ * Clock Gating Entry.
+ *
+ * This workaround solution disable Clock Gating, sacrificing
+ * power consumption for normal operation.
+ */
+ if ((dwc->dr_mode == USB_DR_MODE_HOST ||
+ dwc->dr_mode == USB_DR_MODE_OTG) && DWC3_VER_IS(DWC31, 200A))
+ reg |= DWC3_GCTL_DSBLCLKGTNG;
break;
default:
/* nothing */
--
2.17.1
next prev parent reply other threads:[~2024-06-03 13:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240601092646.52139-1-joswang1221@gmail.com>
2024-06-03 13:00 ` [PATCH v2, 1/3] dt-bindings: usb: dwc3: Add snps,p2p3tranok quirk joswang
2024-06-04 6:33 ` Krzysztof Kozlowski
2024-06-12 14:28 ` joswang
2024-06-13 6:09 ` Krzysztof Kozlowski
2024-06-03 13:01 ` [PATCH v2, 2/3] usb: dwc3: core: add p3p2tranok quirk joswang
2024-06-04 0:02 ` Thinh Nguyen
2024-06-05 4:49 ` joswang
2024-06-07 14:24 ` joswang
2024-06-19 11:56 ` joswang
2024-06-22 0:05 ` Thinh Nguyen
2024-06-25 13:31 ` joswang
2024-06-26 1:29 ` Thinh Nguyen
2024-07-01 11:48 ` joswang
2024-06-03 13:02 ` joswang [this message]
2024-06-04 0:07 ` [PATCH v2, 3/3] usb: dwc3: core: Workaround for CSR read timeout Thinh Nguyen
2024-06-04 13:36 ` joswang
2024-06-04 23:13 ` Thinh Nguyen
2024-06-06 1:29 ` Thinh Nguyen
2024-06-07 14:07 ` joswang
2024-06-07 22:36 ` Thinh Nguyen
[not found] ` <CAMtoTm1roAvvWCu9LSfcbnozZnakMEexdUVxNyZ7N5KOG8tHcg@mail.gmail.com>
2024-06-07 22:49 ` Thinh Nguyen
2024-06-12 14:54 ` [PATCH v3, 1/3] dt-bindings: usb: dwc3: Add snps,p2p3tranok quirk joswang
2024-06-12 15:23 ` [PATCH v4, " joswang
2024-06-13 6:17 ` Krzysztof Kozlowski
2024-06-13 13:19 ` joswang
2024-06-13 14:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240603130219.25825-1-joswang1221@gmail.com \
--to=joswang1221@gmail.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=balbi@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joswang@lenovo.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).