From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A519846D; Tue, 4 Jun 2024 14:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717510493; cv=none; b=M/xkmhLfNMs7/b0lEWEVorTJlEkZS8f89GspSLy39LbPFS4EWYUZSG1PdwQSLitDByrzSxECVusfBpTDxUi1gEsybK67NIRJdaW6cHc2/g3+ZDUlGvq7Up0EG9ZinnUdaAC1wo/08TtaIq5Svm+STNci1lGzpNcEW4i+Da593AA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717510493; c=relaxed/simple; bh=Emp2vNt0kaMHwv6fgDZVGPGPq7mJCSey6kFsDap7nuY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kB5RN2IzEnIpVadXE7XdVLU1ICKuM5jfrjgsUYXN1WmBCZWMaoXMa8q77vPJ64g7nDq8ibzEbO1Hi+Pt50rpmUV5iT+rGz5lUR18QvysISiPKAiQ4yYCiPwWbTLTvs0FKtZniq/u1BaiQLBx0LGlbJbuovpGC8kAZfGEbM5cyRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=TSV0wjnk; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="TSV0wjnk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B280AC2BBFC; Tue, 4 Jun 2024 14:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717510492; bh=Emp2vNt0kaMHwv6fgDZVGPGPq7mJCSey6kFsDap7nuY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TSV0wjnkXfg2rV+bQt5MQttTHYjWdjHF9CK1gGVyWQ3wI9FRjWH9gL/FHIIsurtfz yFgs1omVWOfKo5ksb0MXaV27F24OZOPtH/IXQIQVfFSwUWqG0I91PKwQ5R4hIJ3JWZ EljJmkw34TPnYXg3Up7zvLKcVk7elu57wfFlJZ+EfmAid3roAe1wCVa6mGU5WnKvXA uIV6KnjCK6vaQHXcmLvP1D526xD9qXz/ZyRCxVQ6MKkXVSobrvSRFIhNLT7akihE0o uSYykNktm/kowNlOmqJiXnHbovqNMyuMIIWu0RkXvcflwBLmBMMYmtTbWLgubpd3kc ZSxV3tcNnLfbA== Date: Tue, 4 Jun 2024 15:14:47 +0100 From: Conor Dooley To: Linus Walleij Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , andy.shevchenko@gmail.com, Philip Howard , Sean Young , Chris Morgan , Stefan Wahren , linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, Nicola Di Lieto , Krzysztof Kozlowski , Dhruva Gole Subject: Re: [PATCH v6 1/2] dt-bindings: pwm: Add pwm-gpio Message-ID: <20240604-creole-easiest-2146ac2ea996@spud> References: <20240602-pwm-gpio-v6-0-e8f6ec9cc783@linaro.org> <20240602-pwm-gpio-v6-1-e8f6ec9cc783@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="P8b0aBffJ4COSccn" Content-Disposition: inline In-Reply-To: --P8b0aBffJ4COSccn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 04, 2024 at 03:38:41PM +0200, Linus Walleij wrote: > Some buzz around the patch made me notice this: >=20 > On Sun, Jun 2, 2024 at 10:33=E2=80=AFPM Linus Walleij wrote: >=20 > > + "#pwm-cells": > > + const: 3 >=20 > I guess we should document these three cells: > - First cell must be 0 - just the one PWM on the one GPIO pin > - Second cell should be the default period that can be changed by software > - Third cell is polarity, 0 or PWM_POLARITY_INVERTED >=20 > I guess this is 3 not 2 because the maintainers previously said they want= ed > it like this? (I haven't read all old mail, nor do I remember...) >=20 > The #pwm-cells are currently not properly specified in the bindings: for = example > pwm-tiecap.yaml says "See pwm.yaml in this directory for a description > of the cells format." > and that file says nothing about the cells and what they are for, should > I send a separate patch for that? Does this suffice? https://lore.kernel.org/linux-pwm/20240517-patient-stingily-30611f73e792@sp= ud/ --P8b0aBffJ4COSccn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZl8hVwAKCRB4tDGHoIJi 0sQzAQDB79qvEzSXOqctcAC9IyzJpzVjRToAWN2pNfPL6ftAxgD+NcEjHtiwXOHv JsqVks3ymjb/GyOMWHWBEBdZJmyDFA8= =oCvw -----END PGP SIGNATURE----- --P8b0aBffJ4COSccn--