From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B3AF19D885 for ; Wed, 5 Jun 2024 16:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603415; cv=none; b=PpfwpQ1m1n4AfbXnwajugCiXNMz9E0/s58BKIbNRgnwCUQRWNwcWiMcV5hlXvBRJ5E1yGGnXUSdMnBU2cmsJxl5bHDSecQRDAc2B9YDZcXkR3W/+TI9hP1Z7hHdKyRcVYaKYlyT/UW3IsBJRKYjydo4WfhKc6NP+ufwqvKq/w7o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603415; c=relaxed/simple; bh=p5xoxXEmNvPPLt6YV1rvuZtTOD99XueXa+W4v1sd5zA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bM5oouinkHl7lBm9P4XfeqQOfiIGIAGU96K2eJt5lck/UxSJSOL81mzbf+kB1Mh7Lc+XIS373iVIgQ+86uPXzwc4wzOTLwvXRvVT6Sa66TjSRxpnMtxIb2G/4vSUwi8Qc6mnc1/5g7Le9LonT5wgtIjDcTDhM/TYLcVzoXJf8ig= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BPrxDYnr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BPrxDYnr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53F05C2BD11; Wed, 5 Jun 2024 16:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717603414; bh=p5xoxXEmNvPPLt6YV1rvuZtTOD99XueXa+W4v1sd5zA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BPrxDYnrYPlk2tScYv1rpYxhbkHx+Y+kMDxYlttZ68K5Qga+nyPdjt0Ldf6LGzG03 H7rcx2l3T+Zu4DTuc67VIpsn5EprgknxKvc44wVH+B1b6Fq4JAONHm8Gu0G5wjU8rF DlruPhuiOTEpZizdGuJ2jUnnCkui/qKYpCYebYK8ML8YrbxR/kKvRqK6hU2kt6QXRz 3b8mfp+yUKChvYsctBzCc8JSpcHn0LP394zCyAB9v32Ek0d+mQyAfA5ZaNyw8X44uq SkbKl8k0rN0d997zgVxgE6o0pxNGf5xudCPp8JKHrPs6mETc04aKSEBZ9GWMv6VZQO aRCfhGQogB/Ig== Date: Wed, 5 Jun 2024 10:03:31 -0600 From: Rob Herring To: Marek Vasut Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , Conor Dooley , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , devicetree@vger.kernel.org, kernel@dh-electronics.com Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis Message-ID: <20240605160331.GA3222592-robh@kernel.org> References: <20240531204339.277848-1-marex@denx.de> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531204339.277848-1-marex@denx.de> On Fri, May 31, 2024 at 10:42:03PM +0200, Marek Vasut wrote: > Document default DP port preemphasis configurable via new DT property > "toshiba,pre-emphasis". This is useful in case the DP link properties > are known and starting link training from preemphasis setting of 0 dB > is not useful. The preemphasis can be set separately for both DP lanes > in range 0=0dB, 1=3.5dB, 2=6dB . > > Signed-off-by: Marek Vasut > --- > Cc: Andrzej Hajda > Cc: Conor Dooley > Cc: Daniel Vetter > Cc: David Airlie > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Krzysztof Kozlowski > Cc: Laurent Pinchart > Cc: Lucas Stach > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Neil Armstrong > Cc: Rob Herring > Cc: Robert Foss > Cc: Thomas Zimmermann > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: kernel@dh-electronics.com > --- > .../display/bridge/toshiba,tc358767.yaml | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > index 2ad0cd6dd49e0..dcf56e996ee22 100644 > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > @@ -98,6 +98,24 @@ properties: > reference to a valid eDP panel input endpoint node. This port is > optional, treated as DP panel if not defined > > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + toshiba,pre-emphasis: You didn't test adding this property. You will find it isn't allowed. That's because 'properties/port' schema above doesn't allow extra properties (on the port and endpoint). > + description: > + Display port output Pre-Emphasis settings for both ports. Both ports? This schema is for just port 2. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 2 > + maxItems: 2 > + items: > + enum: > + - 0 # -6dB de-emphasis > + - 1 # -3.5dB de-emphasis > + - 2 # No de-emphasis > + > oneOf: > - required: > - port@0 > -- > 2.43.0 >