From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF7236CDA1 for ; Wed, 5 Jun 2024 16:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603537; cv=none; b=n4UD0PeFUX8seOx6neJbH50qOi6afQd7HwZXGV38Dx8JiJ2FWyiyxBNcya934bWciDK7ez8cOOYAWKNEIsZKWsxPAGyPJcFlf5VolJKIqzWZbFTb0eBSte/cB0NSAg3LVvJSile438vUa0mEc6iYYOAddvXCyBdJyrlQ+iAq2Gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717603537; c=relaxed/simple; bh=Rn83EnfSNff3b/8SBMhGHjWg+Peuw6bxwb62hQbA+6k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j3B3bXvkOmIebN5+G0/MfvBHR88t8ZVSQFFOXAGSc2uw+o+iqFXqn48ucDCcFXMgkeEgKw/OGpveo3iQ0mX+1VcLkt04z5qlrXeteduIKBZ2B+7ZuZM0wxsgOPVaDxmcwp9FgBFkUME5/4tzpD1o1Hgivx9h3GYUfpbTNtGjxdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tGhV8lbF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tGhV8lbF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 156ABC2BD11; Wed, 5 Jun 2024 16:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717603536; bh=Rn83EnfSNff3b/8SBMhGHjWg+Peuw6bxwb62hQbA+6k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tGhV8lbFIuwQAk2EhyrdCKyXH9TfNlapJcP19jC8SsW2yIhvytv5MrwBq4lbuqYBr vH47nt81NaRP+4H0u320sFi4qL/sGpJShM9K/Xd7JEeptoAWM4OBUH1oL644zkRPN1 Gl5KEbZ4qVvpwaKoe5Ba+QMvlxvOLJhvodk/jAhVyEYl26qjKKCB6F5PmX3hoDWoJH 22NwtIhetEO0Td5tD6T1PjM6XxwOjyd4f4TNv4mNLKXoYhmgeXJGwcdwmmgdJVXVvT tPV0TRjcStgvKrdd7sapWJ5aMHACVmUJ6C5lG60bB4Gv0Os5zdblCaKGyBM5WzIU1U ANBwW67DagQRQ== Date: Wed, 5 Jun 2024 10:05:33 -0600 From: Rob Herring To: Alexander Stein Cc: dri-devel@lists.freedesktop.org, Marek Vasut , Andrzej Hajda , Conor Dooley , Daniel Vetter , David Airlie , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Lucas Stach , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Robert Foss , Thomas Zimmermann , devicetree@vger.kernel.org, kernel@dh-electronics.com Subject: Re: [PATCH 1/2] dt-bindings: display: bridge: tc358867: Document default DP preemphasis Message-ID: <20240605160533.GB3222592-robh@kernel.org> References: <20240531204339.277848-1-marex@denx.de> <3302939.44csPzL39Z@steina-w> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3302939.44csPzL39Z@steina-w> On Tue, Jun 04, 2024 at 11:42:31AM +0200, Alexander Stein wrote: > Hi Marek, > > Am Freitag, 31. Mai 2024, 22:42:03 CEST schrieb Marek Vasut: > > Document default DP port preemphasis configurable via new DT property > > "toshiba,pre-emphasis". This is useful in case the DP link properties > > are known and starting link training from preemphasis setting of 0 dB > > is not useful. The preemphasis can be set separately for both DP lanes > > in range 0=0dB, 1=3.5dB, 2=6dB . > > > > Signed-off-by: Marek Vasut > > --- > > Cc: Andrzej Hajda > > Cc: Conor Dooley > > Cc: Daniel Vetter > > Cc: David Airlie > > Cc: Jernej Skrabec > > Cc: Jonas Karlman > > Cc: Krzysztof Kozlowski > > Cc: Laurent Pinchart > > Cc: Lucas Stach > > Cc: Maarten Lankhorst > > Cc: Maxime Ripard > > Cc: Neil Armstrong > > Cc: Rob Herring > > Cc: Robert Foss > > Cc: Thomas Zimmermann > > Cc: devicetree@vger.kernel.org > > Cc: dri-devel@lists.freedesktop.org > > Cc: kernel@dh-electronics.com > > --- > > .../display/bridge/toshiba,tc358767.yaml | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > > index 2ad0cd6dd49e0..dcf56e996ee22 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > > @@ -98,6 +98,24 @@ properties: > > reference to a valid eDP panel input endpoint node. This port is > > optional, treated as DP panel if not defined > > > > + properties: > > + endpoint: > > + $ref: /schemas/media/video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + toshiba,pre-emphasis: > > + description: > > + Display port output Pre-Emphasis settings for both ports. > > Is this a property of the port or the endpoint? What's the difference? Either is the same data path. The preference is custom properties in endpoint node, not port nodes. Rob