From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2EE53EA72; Thu, 6 Jun 2024 07:14:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717658102; cv=none; b=DlI9qTFRxkquPdE3VZA5dsntuefnxh2frPYiQbv1Vso1cGaZ8ufJIIcYKdrA2YadE9LNcZG16MYEe1m77s7wlQfvRj78EbH2nCumNORN1OFQQnFAkHXcR5wBHjveTxKPB8wOLNAglbZN7U87Gi6UebhNFHtpPhDuk5uwD9RKzkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717658102; c=relaxed/simple; bh=yuEfa2UV+chthnn3Iq3uD3lcYGjVSmjvN5Ua5bJVleA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BICVDte3bpQhcnP0MDvg/F2XzcLTqECGjZ2VyMVV2W+BLJ8yOuhDgsXzaTj+GHhHA6VAa5wgaj6khfJ1N2+SRaeX4HB1LgCOi81+t1LarQVnr8OmVJDIHpWqDDrEGtkk2f1HYXS5F+ktV1iaOSlo0rxo0+2HNxKlQT03B8NTAPs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=aHR3T4hD; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="aHR3T4hD" Received: by mail.gandi.net (Postfix) with ESMTPSA id 7B94524000C; Thu, 6 Jun 2024 07:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1717658092; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wtbh9Y5BhilOkF/Ov75N0g0FuZgE8BmOll+aw1LPV5g=; b=aHR3T4hDEP8oxcmxkYTox0dObRLwyZcs+fahBn8rXTbY59oM2XLPUW9uoDNleMjbfCg4j+ mu3oByJSRS1EenKMN7sKE4FDFl5ZANKacfMfWI/lTkfdpcCoga3r1X9kHWSHM5QQF3gebv rhxwFpSSwrRjHyOORqfbHy9vzgJoXDPzUaX5/MBeYu5n5sOnxdVWM2JJwPSN0vklHbjv+b O1CTPUiludohFB/9OBNhSt3z55OaWP7uTYIXOIA//9AvjHLhMJ8gNs4I+VYQfyEKgXWuAK 7Y3pWc5NHsT8gyj2B5OE9g2j97vk8ZTIk3AUCFLs7NQYzxh+pkv6JspSHB6WTQ== Date: Thu, 6 Jun 2024 09:14:46 +0200 From: Herve Codina To: Andy Shevchenko Cc: Simon Horman , Sai Krishna Gajula , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v2 09/19] irqdomain: Add missing parameter descriptions in docs Message-ID: <20240606091446.03f262fa@bootlin.com> In-Reply-To: References: <20240527161450.326615-1-herve.codina@bootlin.com> <20240527161450.326615-10-herve.codina@bootlin.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Hi Andy, On Wed, 5 Jun 2024 23:02:30 +0300 Andy Shevchenko wrote: > Mon, May 27, 2024 at 06:14:36PM +0200, Herve Codina kirjoitti: > > During compilation, several warning of the following form were raised: > > Function parameter or struct member 'x' not described in 'yyy' > > > > Add the missing function parameter descriptions. > > ... > > > /** > > * irq_domain_translate_onecell() - Generic translate for direct one cell > > * bindings > > + * @d: Interrupt domain involved in the translation > > + * @fwspec: The firmware interrupt specifier to translate > > + * @out_hwirq: Pointer to storage for the hardware interrupt number > > + * @out_type: Pointer to storage for the interrupt type > > (kernel-doc perhaps will complain on something missing here) > > > */ > > int irq_domain_translate_onecell(struct irq_domain *d, > > You can go further and run > > scripts/kernel-doc -v -none -Wall ... > > against this file and fix more issues, like I believe in the above excerpt. > Yes indeed, I missed the return values. Will be updated in the next iteration. Best regards, Hervé