From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCB5A6F31F; Mon, 10 Jun 2024 21:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718055456; cv=none; b=j/jCdumX0gK+sxw8ooFh51hNEVyAJkKl0PBjfNw+RrFAPV1Qakfcq3pil6ueKiWY4iAHrmBYWuIEwn9A1u3uil6x9VqvK+i7GVQXNxppkzXYED5quxMDYC/ZInTJovZ3QuyAiM8vZqDPC9hvsBNLLjCMZQpFpcgSt412ZeEdAIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718055456; c=relaxed/simple; bh=Hu+ZYAxQIeqrj2N96pQMniXoSv97DArchied9P7Vm1k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dr05P9TvSCXDQz4pjuvaTpTdudzWVN6Qi0qG7kQ/wq+b1x4J+7HeD9ekV8PslpCJ2hHkOD2qH3myDrKHTsTjx+BIOZm4iaOEfo2uX2UdWSwWuIYw451FvMB1Yt6KOLclyhk0OEfPrgvkFKpqA+BV688AN9rorM9+15v0wgsS7Xc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eK7GeKlS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eK7GeKlS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12DF7C4AF50; Mon, 10 Jun 2024 21:37:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718055456; bh=Hu+ZYAxQIeqrj2N96pQMniXoSv97DArchied9P7Vm1k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eK7GeKlSJb8Ckg8qzh4cf2ZYk8nis9CGFj3j4T3Q4QfgbeOCCm0FV/6SFblR3J7si pxfoNeGyWC4xbIiuoMVSdGD+JZvpzwxpW7z/gnBc9Z0pgeMWs1fVZ7MIjrS/WEXRCv h61wr6uzmBp9FtmoJiwoVXPupCCZew8yrOKV5e895AMnBVJQM/eejzhmspRrRRnie6 jTv4Q78kVKB+O64bYc6jWMI/KQ5kUBVgzKZoTZT6ugNUUEmpVElHOVLtKIJfalEVXQ raIKCmtKVsjBCrb0AVnlpkB3kj6MGqvWDfiYNQorQelmaTYWDxymZSm44Hmo5gxcEW JEZh2WqqKsCLQ== Date: Mon, 10 Jun 2024 15:37:35 -0600 From: Rob Herring To: Bjorn Helgaas Cc: Herve Codina , Simon Horman , Sai Krishna Gajula , Thomas Gleixner , Krzysztof Kozlowski , Conor Dooley , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Lee Jones , Arnd Bergmann , Horatiu Vultur , UNGLinuxDriver@microchip.com, Andrew Lunn , Heiner Kallweit , Russell King , Saravana Kannan , Bjorn Helgaas , Philipp Zabel , Lars Povlsen , Steen Hegelund , Daniel Machon , Alexandre Belloni , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Allan Nielsen , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v2 17/19] PCI: of_property: Add interrupt-controller property in PCI device nodes Message-ID: <20240610213735.GA3112053-robh@kernel.org> References: <20240527161450.326615-18-herve.codina@bootlin.com> <20240606192612.GA814032@bhelgaas> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240606192612.GA814032@bhelgaas> On Thu, Jun 06, 2024 at 02:26:12PM -0500, Bjorn Helgaas wrote: > On Mon, May 27, 2024 at 06:14:44PM +0200, Herve Codina wrote: > > PCI devices and bridges DT nodes created during the PCI scan are created > > with the interrupt-map property set to handle interrupts. > > > > In order to set this interrupt-map property at a specific level, a > > phandle to the parent interrupt controller is needed. On systems that > > are not fully described by a device-tree, the parent interrupt > > controller may be unavailable (i.e. not described by the device-tree). > > > > As mentioned in the [1], avoiding the use of the interrupt-map property > > and considering a PCI device as an interrupt controller itself avoid the > > use of a parent interrupt phandle. > > > > In that case, the PCI device itself as an interrupt controller is > > responsible for routing the interrupts described in the device-tree > > world (DT overlay) to the PCI interrupts. > > > > Add the 'interrupt-controller' property in the PCI device DT node. > > > > [1]: https://lore.kernel.org/lkml/CAL_Jsq+je7+9ATR=B6jXHjEJHjn24vQFs4Tvi9=vhDeK9n42Aw@mail.gmail.com/ > > > > Signed-off-by: Herve Codina > > No objection from me, but I'd like an ack/review from Rob. Given it is more DT patches in the series, how about I take them and this one with your ack instead? Rob