devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema
Date: Mon, 10 Jun 2024 15:58:57 -0600	[thread overview]
Message-ID: <20240610215857.GA3135318-robh@kernel.org> (raw)
In-Reply-To: <20240606041212.78428-1-animeshagarwal28@gmail.com>

On Thu, Jun 06, 2024 at 09:42:00AM +0530, Animesh Agarwal wrote:
> Convert the dummy SPDIF receiver bindings to DT schema.

Really the subject should be something like "Merge linux,spdif-dir into 
linux,spdif-dit". Then the commit message should say why (they are the 
same other than compatible. "sound-name-prefix" wasn't documented for 
linux,spdif-dir, but is in use already.)

> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> 
> ---
> Changes	in v2:
> - Add linux,spdif-dir compatible in existing linux,spdif-dit.yaml
> instead of creating new yaml file specifically for dummy SPDIF receiver.
> - Change file name to support both transmitter and receiver bindings.
> ---
>  .../sound/{linux,spdif-dit.yaml => linux,spdif.yaml}   |  8 +++++---
>  .../devicetree/bindings/sound/spdif-receiver.txt       | 10 ----------
>  2 files changed, 5 insertions(+), 13 deletions(-)
>  rename Documentation/devicetree/bindings/sound/{linux,spdif-dit.yaml => linux,spdif.yaml} (75%)
>  delete mode 100644 Documentation/devicetree/bindings/sound/spdif-receiver.txt

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

  parent reply	other threads:[~2024-06-10 21:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  4:12 [PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema Animesh Agarwal
2024-06-07  9:22 ` Neil Armstrong
2024-06-10 21:58 ` Rob Herring [this message]
2024-06-12 17:09 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240610215857.GA3135318-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=animeshagarwal28@gmail.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).