[PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema

[PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema

[Animesh Agarwal]

Convert the dummy SPDIF receiver bindings to DT schema.

Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>

---
Changes	in v2:
- Add linux,spdif-dir compatible in existing linux,spdif-dit.yaml
instead of creating new yaml file specifically for dummy SPDIF receiver.
- Change file name to support both transmitter and receiver bindings.
---
 .../sound/{linux,spdif-dit.yaml => linux,spdif.yaml}   |  8 +++++---
 .../devicetree/bindings/sound/spdif-receiver.txt       | 10 ----------
 2 files changed, 5 insertions(+), 13 deletions(-)
 rename Documentation/devicetree/bindings/sound/{linux,spdif-dit.yaml => linux,spdif.yaml} (75%)
 delete mode 100644 Documentation/devicetree/bindings/sound/spdif-receiver.txt

diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml b/Documentation/devicetree/bindings/sound/linux,spdif.yaml
similarity index 75%
rename from Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
rename to Documentation/devicetree/bindings/sound/linux,spdif.yaml
index fe5f0756af2f..0f4893e11ec4 100644
--- a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
+++ b/Documentation/devicetree/bindings/sound/linux,spdif.yaml
@@ -1,10 +1,10 @@
 # SPDX-License-Identifier: GPL-2.0
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/sound/linux,spdif-dit.yaml#
+$id: http://devicetree.org/schemas/sound/linux,spdif.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
-title: Dummy SPDIF Transmitter
+title: Dummy SPDIF Transmitter/Receiver
 
 maintainers:
   - Mark Brown <broonie@kernel.org>
@@ -14,7 +14,9 @@ allOf:
 
 properties:
   compatible:
-    const: linux,spdif-dit
+    enum:
+      - linux,spdif-dit
+      - linux,spdif-dir
 
   "#sound-dai-cells":
     const: 0
diff --git a/Documentation/devicetree/bindings/sound/spdif-receiver.txt b/Documentation/devicetree/bindings/sound/spdif-receiver.txt
deleted file mode 100644
index 80f807bf8a1d..000000000000
--- a/Documentation/devicetree/bindings/sound/spdif-receiver.txt
+++ /dev/null
@@ -1,10 +0,0 @@
-Device-Tree bindings for dummy spdif receiver
-
-Required properties:
-	- compatible: should be "linux,spdif-dir".
-
-Example node:
-
-	codec: spdif-receiver {
-		compatible = "linux,spdif-dir";
-	};
-- 
2.45.1

Re: [PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema

[Neil Armstrong]

On 06/06/2024 06:12, Animesh Agarwal wrote:
> Convert the dummy SPDIF receiver bindings to DT schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> 
> ---
> Changes	in v2:
> - Add linux,spdif-dir compatible in existing linux,spdif-dit.yaml
> instead of creating new yaml file specifically for dummy SPDIF receiver.
> - Change file name to support both transmitter and receiver bindings.
> ---
>   .../sound/{linux,spdif-dit.yaml => linux,spdif.yaml}   |  8 +++++---
>   .../devicetree/bindings/sound/spdif-receiver.txt       | 10 ----------
>   2 files changed, 5 insertions(+), 13 deletions(-)
>   rename Documentation/devicetree/bindings/sound/{linux,spdif-dit.yaml => linux,spdif.yaml} (75%)
>   delete mode 100644 Documentation/devicetree/bindings/sound/spdif-receiver.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml b/Documentation/devicetree/bindings/sound/linux,spdif.yaml
> similarity index 75%
> rename from Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
> rename to Documentation/devicetree/bindings/sound/linux,spdif.yaml
> index fe5f0756af2f..0f4893e11ec4 100644
> --- a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
> +++ b/Documentation/devicetree/bindings/sound/linux,spdif.yaml
> @@ -1,10 +1,10 @@
>   # SPDX-License-Identifier: GPL-2.0
>   %YAML 1.2
>   ---
> -$id: http://devicetree.org/schemas/sound/linux,spdif-dit.yaml#
> +$id: http://devicetree.org/schemas/sound/linux,spdif.yaml#
>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
> -title: Dummy SPDIF Transmitter
> +title: Dummy SPDIF Transmitter/Receiver
>   
>   maintainers:
>     - Mark Brown <broonie@kernel.org>
> @@ -14,7 +14,9 @@ allOf:
>   
>   properties:
>     compatible:
> -    const: linux,spdif-dit
> +    enum:
> +      - linux,spdif-dit
> +      - linux,spdif-dir
>   
>     "#sound-dai-cells":
>       const: 0
> diff --git a/Documentation/devicetree/bindings/sound/spdif-receiver.txt b/Documentation/devicetree/bindings/sound/spdif-receiver.txt
> deleted file mode 100644
> index 80f807bf8a1d..000000000000
> --- a/Documentation/devicetree/bindings/sound/spdif-receiver.txt
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -Device-Tree bindings for dummy spdif receiver
> -
> -Required properties:
> -	- compatible: should be "linux,spdif-dir".
> -
> -Example node:
> -
> -	codec: spdif-receiver {
> -		compatible = "linux,spdif-dir";
> -	};

Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema

[Rob Herring]

On Thu, Jun 06, 2024 at 09:42:00AM +0530, Animesh Agarwal wrote:
> Convert the dummy SPDIF receiver bindings to DT schema.

Really the subject should be something like "Merge linux,spdif-dir into 
linux,spdif-dit". Then the commit message should say why (they are the 
same other than compatible. "sound-name-prefix" wasn't documented for 
linux,spdif-dir, but is in use already.)

> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> 
> ---
> Changes	in v2:
> - Add linux,spdif-dir compatible in existing linux,spdif-dit.yaml
> instead of creating new yaml file specifically for dummy SPDIF receiver.
> - Change file name to support both transmitter and receiver bindings.
> ---
>  .../sound/{linux,spdif-dit.yaml => linux,spdif.yaml}   |  8 +++++---
>  .../devicetree/bindings/sound/spdif-receiver.txt       | 10 ----------
>  2 files changed, 5 insertions(+), 13 deletions(-)
>  rename Documentation/devicetree/bindings/sound/{linux,spdif-dit.yaml => linux,spdif.yaml} (75%)
>  delete mode 100644 Documentation/devicetree/bindings/sound/spdif-receiver.txt

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema

[Mark Brown]

On Thu, 06 Jun 2024 09:42:00 +0530, Animesh Agarwal wrote:
> Convert the dummy SPDIF receiver bindings to DT schema.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema
      commit: a694956df4ca75d74bcd422908ddcd8e2ea3042e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark