From: Amna Waseem <Amna.Waseem@axis.com>
To: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
"Rob Herring" <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
<linux-hwmon@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Amna Waseem <Amna.Waseem@axis.com>, <kernel@axis.com>
Subject: [PATCH v4 0/2] hwmon: (ina2xx):Add Suppor for passing alert polarity from device tree to driver
Date: Tue, 11 Jun 2024 11:36:24 +0200 [thread overview]
Message-ID: <20240611-apol-ina2xx-fix-v4-0-8df1d2282fc5@axis.com> (raw)
The INA230 has alert polarity bit in Mask/Enable register which can be
configured to be active high or active low depending upon the requirements
of the hardware using this chip. The patches in this series adds the support
for passing alert polarity value from device tree to the driver. Alert polarity
property is added device tree bindings and the driver is modified to read
this property and set the Alert polarity (APOL) bit value in Mask/Enable register
of INA230.
Signed-off-by: Amna Waseem <Amna.Waseem@axis.com>
---
Changes in v4:
- Remove unnecessary checks while setting alert polarity bit
- Link to v3: https://lore.kernel.org/r/20240603-apol-ina2xx-fix-v3-0-b9eff3158e4e@axis.com
Changes in v3:
- Convert the alert polarity property in dt bindings to be a flag
- Set alert polarity depending upon on the presence of flag in
device tree. Otherwise, default value is set
- Make setting of alert polarity to be chip specific since only
ina226,ina230 and ina231 supports alert polarity setting.
- Link to v2: https://lore.kernel.org/r/20240529-apol-ina2xx-fix-v2-0-ee2d76142de2@axis.com
Changes in v2:
- Add vendor specific prefix to alert polarity property in binding.
- Minor improvement in description of alert polarity binding property
- Remove usage of mutex while setting alert polarity in Mask/Enable
register
- Correct indentation
- Link to v1: https://lore.kernel.org/r/20240529-apol-ina2xx-fix-v1-0-77b4b382190f@axis.com
---
Amna Waseem (2):
dt-bindings: hwmon: ti,ina2xx: Add ti,alert-polarity-active-high property
hwmon: (ina2xx) Add device tree support to pass alert polarity
.../devicetree/bindings/hwmon/ti,ina2xx.yaml | 9 ++++++
drivers/hwmon/ina2xx.c | 32 ++++++++++++++++++++++
2 files changed, 41 insertions(+)
---
base-commit: a38297e3fb012ddfa7ce0321a7e5a8daeb1872b6
change-id: 20240524-apol-ina2xx-fix-34e76346cb26
Best regards,
--
Amna Waseem <Amna.Waseem@axis.com>
next reply other threads:[~2024-06-11 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 9:36 Amna Waseem [this message]
2024-06-11 9:36 ` [PATCH v4 1/2] dt-bindings: hwmon: ti,ina2xx: Add ti,alert-polarity-active-high property Amna Waseem
2024-06-11 9:36 ` [PATCH v4 2/2] hwmon: (ina2xx) Add device tree support to pass alert polarity Amna Waseem
2024-06-12 14:15 ` Guenter Roeck
2024-06-11 12:49 ` [PATCH v4 0/2] hwmon: (ina2xx):Add Suppor for passing alert polarity from device tree to driver Krzysztof Kozlowski
2024-06-12 6:18 ` Amna Waseem
2024-06-12 6:20 ` Krzysztof Kozlowski
2024-06-12 6:37 ` Amna Waseem
2024-06-12 6:44 ` Krzysztof Kozlowski
2024-06-12 6:50 ` Amna Waseem
2024-06-12 14:18 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611-apol-ina2xx-fix-v4-0-8df1d2282fc5@axis.com \
--to=amna.waseem@axis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).