From: Rob Herring <robh@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: wlf,wm8782: Convert to dtschema
Date: Tue, 11 Jun 2024 14:00:48 -0600 [thread overview]
Message-ID: <20240611200048.GA2966276-robh@kernel.org> (raw)
In-Reply-To: <20240611124405.63427-1-animeshagarwal28@gmail.com>
On Tue, Jun 11, 2024 at 06:14:00PM +0530, Animesh Agarwal wrote:
> Convert the WM8782 audio codec bindings to DT schema.
Missing "ASoC" on the subject. Mark may not see it.
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> .../devicetree/bindings/sound/wlf,wm8782.yaml | 47 +++++++++++++++++++
> .../devicetree/bindings/sound/wm8782.txt | 24 ----------
> 2 files changed, 47 insertions(+), 24 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8782.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/wm8782.txt
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
This is yet another binding with no in tree DTS user. That's fine, but
not what I would prioritize converting. There are several ways I would
prioritize what to work on.
- There's a list maintained in CI of number of occurrences of
undocumented (by schema) compatibles[1]. Start at the top (most
occurrences).
- Pick a platform (or family of platform) and get the warnings down to
0 or close. There's a grouping of warnings and undocumented
compatibles by platform family at the same link. Pick something that's
widely used like RPi or RK3399.
- Prioritize newer platforms over older (arm64 rather than
arm32(though there's still new arm32 stuff)).
- Fix warnings treewide from common schemas (i.e. from dtschema).
That's not conversions, but related.
Happy to discuss further what you plan to do. All the DT maintainers are
on IRC (#devicetree on Libera).
Rob
[1] https://gitlab.com/robherring/linux-dt/-/jobs/6918723853
next prev parent reply other threads:[~2024-06-11 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 12:44 [PATCH] dt-bindings: wlf,wm8782: Convert to dtschema Animesh Agarwal
2024-06-11 20:00 ` Rob Herring [this message]
2024-06-12 11:59 ` Animesh Agarwal
2024-06-12 9:57 ` Charles Keepax
2024-06-13 9:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240611200048.GA2966276-robh@kernel.org \
--to=robh@kernel.org \
--cc=animeshagarwal28@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).