From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A61F171C4; Tue, 11 Jun 2024 22:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718146544; cv=none; b=BUVN0ROzsELCuT9FhLmJb8NptcehOoVn6dpJusOM+y476dZGlMuQVGWxdsCjCYgLTjxMSY42eTSo1CsODSFoGUJJ7f8OuhEIXSvn3nuhf3zOP1X8bcBxKq46Kk6N71ter0UPDDri75aYHyERtVRixN2qEzDNRNd8DYW+LITYOFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718146544; c=relaxed/simple; bh=tfmwzXhu9BMvZdNucjHAIFq8O+nZOSTOqKttExZG0P0=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=GafEwndMNLMGAIERlCul4GZymuSrdE6pnn6aIrayIMYqHSXFKNKlPMGh1gR+hrXdDC8mbH8samgjqjDkei6L/qsx+D4OLTezmUFaFK7EFNFx72QZQfR46+vajCVytz5KOdNoByawh0oONNuWULD61uuLiN3j2gQNHOOQ45y11hI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A7pxdhgD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A7pxdhgD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A0C9C2BD10; Tue, 11 Jun 2024 22:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718146543; bh=tfmwzXhu9BMvZdNucjHAIFq8O+nZOSTOqKttExZG0P0=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=A7pxdhgDNwl0CRAVasMm9Q18XFML4ebWwMMtwSRB078ntHxIYEfNrp+4t38McKEym 9Mbu/3WwIfhYbMrZlqu3YigWp9p6tLAcrQ8t8fNDVsrNom4keCoxM5P2uaoc3BisfH Tv1NvrM/CehSzwVFu7gHEYo1MtWv8/9ofoqWcwm7ZwZWCaMHSTgriGAA44d3oC9/l7 xfGAWXlG8hZSKHlh+CZUcvtc3MgVBnyhPwXZyg9L3FuzoLkKbLX0T6yyh1Iyx8D2xA 1r/7dxQE3RbzF2CaEURzoqsdakZBbpuAmP7pxyBtCIwFhtSV5lL1BUgyKr8wESuNwO 493hSgD34nxaw== Date: Tue, 11 Jun 2024 17:55:41 -0500 From: Bjorn Helgaas To: Bartosz Golaszewski Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marcel Holtmann , Luiz Augusto von Dentz , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Balakrishna Godavarthi , Rocky Liao , Kalle Valo , Jeff Johnson , Bjorn Andersson , Konrad Dybcio , Bjorn Helgaas , Srini Kandagatla , Elliot Berman , Caleb Connolly , Neil Armstrong , Dmitry Baryshkov , Alex Elder , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, Jeff Johnson , ath12k@lists.infradead.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, Bartosz Golaszewski , kernel@quicinc.com, Amit Pundir Subject: Re: [PATCH v8 12/17] PCI: hold the rescan mutex when scanning for the first time Message-ID: <20240611225541.GA1005771@bhelgaas> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240528-pwrseq-v8-12-d354d52b763c@linaro.org> On Tue, May 28, 2024 at 09:03:20PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > With the introduction of PCI device power control drivers that will be > able to trigger the port rescan when probing, we need to hold the rescan > mutex during the initial pci_host_probe() too or the two could get in > each other's way. > > Tested-by: Amit Pundir > Signed-off-by: Bartosz Golaszewski With s/hold the/Hold the/ in subject to match history, Acked-by: Bjorn Helgaas > --- > drivers/pci/probe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c > index 8e696e547565..604fc96b1098 100644 > --- a/drivers/pci/probe.c > +++ b/drivers/pci/probe.c > @@ -3072,7 +3072,9 @@ int pci_host_probe(struct pci_host_bridge *bridge) > struct pci_bus *bus, *child; > int ret; > > + pci_lock_rescan_remove(); > ret = pci_scan_root_bus_bridge(bridge); > + pci_unlock_rescan_remove(); > if (ret < 0) { > dev_err(bridge->dev.parent, "Scanning root bridge failed"); > return ret; > > -- > 2.43.0 >