* Re: [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards
2024-06-12 10:33 [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards Shengyu Qu
@ 2024-06-12 10:36 ` Shengyu Qu
2024-06-12 16:18 ` Conor Dooley
2024-06-19 11:20 ` Conor Dooley
2 siblings, 0 replies; 5+ messages in thread
From: Shengyu Qu @ 2024-06-12 10:36 UTC (permalink / raw)
To: kernel, robh, krzk+dt, conor+dt, paul.walmsley, palmer, aou,
william.qiu, devicetree, linux-riscv
Cc: wiagn233, stable
I forgot to add change note. This version of patch only changed fixes
info to the commit Conor advised.
Best regards,
Shengyu
在 2024/6/12 18:33, Shengyu Qu 写道:
> Currently, for JH7110 boards with EMMC slot, vqmmc voltage for EMMC is
> fixed to 1.8V, while the spec needs it to be 3.3V on low speed mode and
> should support switching to 1.8V when using higher speed mode. Since
> there are no other peripherals using the same voltage source of EMMC's
> vqmmc(ALDO4) on every board currently supported by mainline kernel,
> regulator-max-microvolt of ALDO4 should be set to 3.3V.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
> Fixes: 7dafcfa79cc9 ("riscv: dts: starfive: enable DCDC1&ALDO4 node in axp15060")
> ---
> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 37b4c294ffcc..c7a549ec7452 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -244,7 +244,7 @@ emmc_vdd: aldo4 {
> regulator-boot-on;
> regulator-always-on;
> regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> regulator-name = "emmc_vdd";
> };
> };
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards
2024-06-12 10:33 [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards Shengyu Qu
2024-06-12 10:36 ` Shengyu Qu
@ 2024-06-12 16:18 ` Conor Dooley
2024-06-12 16:41 ` Shengyu Qu
2024-06-19 11:20 ` Conor Dooley
2 siblings, 1 reply; 5+ messages in thread
From: Conor Dooley @ 2024-06-12 16:18 UTC (permalink / raw)
To: Shengyu Qu
Cc: kernel, robh, krzk+dt, conor+dt, paul.walmsley, palmer, aou,
william.qiu, devicetree, linux-riscv, stable
[-- Attachment #1: Type: text/plain, Size: 1439 bytes --]
On Wed, Jun 12, 2024 at 06:33:31PM +0800, Shengyu Qu wrote:
> Currently, for JH7110 boards with EMMC slot, vqmmc voltage for EMMC is
> fixed to 1.8V, while the spec needs it to be 3.3V on low speed mode and
> should support switching to 1.8V when using higher speed mode. Since
> there are no other peripherals using the same voltage source of EMMC's
> vqmmc(ALDO4) on every board currently supported by mainline kernel,
I should've asked last time around, does the star64 also support 3.3
volts?
> regulator-max-microvolt of ALDO4 should be set to 3.3V.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
> Fixes: 7dafcfa79cc9 ("riscv: dts: starfive: enable DCDC1&ALDO4 node in axp15060")
> ---
> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index 37b4c294ffcc..c7a549ec7452 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -244,7 +244,7 @@ emmc_vdd: aldo4 {
> regulator-boot-on;
> regulator-always-on;
> regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> regulator-name = "emmc_vdd";
> };
> };
> --
> 2.39.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards
2024-06-12 16:18 ` Conor Dooley
@ 2024-06-12 16:41 ` Shengyu Qu
0 siblings, 0 replies; 5+ messages in thread
From: Shengyu Qu @ 2024-06-12 16:41 UTC (permalink / raw)
To: Conor Dooley
Cc: wiagn233, kernel, robh, krzk+dt, conor+dt, paul.walmsley, palmer,
aou, william.qiu, devicetree, linux-riscv, stable
[-- Attachment #1.1.1: Type: text/plain, Size: 1816 bytes --]
Hi Conor,
From star64's schematic, I didn't see any difference between star64 and
vf2's emmc vqmmc source design and aldo4 is not shared with other
peripheral at all. And this patch is tested on my vf2 with no problem at
all. So I think it is supported.
Best regards,
Shengyu
在 2024/6/13 0:18, Conor Dooley 写道:
> On Wed, Jun 12, 2024 at 06:33:31PM +0800, Shengyu Qu wrote:
>> Currently, for JH7110 boards with EMMC slot, vqmmc voltage for EMMC is
>> fixed to 1.8V, while the spec needs it to be 3.3V on low speed mode and
>> should support switching to 1.8V when using higher speed mode. Since
>> there are no other peripherals using the same voltage source of EMMC's
>> vqmmc(ALDO4) on every board currently supported by mainline kernel,
>
> I should've asked last time around, does the star64 also support 3.3
> volts?
>
>> regulator-max-microvolt of ALDO4 should be set to 3.3V.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
>> Fixes: 7dafcfa79cc9 ("riscv: dts: starfive: enable DCDC1&ALDO4 node in axp15060")
>> ---
>> arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> index 37b4c294ffcc..c7a549ec7452 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
>> @@ -244,7 +244,7 @@ emmc_vdd: aldo4 {
>> regulator-boot-on;
>> regulator-always-on;
>> regulator-min-microvolt = <1800000>;
>> - regulator-max-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> regulator-name = "emmc_vdd";
>> };
>> };
>> --
>> 2.39.2
>>
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards
2024-06-12 10:33 [PATCH v2] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards Shengyu Qu
2024-06-12 10:36 ` Shengyu Qu
2024-06-12 16:18 ` Conor Dooley
@ 2024-06-19 11:20 ` Conor Dooley
2 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-06-19 11:20 UTC (permalink / raw)
To: kernel, robh, krzk+dt, conor+dt, paul.walmsley, palmer, aou,
william.qiu, devicetree, linux-riscv, Shengyu Qu
Cc: conor, Conor Dooley, stable
From: Conor Dooley <conor.dooley@microchip.com>
On Wed, 12 Jun 2024 18:33:31 +0800, Shengyu Qu wrote:
> Currently, for JH7110 boards with EMMC slot, vqmmc voltage for EMMC is
> fixed to 1.8V, while the spec needs it to be 3.3V on low speed mode and
> should support switching to 1.8V when using higher speed mode. Since
> there are no other peripherals using the same voltage source of EMMC's
> vqmmc(ALDO4) on every board currently supported by mainline kernel,
> regulator-max-microvolt of ALDO4 should be set to 3.3V.
>
> [...]
Applied to riscv-dt-fixes, thanks!
[1/1] riscv: dts: starfive: Set EMMC vqmmc maximum voltage to 3.3V on JH7110 boards
https://git.kernel.org/conor/c/3c1f81a1b554
I was kinda holding out for a response for Emil, but I've applied this cos
I'd like to get a fixes PR sent out later this week.
Thanks,
Conor.
^ permalink raw reply [flat|nested] 5+ messages in thread