From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-40135.protonmail.ch (mail-40135.protonmail.ch [185.70.40.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBF5821360 for ; Wed, 12 Jun 2024 03:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.70.40.135 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162481; cv=none; b=BkG3/zNNTERwxsbO0NIzxBgE1eHoKNX98fnRx4mBPV70HXopyYWEp0CvD5m0BmRuoMXt5jG+CBZbqM3YQggY/w3mPxxiPf0B/BbMeNUc+55yKSA/l9xQGq8Uvk7VASGCYY9PxzMILq+s7tQ5NzTkzWG6Pz4rQppfE4QEdhqAavk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162481; c=relaxed/simple; bh=AL1kabKZ9aiMqgGz1LRsyrTMRHsm/iVj6Z4f0MCoRMM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ScOPM0k4zehXgY8h8NpfXTVNFu4sK0XSjoqqq8ykFiaPE+HERvzBfT6W4HOqcL3U8QANWTdE6Fw9aC/fc9txofMjNlR7xrRsvZWiU5KJGpeHzshlIRFF60h8Mw4mIl88wBBIzeuJdKhDaDKedd0dqChzCpLwlOqgGDdRnqhbzWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com; spf=pass smtp.mailfrom=protonmail.com; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b=t9ES+U2C; arc=none smtp.client-ip=185.70.40.135 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=protonmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=protonmail.com header.i=@protonmail.com header.b="t9ES+U2C" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1718162477; x=1718421677; bh=AL1kabKZ9aiMqgGz1LRsyrTMRHsm/iVj6Z4f0MCoRMM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=t9ES+U2CFM2N7R68Kk+DbbPfL20hFS7hPGgN1I0qit3FUOOgxtbrgRFRspefpNRZl bk7xhcp+OHFsnx/XSi5N9VwT6jX8ug0uOZa6Ec0+IPkfoUljmk0akE8bFvMdVIOF52 Q5n8F4JUux/jj4jncJYLzFRaE4AJ5B8ckEoBo5E8lVxq/VJhf3z/fNRDuMCsjSvx7B 6Yr3dXPbabVCfAvBqC3rnnTCAtx12eBEidWzDifythG/hHGcIMSaJMY6xNMKviS4yq lrOgiP1I3JcuxX5UVz+C8ubq2Nr+jY3WYSRdvhjp4Iy5hj0YVEitSA5Nsowu02gJUV SKODAQztrwUJg== Date: Wed, 12 Jun 2024 03:21:14 +0000 To: linux-kernel@vger.kernel.org From: Raymond Hackley Cc: Markuss Broks , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , Nikita Travkin , linux-input@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: [PATCH 2/3] input/touchscreen: imagis: Add supports for Imagis IST3038 Message-ID: <20240612032036.33103-3-raymondhackley@protonmail.com> In-Reply-To: <20240612032036.33103-1-raymondhackley@protonmail.com> References: <20240612032036.33103-1-raymondhackley@protonmail.com> Feedback-ID: 49437091:user:proton X-Pm-Message-ID: bf48fd04ac644e695a965ccf5ee76145560c19f7 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Imagis IST3038 is another variant of Imagis IST3038 IC, which has a different register interface from IST3038C (possibly firmware defined). Unlike IST3038C/IST3032C, IST3038 has different registers for commands, which means IST3038 doesn't use protocol B. Similar to IST3032C and maybe the other variants, IST3038 has touch keys support, which provides KEY_APPSELECT and KEY_BACK. Add support for IST3038 with touch keys. Signed-off-by: Raymond Hackley --- drivers/input/touchscreen/imagis.c | 23 +++++++++++++++++++---- 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/imagis.c b/drivers/input/touchscreen= /imagis.c index 886bcfc8497a..b2f4bc60721d 100644 --- a/drivers/input/touchscreen/imagis.c +++ b/drivers/input/touchscreen/imagis.c @@ -12,9 +12,16 @@ #include #include =20 +#define IST30XX_REG_STATUS=09=090x20 +#define IST30XX_REG_CHIPID=09=09(0x40000000 | IST3038C_DIRECT_ACCESS) +#define IST30XX_WHOAMI=09=09=090x30003000 +#define IST30XXA_WHOAMI=09=09=090x300a300a +#define IST30XXB_WHOAMI=09=09=090x300b300b +#define IST3038_WHOAMI=09=09=090x30383038 + #define IST3032C_WHOAMI=09=09=090x32c +#define IST3038C_WHOAMI=09=09=090x38c =20 -#define IST3038B_REG_STATUS=09=090x20 #define IST3038B_REG_CHIPID=09=090x30 #define IST3038B_WHOAMI=09=09=090x30380b =20 @@ -25,7 +32,6 @@ #define IST3038C_REG_TOUCH_STATUS=09(IST3038C_REG_HIB_BASE | IST3038C_HIB_= ACCESS) #define IST3038C_REG_TOUCH_COORD=09(IST3038C_REG_HIB_BASE | IST3038C_HIB_A= CCESS | 0x8) #define IST3038C_REG_INTR_MESSAGE=09(IST3038C_REG_HIB_BASE | IST3038C_HIB_= ACCESS | 0x4) -#define IST3038C_WHOAMI=09=09=090x38c #define IST3038C_CHIP_ON_DELAY_MS=0960 #define IST3038C_I2C_RETRY_COUNT=093 #define IST3038C_MAX_FINGER_NUM=09=0910 @@ -397,9 +403,17 @@ static const struct imagis_properties imagis_3032c_dat= a =3D { =09.protocol_b =3D true, }; =20 +static const struct imagis_properties imagis_3038_data =3D { +=09.interrupt_msg_cmd =3D IST30XX_REG_STATUS, +=09.touch_coord_cmd =3D IST30XX_REG_STATUS, +=09.whoami_cmd =3D IST30XX_REG_CHIPID, +=09.whoami_val =3D IST3038_WHOAMI, +=09.touch_keys_supported =3D true, +}; + static const struct imagis_properties imagis_3038b_data =3D { -=09.interrupt_msg_cmd =3D IST3038B_REG_STATUS, -=09.touch_coord_cmd =3D IST3038B_REG_STATUS, +=09.interrupt_msg_cmd =3D IST30XX_REG_STATUS, +=09.touch_coord_cmd =3D IST30XX_REG_STATUS, =09.whoami_cmd =3D IST3038B_REG_CHIPID, =09.whoami_val =3D IST3038B_WHOAMI, }; @@ -415,6 +429,7 @@ static const struct imagis_properties imagis_3038c_data= =3D { #ifdef CONFIG_OF static const struct of_device_id imagis_of_match[] =3D { =09{ .compatible =3D "imagis,ist3032c", .data =3D &imagis_3032c_data }, +=09{ .compatible =3D "imagis,ist3038", .data =3D &imagis_3038_data }, =09{ .compatible =3D "imagis,ist3038b", .data =3D &imagis_3038b_data }, =09{ .compatible =3D "imagis,ist3038c", .data =3D &imagis_3038c_data }, =09{ }, --=20 2.39.2