From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18DFC171E70; Wed, 12 Jun 2024 14:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718200934; cv=none; b=rprD+uzmYJRVDinAavaNFIzETn+2+9Wca1web/IfPaoo6PhuEkaEADFplcrf6hVNVkhCU/w2BeHrfEhQ5nTXcBONHIQQjI9sNV8MuwhdwhoFSqa4nDF7fWEt0gm56f+XLErZzv45tXyxc2eqbELyrxYJ/WyXMFrPZNx2qfeDILQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718200934; c=relaxed/simple; bh=eX92Qy5bBbTvqj1rZW1BZWOEF8jJThi6VroQb/e/KDE=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CadSyP/ovRoKlzXQ/22a+OeT8OfExxLlfZ1S+R2ESLR5gTJ+IbRGsCJnKUNmsptYVYZkNG1ToOadQ02EjpmZ/BXRsVTELU/n2i6hunn0Tl8whE2VyoUSAtokJqTYws76bpm3sfxblyPfr0DPtOoIspNGMVVuoFFN5fMq+7mk2vw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BTmhKbuc; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BTmhKbuc" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6F57C116B1; Wed, 12 Jun 2024 14:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718200933; bh=eX92Qy5bBbTvqj1rZW1BZWOEF8jJThi6VroQb/e/KDE=; h=Date:From:To:Subject:References:In-Reply-To:From; b=BTmhKbucnDuEtueX2mqWsxi3l0U+qHJnfPaoCg30YwnXvATwGTaAx34g+62SNl4hZ /Yznn88XbrM/n7iZjZXZbE18sVs6wM5F5KaREoGPwCIRB6H+DTAUVBOBoyMAnxHAYo k4nU7z7BXjwTQWMa2L+z7VW5vVA8t5CyhMfWXFIjjTgIe/RV8paY3Ti/tfFFv2UfxQ US34jUqyhWXVFaFYel1To6uXVmFjiTpBu4bHvGAx5WzN0wR9id1uNhVW5BauMaD08d rQJXAFtfl/FO2ufhGj+l6KimCGBB3EM2avaynF2ifZzIMgxacVFFgdIqydGImQl0CO mFzs9Knngkohg== Date: Wed, 12 Jun 2024 15:02:08 +0100 From: Lee Jones To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Stefan Wahren , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Dave Ertman , Lizhi Hou , clement.leger@bootlin.com Subject: Re: Raspberry Pi5 - RP1 driver - RFC Message-ID: <20240612140208.GC1504919@google.com> References: Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, 11 Jun 2024, Andrea della Porta wrote: > Hi, > I'm on the verge of reworking the RP1 driver from downstream in order for it to be > in good shape for upstream inclusion. > RP1 is an MFD chipset that acts as a south-bridge PCIe endpoint sporting a pletora > of subdevices (i.e. Ethernet, USB host controller, I2C, PWM, etc.) whose registers > are all reachable starting from an offset from the BAR address. It's less of an MFD and more of an SoC. Please refrain from implemented entire SoCs in drivers/mfd. Take a look in drivers/soc and drivers/platform. -- Lee Jones [李琼斯]