[PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema

[PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema

[Kanak Shilledar]

Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to
newer DT schema. Created DT schema based on the .txt file which had
`compatible`, `reg`, `interrupts` and `clocks` as required properties.

Additions to the original binding
- changed the file name from vt8500-uart to via,vt8500-uart.yaml
- removed unnecessary alias from the example.
- added Greg and Jiri as maintainers (referred MAINTAINERS file).

Signed-off-by: Kanak Shilledar <kanakshilledar@gmail.com>
---
Changes in v2:
- Rebased changes
- Changed maintainers to have Rob. VT8500 is orphaned according
to the maintainers file.
- Replaced `compatible` property description with comments.
---
 .../bindings/serial/via,vt8500-uart.yaml      | 47 +++++++++++++++++++
 .../bindings/serial/vt8500-uart.txt           | 27 -----------
 2 files changed, 47 insertions(+), 27 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml
 delete mode 100644 Documentation/devicetree/bindings/serial/vt8500-uart.txt

diff --git a/Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml b/Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml
new file mode 100644
index 000000000000..a81bdfaec2e9
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/via,vt8500-uart.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/via,vt8500-uart.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VIA VT8500 and WonderMedia WM8xxx UART Controller
+
+maintainers:
+  - Rob Herring <robh@kernel.org>
+  - Kanak Shilledar <kanakshilledar111@protonmail.com>
+
+allOf:
+  - $ref: serial.yaml
+
+properties:
+  compatible:
+    enum:
+      - via,vt8500-uart # up to WM8850/WM8950
+      - wm,wm8880-uart  # for WM8880 and later
+
+  clocks:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  reg:
+    maxItems: 1
+
+required:
+  - compatible
+  - clocks
+  - interrupts
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    serial@d8200000 {
+        compatible = "via,vt8500-uart";
+        reg = <0xd8200000 0x1040>;
+        interrupts = <32>;
+        clocks = <&clkuart0>;
+    };
diff --git a/Documentation/devicetree/bindings/serial/vt8500-uart.txt b/Documentation/devicetree/bindings/serial/vt8500-uart.txt
deleted file mode 100644
index 2b64e6107fb3..000000000000
--- a/Documentation/devicetree/bindings/serial/vt8500-uart.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-* VIA VT8500 and WonderMedia WM8xxx UART Controller
-
-Required properties:
-- compatible: should be "via,vt8500-uart" (for VIA/WonderMedia chips up to and
-	including WM8850/WM8950), or "wm,wm8880-uart" (for WM8880 and later)
-
-- reg: base physical address of the controller and length of memory mapped
-	region.
-
-- interrupts: hardware interrupt number
-
-- clocks: shall be the input parent clock phandle for the clock. This should
-	be the 24Mhz reference clock.
-
-Aliases may be defined to ensure the correct ordering of the uarts.
-
-Example:
-	aliases {
-		serial0 = &uart0;
-	};
-
-	uart0: serial@d8200000 {
-		compatible = "via,vt8500-uart";
-		reg = <0xd8200000 0x1040>;
-		interrupts = <32>;
-		clocks = <&clkuart0>;
-	};
-- 
2.45.2

Re: [PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema

[Greg Kroah-Hartman]

On Wed, Jun 12, 2024 at 07:59:45PM +0530, Kanak Shilledar wrote:
> Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to
> newer DT schema. Created DT schema based on the .txt file which had
> `compatible`, `reg`, `interrupts` and `clocks` as required properties.
> 
> Additions to the original binding
> - changed the file name from vt8500-uart to via,vt8500-uart.yaml
> - removed unnecessary alias from the example.
> - added Greg and Jiri as maintainers (referred MAINTAINERS file).

Really?  Because I see here:

> +maintainers:
> +  - Rob Herring <robh@kernel.org>
> +  - Kanak Shilledar <kanakshilledar111@protonmail.com>

Not me :)

thanks,

greg k-h

Re: [PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema

[Krzysztof Kozlowski]

On 12/06/2024 16:29, Kanak Shilledar wrote:
> Convert the VIA VT8500 and WonderMedia WM8xxx UART Controller to
> newer DT schema. Created DT schema based on the .txt file which had
> `compatible`, `reg`, `interrupts` and `clocks` as required properties.
> 
> Additions to the original binding
> - changed the file name from vt8500-uart to via,vt8500-uart.yaml
> - removed unnecessary alias from the example.
> - added Greg and Jiri as maintainers (referred MAINTAINERS file).

?

> 
> Signed-off-by: Kanak Shilledar <kanakshilledar@gmail.com>
> ---
> Changes in v2:
> - Rebased changes
> - Changed maintainers to have Rob. VT8500 is orphaned according
> to the maintainers file.
> - Replaced `compatible` property description with comments.


> +
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/via,vt8500-uart.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: VIA VT8500 and WonderMedia WM8xxx UART Controller
> +
> +maintainers:
> +  - Rob Herring <robh@kernel.org>

Not Rob.

> +  - Kanak Shilledar <kanakshilledar111@protonmail.com>

I doubt you care about this device. This could be most recent
contributor, so: Alexey Charkov <alchark@gmail.com>


> +
> +allOf:
> +  - $ref: serial.yaml
> +
> +properties:
> +  compatible:
> +    enum:
> +      - via,vt8500-uart # up to WM8850/WM8950
> +      - wm,wm8880-uart  # for WM8880 and later


Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema

[Kanak Shilledar]

Sorry for the confusion. I will fix the maintainers part quickly.
I have one question that if I find any area for the SoC is not
maintained or orphaned,
how can I find out who is the maintainer for that area, or the one who
last contributed
for that specific area?

Thanks and Regards,
Kanak Shilledar

Re: [PATCH v2] dt-bindings: serial: vt8500-uart: convert to json-schema

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On Wed, Jun 12, 2024 at 09:02:27PM +0530, Kanak Shilledar wrote:
> Sorry for the confusion. I will fix the maintainers part quickly.
> I have one question that if I find any area for the SoC is not
> maintained or orphaned,
> how can I find out who is the maintainer for that area, or the one who
> last contributed
> for that specific area?

git log for the latter, MAINTAINERS for the former.


Thanks,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]