devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sunxi@lists.linux.dev,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Ryan Walklin <ryan@testtoast.com>,
	Chris Morgan <macroalpha82@gmail.com>
Subject: Re: [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status registers range
Date: Wed, 12 Jun 2024 16:25:10 +0100	[thread overview]
Message-ID: <20240612152510.GE1504919@google.com> (raw)
In-Reply-To: <56aef347-7582-497e-be02-d82eda7b3528@arm.com>

On Wed, 12 Jun 2024, Andre Przywara wrote:

> Hi Lee,
> 
> On 02/05/2024 10:39, Lee Jones wrote:
> > On Thu, 18 Apr 2024, Andre Przywara wrote:
> > 
> > > While we list the "IRQ status *and acknowledge*" registers as volatile,
> > > they are missing from the writable range array, so acknowledging any
> > > interrupts was met with an -EIO error.
> > > 
> > > Add the five registers that hold those bits to the writable array.
> > > 
> > > Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC")
> > > Reported-by: Chris Morgan <macromorgan@hotmail.com>
> > > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > > ---
> > >   drivers/mfd/axp20x.c | 1 +
> > >   1 file changed, 1 insertion(+)
> > 
> > Acked-by: Lee Jones <lee@kernel.org>
> 
> Can you please take just this patch as a fix for 6.10? This fixes the power
> key operation.
> This applies cleanly on top of v6.10-rc3, so there is no need for any extra
> immutable branch or coordination with regulator.
> (The same is true independently for patch 2/5, on the regulator side).

What does the Fixes: commit break?

Or is it the case that it never worked properly?

-- 
Lee Jones [李琼斯]

  reply	other threads:[~2024-06-12 15:25 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-18  0:07 [PATCH v2 0/5] regulator: Fix AXP717 PMIC support Andre Przywara
2024-04-18  0:07 ` [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status registers range Andre Przywara
2024-04-23  0:16   ` John Watts
2024-05-02  9:39   ` Lee Jones
2024-06-12 15:07     ` Andre Przywara
2024-06-12 15:25       ` Lee Jones [this message]
2024-06-12 15:34         ` Andre Przywara
2024-06-12 15:48           ` Lee Jones
2024-06-13  9:48             ` Andre Przywara
2024-06-13 12:04               ` Lee Jones
2024-04-18  0:07 ` [PATCH v2 2/5] regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones Andre Przywara
2024-04-23  0:09   ` John Watts
2024-06-12 14:40   ` Andre Przywara
2024-06-14  8:12     ` Lee Jones
2024-06-14 10:01       ` Andre Przywara
2024-04-18  0:07 ` [PATCH v2 3/5] dt-bindings: mfd: x-powers,axp152: add boost regulator Andre Przywara
2024-05-02  9:39   ` Lee Jones
2024-04-18  0:07 ` [PATCH v2 4/5] mfd: axp20x: AXP717: Add support for " Andre Przywara
2024-05-02  9:39   ` Lee Jones
2024-05-22 18:54   ` Chris Morgan
2024-04-18  0:07 ` [PATCH v2 5/5] regulator: axp20x: AXP717: Add " Andre Przywara
2024-04-23  5:19 ` [PATCH v2 0/5] regulator: Fix AXP717 PMIC support Mark Brown
2024-05-02  9:38   ` Lee Jones
2024-05-06 15:29     ` Mark Brown
2024-04-28  8:41 ` Ryan Walklin
2024-05-02  9:37   ` Lee Jones
2024-05-06 15:26 ` Mark Brown
2024-05-06 15:29 ` Mark Brown
2024-06-14  9:24 ` (subset) " Mark Brown
2024-08-01 15:22 ` Chen-Yu Tsai
2024-08-05 14:21   ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240612152510.GE1504919@google.com \
    --to=lee@kernel.org \
    --cc=andre.przywara@arm.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=macroalpha82@gmail.com \
    --cc=robh@kernel.org \
    --cc=ryan@testtoast.com \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).