From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39D8717C7C8; Wed, 12 Jun 2024 15:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718207303; cv=none; b=bnuOSKhKFDCemBXUCMllHnyj6oIuzqn/ix0PUR0xERqMjcyEYMf5uO+nC7pvdAi0g2DB3AqVn8DDkmAa+8pm60XVVMJuynFVdT/F7CMUWUbhE1BKWPl7/xVeQsaYukL6qmycPAFNTEKrpX1YtvR0Na/ouC6WZ8PhqFSQh5Isdpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718207303; c=relaxed/simple; bh=+7dgCMAE8xXP+L3ANBWO9tjojn+ydsIoH8bkB9Y/hl0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=f2eeqcuRL1L17jiBrCpNp5g8HIho98O/p99fGZP8+RK/yybjofOVwcvRY89QBUZnrWQPbN5dG6KdsZb54lyUFpdlzjyFoUKx0We0yosaad49CPERkIaPIsfEhu4XXSjo9Il4LyFTRLFReBSdBFmRo5suo/ltGWHDTz+Oy7kLraM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lUoEHlHK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lUoEHlHK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14137C116B1; Wed, 12 Jun 2024 15:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718207302; bh=+7dgCMAE8xXP+L3ANBWO9tjojn+ydsIoH8bkB9Y/hl0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lUoEHlHKTw5SY/PsFRy8BXdFLVNotLH7+Y0aYLHpuXxwKr8kdciwjPmVIP6d+k5wP hYFaetN8ddefpaQIiEdi8hNpYWMRSZkCQX3rZa7/sA/WYbeoKDiBtHbQusF4I8mbm+ 385Gqc0wc9u1/RmHSyf+fvac0YfcmoGz8tVW3zwmJnYcFxJYhzBpK70FeYe4sA9ONN 8k8RcPuApOOZNBas84sRHCZ5UOYna7nLs0BPv1zNOowrOTSQ0Z4H9+bCKstTfPAM6p pOGg/SlEVU+/YiBhKeg2is8TWNY9RQiZLfmAlQn7ZDvgM7xdXnUpg0HBpa/Mi05HKr c6aYUD9b6Dmpg== Date: Wed, 12 Jun 2024 16:48:17 +0100 From: Lee Jones To: Andre Przywara Cc: Chen-Yu Tsai , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Jernej Skrabec , Samuel Holland , Ryan Walklin , Chris Morgan Subject: Re: [PATCH v2 1/5] mfd: axp20x: AXP717: Fix missing IRQ status registers range Message-ID: <20240612154817.GH1504919@google.com> References: <20240418000736.24338-1-andre.przywara@arm.com> <20240418000736.24338-2-andre.przywara@arm.com> <20240502093907.GM5338@google.com> <56aef347-7582-497e-be02-d82eda7b3528@arm.com> <20240612152510.GE1504919@google.com> <7fdc23ff-fd55-4347-ac61-dd115eff6ff1@arm.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7fdc23ff-fd55-4347-ac61-dd115eff6ff1@arm.com> On Wed, 12 Jun 2024, Andre Przywara wrote: > Hi, > > On 12/06/2024 16:25, Lee Jones wrote: > > On Wed, 12 Jun 2024, Andre Przywara wrote: > > > > > Hi Lee, > > > > > > On 02/05/2024 10:39, Lee Jones wrote: > > > > On Thu, 18 Apr 2024, Andre Przywara wrote: > > > > > > > > > While we list the "IRQ status *and acknowledge*" registers as volatile, > > > > > they are missing from the writable range array, so acknowledging any > > > > > interrupts was met with an -EIO error. > > > > > > > > > > Add the five registers that hold those bits to the writable array. > > > > > > > > > > Fixes: b5bfc8ab2484 ("mfd: axp20x: Add support for AXP717 PMIC") > > > > > Reported-by: Chris Morgan > > > > > Signed-off-by: Andre Przywara > > > > > --- > > > > > drivers/mfd/axp20x.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > Acked-by: Lee Jones > > > > > > Can you please take just this patch as a fix for 6.10? This fixes the power > > > key operation. > > > This applies cleanly on top of v6.10-rc3, so there is no need for any extra > > > immutable branch or coordination with regulator. > > > (The same is true independently for patch 2/5, on the regulator side). > > > > What does the Fixes: commit break? > > > > Or is it the case that it never worked properly? > > The interrupt part never worked properly, but so far that's only needed for > the power key operation. Unfortunately that part wasn't tested properly > initially, so the patches were merged into your tree before that. This doesn't sounds like a -fixes candidate. I'll mark the set for v6.11. -- Lee Jones [李琼斯]