From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CDAB5194153; Fri, 14 Jun 2024 10:02:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718359330; cv=none; b=bB6j4x5qZlTG0TtxCHXf22llBfHgyRNF2kmVWb06qIqQkEafp0M4vDN1MjhwL1B5Lg7RIFcSDuGTaEPwlaiU7quE9lELYQY7FTZku0ap7XxYfpQuxxXbRkKmX8Fsnt9SNAE2Bkj9fSjmYT7lLtnty11bnNEsnPyzdWejB46gc3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718359330; c=relaxed/simple; bh=h+C+mpAk7vxV3inJhnDBH59Xi0o0Ki586l+o5iTAv6A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=XM8cTblLiJxsHKPoht3jTutdi9K5s6dtXmTAC9WkhdT4lleRmu+8EwE/4cqIodg4ZbsqdmFKyWqf6kV7zbk1oBKnd1XT15L6wHz4XTEN7wRzBZPjHFdESlhz46/uyf0bfE/squedK7yxpNU/Mxv//9R8SaP9f9l3bIdAPmx+baM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9E52DA7; Fri, 14 Jun 2024 03:02:32 -0700 (PDT) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D90973F5A1; Fri, 14 Jun 2024 03:02:05 -0700 (PDT) Date: Fri, 14 Jun 2024 11:01:56 +0100 From: Andre Przywara To: Lee Jones , Philippe Simons Cc: Chen-Yu Tsai , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Jernej Skrabec , Samuel Holland , Ryan Walklin , Chris Morgan Subject: Re: [PATCH v2 2/5] regulator: axp20x: AXP717: fix LDO supply rails and off-by-ones Message-ID: <20240614110156.230f5109@donnerap.manchester.arm.com> In-Reply-To: <20240614081224.GD2561462@google.com> References: <20240418000736.24338-1-andre.przywara@arm.com> <20240418000736.24338-3-andre.przywara@arm.com> <20240614081224.GD2561462@google.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 14 Jun 2024 09:12:24 +0100 Lee Jones wrote: Hi Lee, > On Wed, 12 Jun 2024, Andre Przywara wrote: > > > Hi Broonie, > > > > On 18/04/2024 01:07, Andre Przywara wrote: > > > The X-Powers AXP717 PMIC has separate input supply pins for each group > > > of LDOs, so they are not all using the same DCDC1 input, as described > > > currently. > > > > > > Replace the "supply" member of each LDO description with the respective > > > group supply name, so that the supply dependencies can be correctly > > > described in the devicetree. > > > > > > Also fix two off-by-ones in the regulator macros, after some double > > > checking the numbers against the datasheet. This uncovered a bug in the > > > datasheet: add a comment to document this. > > > > > > Fixes: d2ac3df75c3a ("regulator: axp20x: add support for the AXP717") > > > Signed-off-by: Andre Przywara > > > > Can you please take (at least) this one patch as a fix for 6.10? Applies > > cleanly on top of v6.10-rc3. The changes are not super-critical, but worth > > fixing nevertheless. > > FWIW, I have no idea what's going on with this set now. > > Once all of the necessary patches have been expedited, please gather > together what's left and I'll take them via MFD. Yes, we dropped the ball on this one a bit, apologies. Broonie just took 2/5, so I will resend 3/5-5/5 as a new series, targeting 6.11. Cheers, Andre.